dm log writes: move IO accounting earlier to fix error path
authorMikulas Patocka <mpatocka@redhat.com>
Tue, 30 Aug 2016 20:11:53 +0000 (16:11 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 24 Sep 2016 08:07:40 +0000 (10:07 +0200)
commit319930894f3614de9dabd1e4fae34328d4274a6e
tree734c05febdcd3c4d72f63ccf1efb570d0bf4e80a
parent52fe28832acd3a5174e94a3439af8d3b51968b37
dm log writes: move IO accounting earlier to fix error path

commit a5d60783df61fbb67b7596b8a0f6b4b2e05251d5 upstream.

Move log_one_block()'s atomic_inc(&lc->io_blocks) before bio_alloc() to
fix a bug that the target hangs if bio_alloc() fails.  The error path
does put_io_block(lc), so atomic_inc(&lc->io_blocks) must occur before
invoking the error path to avoid underflow of lc->io_blocks.

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Reviewed-by: Josef Bacik <jbacik@fb.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/md/dm-log-writes.c