iscsi-target: Fix iscsit_transport reference leak during NP thread reset
authorNicholas Bellinger <nab@linux-iscsi.org>
Sun, 18 Aug 2013 22:07:44 +0000 (15:07 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 8 Sep 2013 05:09:59 +0000 (22:09 -0700)
commit258d670469ce3b3e8d465c8a503406181e7bede0
treeb8faff50c7d1e55f36a11d96f7a6dcfc759223ef
parentce799c71c8c08ad500f4ad56c3bac2c8ac435d9f
iscsi-target: Fix iscsit_transport reference leak during NP thread reset

commit c9a03c12464c851e691e8d5b6c9deba779c512e0 upstream.

This patch fixes a bug in __iscsi_target_login_thread() where an explicit
network portal thread reset ends up leaking the iscsit_transport module
reference, along with the associated iscsi_conn allocation.

This manifests itself with iser-target where a NP reset causes the extra
iscsit_transport reference to be taken in iscsit_conn_set_transport()
during the reset, which prevents the ib_isert module from being unloaded
after the NP thread shutdown has finished.

Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/target/iscsi/iscsi_target_login.c