[SCSI] Fix erratic device offline during EH
authorJames Bottomley <jbottomley@parallels.com>
Mon, 11 Nov 2013 12:44:53 +0000 (13:44 +0100)
committerJames Bottomley <JBottomley@Parallels.com>
Thu, 19 Dec 2013 15:39:02 +0000 (07:39 -0800)
commit2451079bc2ae1334058be8babd44be03ecfa7041
tree6c1e7c36d47108fb094a8e97062b56fe573e16e8
parent1a4049ddfdaa75db7c9927dbc4d991bd73f923a0
[SCSI] Fix erratic device offline during EH

Commit 18a4d0a22ed6c54b67af7718c305cd010f09ddf8
(Handle disk devices which can not process medium access commands)
was introduced to offline any device which cannot process medium
access commands.
However, commit 3eef6257de48ff84a5d98ca533685df8a3beaeb8
(Reduce error recovery time by reducing use of TURs) reduced
the number of TURs by sending it only on the first failing
command, which might or might not be a medium access command.
So in combination this results in an erratic device offlining
during EH; if the command where the TUR was sent upon happens
to be a medium access command the device will be set offline,
if not everything proceeds as normal.

This patch moves the check to the final test, eliminating
this problem.

Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/scsi_error.c
drivers/scsi/sd.c
include/scsi/scsi_driver.h