svcrpc: document lack of some memory barriers
authorJ. Bruce Fields <bfields@redhat.com>
Fri, 9 Oct 2015 01:44:07 +0000 (01:44 +0000)
committerJ. Bruce Fields <bfields@redhat.com>
Tue, 10 Nov 2015 22:02:47 +0000 (17:02 -0500)
commit0442f14b15f8e7a8b3778a9f8cf640ef89b2df26
treedd7cae613d5d154bd945b9c140d4764074bbbe08
parent7fc0564e3a8d16df096f48c9c6425ba84d945c6e
svcrpc: document lack of some memory barriers

We're missing memory barriers in net/sunrpc/svcsock.c in some spots we'd
expect them.  But it doesn't appear they're necessary in our case, and
this is likely a hot path--for now just document the odd behavior.

Kosuke Tatsukawa found this issue while looking through the linux source
code for places calling waitqueue_active() before wake_up*(), but
without preceding memory barriers, after sending a patch to fix a
similar issue in drivers/tty/n_tty.c  (Details about the original issue
can be found here: https://lkml.org/lkml/2015/9/28/849).

Reported-by: Kosuke Tatsukawa <tatsu@ab.jp.nec.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
net/sunrpc/svcsock.c