[RuntimeDyldELF] Improve GOT support
authorKeno Fischer <kfischer@college.harvard.edu>
Tue, 14 Apr 2015 02:10:35 +0000 (02:10 +0000)
committerKeno Fischer <kfischer@college.harvard.edu>
Tue, 14 Apr 2015 02:10:35 +0000 (02:10 +0000)
commit4edb309c27d172ca2e080fd15926a63544ffe7f4
treeee69286f42e3a78585df692119166049fa2ac3aa
parent79666c21ab6d29d9c5b69d3d7690a043c9d84c9a
[RuntimeDyldELF] Improve GOT support

Summary:
This is the first in a series of patches to eventually add support for TLS relocations to RuntimeDyld. This patch resolves an issue in the current GOT handling, where GOT entries would be reused between object files, which leads to the same situation that necessitates the GOT in the first place, i.e. that the 32-bit offset can not cover all of the address space. Thus this patch makes the GOT object-file-local.
Unfortunately, this still isn't quite enough, because the MemoryManager does not yet guarantee that sections are allocated sufficiently close to each other, even if they belong to the same object file. To address this concern, this patch also adds a small API abstraction on top of the GOT allocation mechanism that will allow (temporarily, until the MemoryManager is improved) using the stub mechanism instead of allocating a different section. The actual switch from separate section to stub mechanism will be part of a follow-on commit, so that it can be easily reverted independently at the appropriate time.

Test Plan: Includes a test case where the GOT of two object files is artificially forced to be apart by several GB.

Reviewers: lhames

Reviewed By: lhames

Subscribers: llvm-commits

Differential Revision: http://reviews.llvm.org/D8813

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@234839 91177308-0d34-0410-b5e6-96231b3b80d8
lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp
lib/ExecutionEngine/RuntimeDyld/RuntimeDyldCheckerImpl.h
lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp
lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.h
lib/ExecutionEngine/RuntimeDyld/RuntimeDyldImpl.h
test/ExecutionEngine/MCJIT/cross-module-sm-pic-a.ll
test/ExecutionEngine/RuntimeDyld/X86/ELF_x64-64_PIC_relocations.s [new file with mode: 0644]
test/ExecutionEngine/RuntimeDyld/X86/Inputs/ExternalGlobal.ll [new file with mode: 0644]