X-Git-Url: http://plrg.eecs.uci.edu/git/?a=blobdiff_plain;f=threads.cc;h=f24010697d60f306de512ab40fecdece88875cdd;hb=ca068852b58dc76016534ba38a00faf054c7efb2;hp=10ff3c5d6b437fadcc4945f94102207e1d9cca5f;hpb=1d6c949fef3b5da936f8499dde464f8df634267a;p=model-checker.git

diff --git a/threads.cc b/threads.cc
index 10ff3c5..f240106 100644
--- a/threads.cc
+++ b/threads.cc
@@ -1,30 +1,57 @@
-#include <stdlib.h>
+/** @file threads.cc
+ *  @brief Thread functions.
+ */
 
 #include "libthreads.h"
-#include "schedule.h"
 #include "common.h"
 #include "threads.h"
 
 /* global "model" object */
 #include "model.h"
 
-#define STACK_SIZE (1024 * 1024)
-
+/** Allocate a stack for a new thread. */
 static void * stack_allocate(size_t size)
 {
-	return userMalloc(size);
+	return malloc(size);
 }
 
+/** Free a stack for a terminated thread. */
 static void stack_free(void *stack)
 {
-	userFree(stack);
+	free(stack);
 }
 
+/** Return the currently executing thread. */
+
 Thread * thread_current(void)
 {
+	ASSERT(model);
 	return model->scheduler->get_current_thread();
 }
 
+/**
+ * Provides a startup wrapper for each thread, allowing some initial
+ * model-checking data to be recorded. This method also gets around makecontext
+ * not being 64-bit clean
+ * @todo We should make the START event always immediately follow the
+ * CREATE event, so we don't get redundant traces...
+ */
+
+void thread_startup() {
+	Thread * curr_thread = thread_current();
+
+	/* Add dummy "start" action, just to create a first clock vector */
+	model->switch_to_master(new ModelAction(THREAD_START, std::memory_order_seq_cst, curr_thread));
+
+	/* Call the actual thread function */
+	curr_thread->start_routine(curr_thread->arg);
+}
+
+/** Create a thread context for a new thread so we can use
+ *  setcontext/getcontext/swapcontext to swap it out.
+ *  @return 0 on success.
+ */
+
 int Thread::create_context()
 {
 	int ret;
@@ -39,7 +66,7 @@ int Thread::create_context()
 	context.uc_stack.ss_size = STACK_SIZE;
 	context.uc_stack.ss_flags = 0;
 	context.uc_link = model->get_system_context();
-	makecontext(&context, start_routine, 1, arg);
+	makecontext(&context, thread_startup, 0);
 
 	return 0;
 }
@@ -54,6 +81,9 @@ int Thread::swap(ucontext_t *ctxt, Thread *t)
 	return swapcontext(ctxt, &t->context);
 }
 
+
+/** Terminate a thread and free its stack. */
+
 void Thread::complete()
 {
 	if (state != THREAD_COMPLETED) {
@@ -64,20 +94,26 @@ void Thread::complete()
 	}
 }
 
-
-Thread::Thread(thrd_t *t, void (*func)(), void *a) {
+/** Create a new thread.
+ *  Takes the following parameters:
+ *  @param t The thread identifier of the newly created thread.
+ *  @param func  The function that the thread will call.
+ *  @param a The parameter to pass to this function. */
+
+Thread::Thread(thrd_t *t, void (*func)(void *), void *a) :
+	start_routine(func),
+	arg(a),
+	user_thread(t),
+	state(THREAD_CREATED),
+	last_action_val(VALUE_NONE)
+{
 	int ret;
 
-	user_thread = t;
-	start_routine = func;
-	arg = a;
-
 	/* Initialize state */
 	ret = create_context();
 	if (ret)
 		printf("Error in create_context\n");
 
-	state = THREAD_CREATED;
 	id = model->get_next_id();
 	*user_thread = id;
 	parent = thread_current();
@@ -89,6 +125,8 @@ Thread::~Thread()
 	model->remove_thread(this);
 }
 
+/** Return the thread_id_t corresponding to this Thread object. */
+
 thread_id_t Thread::get_id()
 {
 	return id;