X-Git-Url: http://plrg.eecs.uci.edu/git/?a=blobdiff_plain;f=folly%2FConcurrentSkipList.h;h=a4b749bbd92280ed481174dac56f82ccf031a011;hb=64072ab5f788cd1081bdd98ba6dbaabbcd1fafbd;hp=1a2fdadcd5d6f71fb638aaa52b23de0689fa1548;hpb=fbfe105970bcf88e8c123046f84bebdfe24f8801;p=folly.git diff --git a/folly/ConcurrentSkipList.h b/folly/ConcurrentSkipList.h index 1a2fdadc..a4b749bb 100644 --- a/folly/ConcurrentSkipList.h +++ b/folly/ConcurrentSkipList.h @@ -258,7 +258,9 @@ class ConcurrentSkipList { // Returns the node if found, nullptr otherwise. NodeType* find(const value_type &data) { auto ret = findNode(data); - if (ret.second && !ret.first->markedForRemoval()) return ret.first; + if (ret.second && !ret.first->markedForRemoval()) { + return ret.first; + } return nullptr; } @@ -369,7 +371,9 @@ class ConcurrentSkipList { nodeToDelete = succs[layer]; nodeHeight = nodeToDelete->height(); nodeGuard = nodeToDelete->acquireGuard(); - if (nodeToDelete->markedForRemoval()) return false; + if (nodeToDelete->markedForRemoval()) { + return false; + } nodeToDelete->setMarkedForRemoval(); isMarked = true; } @@ -402,7 +406,9 @@ class ConcurrentSkipList { for (int layer = maxLayer(); layer >= 0; --layer) { do { node = pred->skip(layer); - if (node) pred = node; + if (node) { + pred = node; + } } while (node != nullptr); } return pred == head_.load(std::memory_order_relaxed) @@ -445,7 +451,9 @@ class ConcurrentSkipList { while (!found) { // stepping down for (; ht > 0 && less(data, node = pred->skip(ht - 1)); --ht) {} - if (ht == 0) return std::make_pair(node, 0); // not found + if (ht == 0) { + return std::make_pair(node, 0); // not found + } // node <= data now, but we need to fix up ht --ht; @@ -668,9 +676,11 @@ class detail::csl_iterator : explicit csl_iterator(NodeT* node = nullptr) : node_(node) {} template - csl_iterator(const csl_iterator &other, - typename std::enable_if::value>::type* - = 0) : node_(other.node_) {} + csl_iterator( + const csl_iterator& other, + typename std::enable_if< + std::is_convertible::value>::type* = nullptr) + : node_(other.node_) {} size_t nodeSize() const { return node_ == nullptr ? 0 : @@ -773,7 +783,9 @@ class ConcurrentSkipList::Skipper { */ bool to(const value_type &data) { int layer = curHeight() - 1; - if (layer < 0) return false; // reaches the end of the list + if (layer < 0) { + return false; // reaches the end of the list + } int lyr = hints_[layer]; int max_layer = maxLayer(); @@ -784,7 +796,9 @@ class ConcurrentSkipList::Skipper { int foundLayer = SkipListType:: findInsertionPoint(preds_[lyr], lyr, data, preds_, succs_); - if (foundLayer < 0) return false; + if (foundLayer < 0) { + return false; + } DCHECK(succs_[0] != nullptr) << "lyr=" << lyr << "; max_layer=" << max_layer;