X-Git-Url: http://plrg.eecs.uci.edu/git/?a=blobdiff_plain;ds=sidebyside;f=docs%2FPhabricator.rst;h=af1e4429fda9b974bbb11eefb5da7945bc42dd43;hb=bc710080950afad608b2c080e5770140f8b8245c;hp=73704d9b17d74ae414b87d084bb49e4749b88e9a;hpb=c47dfee800da307e7253ac896dbfd8439dc89c30;p=oota-llvm.git diff --git a/docs/Phabricator.rst b/docs/Phabricator.rst index 73704d9b17d..af1e4429fda 100644 --- a/docs/Phabricator.rst +++ b/docs/Phabricator.rst @@ -136,7 +136,7 @@ reviewers, the ``Differential Revision``, etc from the review and commit it to t arc commit --revision D -When committing an LLVM change that has been reviewed using +When committing a change that has been reviewed using Phabricator, the convention is for the commit message to end with the line: @@ -153,6 +153,12 @@ This allows people reading the version history to see the review for context. This also allows Phabricator to detect the commit, close the review, and add a link from the review to the commit. +If you use ``git`` or ``svn`` to commit the change and forget to add the line +to your commit message, you should close the review manually. In the web UI, +under "Leap Into Action" put the SVN revision number in the Comment, set the +Action to "Close Revision" and click Submit. Note the review must have been +Accepted first. + Abandoning a change -------------------