X-Git-Url: http://plrg.eecs.uci.edu/git/?a=blobdiff_plain;ds=sidebyside;f=cyclegraph.cc;h=e56c91285d36dd4d78374fafe9fd313ee46be0d6;hb=c0e05b3952fa7190116fdc1df124bc6fa5804027;hp=8326f28b7ee3a2c3be6332fc383f959707040eac;hpb=b69a6cb48fdd66361adae1d3bbe0c0a743830966;p=c11tester.git diff --git a/cyclegraph.cc b/cyclegraph.cc index 8326f28b..e56c9128 100644 --- a/cyclegraph.cc +++ b/cyclegraph.cc @@ -1,23 +1,19 @@ #include "cyclegraph.h" #include "action.h" #include "common.h" -#include "promise.h" -#include "model.h" +#include "threads-model.h" +#include "clockvector.h" /** Initializes a CycleGraph object. */ CycleGraph::CycleGraph() : - discovered(new HashTable(16)), - hasCycles(false), - oldCycles(false), - hasRMWViolation(false), - oldRMWViolation(false) + queue(new SnapVector()) { } /** CycleGraph destructor */ CycleGraph::~CycleGraph() { - delete discovered; + delete queue; } /** @@ -33,14 +29,23 @@ void CycleGraph::putNode(const ModelAction *act, CycleNode *node) #endif } +/** @return The corresponding CycleNode, if exists; otherwise NULL */ +CycleNode * CycleGraph::getNode_noCreate(const ModelAction *act) const +{ + return actionToNode.get(act); +} + /** * @brief Returns the CycleNode corresponding to a given ModelAction + * + * Gets (or creates, if none exist) a CycleNode corresponding to a ModelAction + * * @param action The ModelAction to find a node for * @return The CycleNode paired with this action */ CycleNode * CycleGraph::getNode(const ModelAction *action) { - CycleNode *node = actionToNode.get(action); + CycleNode *node = getNode_noCreate(action); if (node == NULL) { node = new CycleNode(action); putNode(action, node); @@ -49,49 +54,58 @@ CycleNode * CycleGraph::getNode(const ModelAction *action) } /** - * Adds an edge between two ModelActions. The ModelAction @a to is ordered - * after the ModelAction @a from. - * @param to The edge points to this ModelAction - * @param from The edge comes from this ModelAction + * Adds an edge between two CycleNodes. + * @param fromnode The edge comes from this CycleNode + * @param tonode The edge points to this CycleNode + * @return True, if new edge(s) are added; otherwise false */ -void CycleGraph::addEdge(const ModelAction *from, const ModelAction *to) +void CycleGraph::addNodeEdge(CycleNode *fromnode, CycleNode *tonode, bool forceedge) { - ASSERT(from); - ASSERT(to); - - CycleNode *fromnode = getNode(from); - CycleNode *tonode = getNode(to); - - if (!hasCycles) - hasCycles = checkReachable(tonode, fromnode); - - if (fromnode->addEdge(tonode)) - rollbackvector.push_back(fromnode); - - - CycleNode *rmwnode = fromnode->getRMW(); + //quick check whether edge is redundant + if (checkReachable(fromnode, tonode) && !forceedge) { + return; + } /* - * If the fromnode has a rmwnode that is not the tonode, we should add - * an edge between its rmwnode and the tonode - * - * If tonode is also a rmw, don't do this check as the execution is - * doomed and we'll catch the problem elsewhere, but we want to allow - * for the possibility of sending to's write value to rmwnode + * If the fromnode has a rmwnode, we should + * follow its RMW chain to add an edge at the end. */ - if (rmwnode != NULL && !to->is_rmw()) { - if (!hasCycles) - hasCycles = checkReachable(tonode, rmwnode); + while (fromnode->getRMW()) { + CycleNode *nextnode = fromnode->getRMW(); + if (nextnode == tonode) + break; + fromnode = nextnode; + } - if (rmwnode->addEdge(tonode)) - rollbackvector.push_back(rmwnode); + fromnode->addEdge(tonode); //Add edge to edgeSrcNode + + /* Propagate clock vector changes */ + if (tonode->cv->merge(fromnode->cv)) { + queue->push_back(fromnode); + while(!queue->empty()) { + const CycleNode *node = queue->back(); + queue->pop_back(); + unsigned int numedges = node->getNumEdges(); + for(unsigned int i = 0;i < numedges;i++) { + CycleNode * enode = node->getEdge(i); + if (enode->cv->merge(node->cv)) + queue->push_back(enode); + } + } } } -/** Handles special case of a RMW action. The ModelAction rmw reads - * from the ModelAction from. The key differences are: (1) no write - * can occur in between the rmw and the from action. Only one RMW - * action can read from a given write. +/** + * @brief Add an edge between a write and the RMW which reads from it + * + * Handles special case of a RMW action, where the ModelAction rmw reads from + * the ModelAction from. The key differences are: + * -# No write can occur in between the @a rmw and @a from actions. + * -# Only one RMW action can read from a given write. + * + * @param from The edge comes from this ModelAction + * @param rmw The edge points to this ModelAction; this action must read from + * the ModelAction from */ void CycleGraph::addRMWEdge(const ModelAction *from, const ModelAction *rmw) { @@ -100,13 +114,10 @@ void CycleGraph::addRMWEdge(const ModelAction *from, const ModelAction *rmw) CycleNode *fromnode = getNode(from); CycleNode *rmwnode = getNode(rmw); + /* We assume that this RMW has no RMW reading from it yet */ + ASSERT(!rmwnode->getRMW()); - /* Two RMW actions cannot read from the same write. */ - if (fromnode->setRMW(rmwnode)) { - hasRMWViolation = true; - } else { - rmwrollbackvector.push_back(fromnode); - } + fromnode->setRMW(rmwnode); /* Transfer all outgoing edges from the from node to the rmw node */ /* This process should not add a cycle because either: @@ -115,168 +126,168 @@ void CycleGraph::addRMWEdge(const ModelAction *from, const ModelAction *rmw) * (2) the fromnode is the new node and therefore it should not * have any outgoing edges. */ - for (unsigned int i = 0; i < fromnode->getNumEdges(); i++) { + for (unsigned int i = 0;i < fromnode->getNumEdges();i++) { CycleNode *tonode = fromnode->getEdge(i); if (tonode != rmwnode) { - if (rmwnode->addEdge(tonode)) - rollbackvector.push_back(rmwnode); + rmwnode->addEdge(tonode); } } + fromnode->edges.clear(); - if (!hasCycles) - hasCycles = checkReachable(rmwnode, fromnode); - - if (fromnode->addEdge(rmwnode)) - rollbackvector.push_back(fromnode); + addNodeEdge(fromnode, rmwnode, true); } -#if SUPPORT_MOD_ORDER_DUMP -void CycleGraph::dumpNodes(FILE *file) const -{ - for (unsigned int i = 0; i < nodeList.size(); i++) { - CycleNode *cn = nodeList[i]; - const ModelAction *action = cn->getAction(); - fprintf(file, "N%u [label=\"%u, T%u\"];\n", action->get_seq_number(), action->get_seq_number(), action->get_tid()); - if (cn->getRMW() != NULL) { - fprintf(file, "N%u -> N%u[style=dotted];\n", action->get_seq_number(), cn->getRMW()->getAction()->get_seq_number()); - } - for (unsigned int j = 0; j < cn->getNumEdges(); j++) { - CycleNode *dst = cn->getEdge(j); - const ModelAction *dstaction = dst->getAction(); - fprintf(file, "N%u -> N%u;\n", action->get_seq_number(), dstaction->get_seq_number()); +void CycleGraph::addEdges(SnapList * edgeset, const ModelAction *to) { + for(sllnode * it = edgeset->begin();it!=NULL;) { + ModelAction *act = it->getVal(); + CycleNode *node = getNode(act); + sllnode * it2 = it; + it2=it2->getNext(); + for(;it2!=NULL; ) { + ModelAction *act2 = it2->getVal(); + CycleNode *node2 = getNode(act2); + if (checkReachable(node, node2)) { + it = edgeset->erase(it); + goto endouterloop; + } else if (checkReachable(node2, node)) { + it2 = edgeset->erase(it2); + goto endinnerloop; + } + it2=it2->getNext(); +endinnerloop: + ; } + it=it->getNext(); +endouterloop: + ; + } + for(sllnode *it = edgeset->begin();it!=NULL;it=it->getNext()) { + ModelAction *from = it->getVal(); + addEdge(from, to, from->get_tid() == to->get_tid()); } } -void CycleGraph::dumpGraphToFile(const char *filename) const -{ - char buffer[200]; - sprintf(buffer, "%s.dot", filename); - FILE *file = fopen(buffer, "w"); - fprintf(file, "digraph %s {\n", filename); - dumpNodes(file); - fprintf(file, "}\n"); - fclose(file); -} -#endif - /** - * Checks whether one ModelAction can reach another. - * @param from The ModelAction from which to begin exploration - * @param to The ModelAction to reach - * @return True, @a from can reach @a to; otherwise, false + * @brief Adds an edge between objects + * + * This function will add an edge between any two objects which can be + * associated with a CycleNode. That is, if they have a CycleGraph::getNode + * implementation. + * + * The object to is ordered after the object from. + * + * @param to The edge points to this object, of type T + * @param from The edge comes from this object, of type U + * @return True, if new edge(s) are added; otherwise false */ -bool CycleGraph::checkReachable(const ModelAction *from, const ModelAction *to) const + +void CycleGraph::addEdge(const ModelAction *from, const ModelAction *to) { - CycleNode *fromnode = actionToNode.get(from); - CycleNode *tonode = actionToNode.get(to); + ASSERT(from); + ASSERT(to); - if (!fromnode || !tonode) - return false; + CycleNode *fromnode = getNode(from); + CycleNode *tonode = getNode(to); - return checkReachable(fromnode, tonode); + addNodeEdge(fromnode, tonode, false); } -/** - * Checks whether one CycleNode can reach another. - * @param from The CycleNode from which to begin exploration - * @param to The CycleNode to reach - * @return True, @a from can reach @a to; otherwise, false - */ -bool CycleGraph::checkReachable(const CycleNode *from, const CycleNode *to) const +void CycleGraph::addEdge(const ModelAction *from, const ModelAction *to, bool forceedge) { - std::vector< const CycleNode *, ModelAlloc > queue; - discovered->reset(); - - queue.push_back(from); - discovered->put(from, from); - while (!queue.empty()) { - const CycleNode *node = queue.back(); - queue.pop_back(); - if (node == to) - return true; - - for (unsigned int i = 0; i < node->getNumEdges(); i++) { - CycleNode *next = node->getEdge(i); - if (!discovered->contains(next)) { - discovered->put(next, next); - queue.push_back(next); - } - } - } - return false; + ASSERT(from); + ASSERT(to); + + CycleNode *fromnode = getNode(from); + CycleNode *tonode = getNode(to); + + addNodeEdge(fromnode, tonode, forceedge); } -bool CycleGraph::checkPromise(const ModelAction *fromact, Promise *promise) const -{ - std::vector< CycleNode *, ModelAlloc > queue; - discovered->reset(); - CycleNode *from = actionToNode.get(fromact); - - queue.push_back(from); - discovered->put(from, from); - while (!queue.empty()) { - CycleNode *node = queue.back(); - queue.pop_back(); - - if (promise->increment_threads(node->getAction()->get_tid())) { - return true; - } +#if SUPPORT_MOD_ORDER_DUMP - for (unsigned int i = 0; i < node->getNumEdges(); i++) { - CycleNode *next = node->getEdge(i); - if (!discovered->contains(next)) { - discovered->put(next, next); - queue.push_back(next); - } - } - } - return false; +static void print_node(FILE *file, const CycleNode *node, int label) +{ + const ModelAction *act = node->getAction(); + modelclock_t idx = act->get_seq_number(); + fprintf(file, "N%u", idx); + if (label) + fprintf(file, " [label=\"N%u, T%u\"]", idx, act->get_tid()); } -void CycleGraph::startChanges() +static void print_edge(FILE *file, const CycleNode *from, const CycleNode *to, const char *prop) { - ASSERT(rollbackvector.size() == 0); - ASSERT(rmwrollbackvector.size() == 0); - ASSERT(oldCycles == hasCycles); - ASSERT(oldRMWViolation == hasRMWViolation); + print_node(file, from, 0); + fprintf(file, " -> "); + print_node(file, to, 0); + if (prop && strlen(prop)) + fprintf(file, " [%s]", prop); + fprintf(file, ";\n"); } -/** Commit changes to the cyclegraph. */ -void CycleGraph::commitChanges() +void CycleGraph::dot_print_node(FILE *file, const ModelAction *act) { - rollbackvector.resize(0); - rmwrollbackvector.resize(0); - oldCycles = hasCycles; - oldRMWViolation = hasRMWViolation; + print_node(file, getNode(act), 1); } -/** Rollback changes to the previous commit. */ -void CycleGraph::rollbackChanges() +void CycleGraph::dot_print_edge(FILE *file, const ModelAction *from, const ModelAction *to, const char *prop) { - for (unsigned int i = 0; i < rollbackvector.size(); i++) { - rollbackvector[i]->popEdge(); - } + CycleNode *fromnode = getNode(from); + CycleNode *tonode = getNode(to); - for (unsigned int i = 0; i < rmwrollbackvector.size(); i++) { - rmwrollbackvector[i]->clearRMW(); + print_edge(file, fromnode, tonode, prop); +} + +void CycleGraph::dumpNodes(FILE *file) const +{ + for (unsigned int i = 0;i < nodeList.size();i++) { + CycleNode *n = nodeList[i]; + print_node(file, n, 1); + fprintf(file, ";\n"); + if (n->getRMW()) + print_edge(file, n, n->getRMW(), "style=dotted"); + for (unsigned int j = 0;j < n->getNumEdges();j++) + print_edge(file, n, n->getEdge(j), NULL); } +} - hasCycles = oldCycles; - hasRMWViolation = oldRMWViolation; - rollbackvector.resize(0); - rmwrollbackvector.resize(0); +void CycleGraph::dumpGraphToFile(const char *filename) const +{ + char buffer[200]; + sprintf(buffer, "%s.dot", filename); + FILE *file = fopen(buffer, "w"); + fprintf(file, "digraph %s {\n", filename); + dumpNodes(file); + fprintf(file, "}\n"); + fclose(file); } +#endif -/** @returns whether a CycleGraph contains cycles. */ -bool CycleGraph::checkForCycles() const +/** + * Checks whether one CycleNode can reach another. + * @param from The CycleNode from which to begin exploration + * @param to The CycleNode to reach + * @return True, @a from can reach @a to; otherwise, false + */ +bool CycleGraph::checkReachable(const CycleNode *from, const CycleNode *to) const { - return hasCycles; + return to->cv->synchronized_since(from->action); } -bool CycleGraph::checkForRMWViolation() const +/** + * Checks whether one ModelAction can reach another ModelAction + * @param from The ModelAction from which to begin exploration + * @param to The ModelAction to reach + * @return True, @a from can reach @a to; otherwise, false + */ +bool CycleGraph::checkReachable(const ModelAction *from, const ModelAction *to) const { - return hasRMWViolation; + CycleNode *fromnode = getNode_noCreate(from); + CycleNode *tonode = getNode_noCreate(to); + + if (!fromnode || !tonode) + return false; + + return checkReachable(fromnode, tonode); } /** @@ -285,13 +296,14 @@ bool CycleGraph::checkForRMWViolation() const */ CycleNode::CycleNode(const ModelAction *act) : action(act), - hasRMW(NULL) + hasRMW(NULL), + cv(new ClockVector(NULL, act)) { } /** * @param i The index of the edge to return - * @returns The a CycleNode edge indexed by i + * @returns The CycleNode edge indexed by i */ CycleNode * CycleNode::getEdge(unsigned int i) const { @@ -304,14 +316,18 @@ unsigned int CycleNode::getNumEdges() const return edges.size(); } -CycleNode * CycleNode::getBackEdge(unsigned int i) const +/** + * @brief Remove a (forward) edge from this CycleNode + * @return The CycleNode which was popped, if one exists; otherwise NULL + */ +CycleNode * CycleNode::removeEdge() { - return back_edges[i]; -} + if (edges.empty()) + return NULL; -unsigned int CycleNode::getNumBackEdges() const -{ - return back_edges.size(); + CycleNode *ret = edges.back(); + edges.pop_back(); + return ret; } /** @@ -319,14 +335,12 @@ unsigned int CycleNode::getNumBackEdges() const * @param node The node to which we add a directed edge * @return True if this edge is a new edge; false otherwise */ -bool CycleNode::addEdge(CycleNode *node) +void CycleNode::addEdge(CycleNode *node) { - for (unsigned int i = 0; i < edges.size(); i++) + for (unsigned int i = 0;i < edges.size();i++) if (edges[i] == node) - return false; + return; edges.push_back(node); - node->back_edges.push_back(this); - return true; } /** @returns the RMW CycleNode that reads from the current CycleNode */