/*
- * Copyright 2014 Facebook, Inc.
+ * Copyright 2016 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
*/
#include <folly/Logging.h>
-#include <gflags/gflags.h>
-#include <gtest/gtest.h>
-#include <folly/Benchmark.h>
+
+#include <folly/portability/GTest.h>
+
#include <vector>
TEST(LogEveryMs, basic) {
}
bool atLeastOneIsGood = false;
- for (int i = 0; i < hist.size() - 1; ++i) {
+ for (size_t i = 0; i < hist.size() - 1; ++i) {
auto delta = hist[i + 1] - hist[i];
if (delta > std::chrono::milliseconds(5) &&
delta < std::chrono::milliseconds(15)) {
EXPECT_TRUE(atLeastOneIsGood);
}
-BENCHMARK(skip_overhead, iter) {
- auto prev = FLAGS_minloglevel;
- FLAGS_minloglevel = 2;
-
- for (unsigned i = 0; i < iter; ++i) {
- FB_LOG_EVERY_MS(INFO, 1000) << "every 1s";
- }
-
- FLAGS_minloglevel = prev;
-}
-
-BENCHMARK(dev_null_log_overhead, iter) {
- auto prev = FLAGS_minloglevel;
- FLAGS_minloglevel = 2;
+TEST(LogEveryMs, zero) {
+ int count = 0;
- for (unsigned i = 0; i < iter; ++i) {
- FB_LOG_EVERY_MS(INFO, -1) << "every -1ms";
+ for (int i = 0; i < 10; ++i) {
+ FB_LOG_EVERY_MS(INFO, 0)
+ << "test msg " << ++count;
}
- FLAGS_minloglevel = prev;
-}
-
-// ============================================================================
-// folly/test/LoggingTest.cpp relative time/iter iters/s
-// ============================================================================
-// skip_overhead 36.37ns 27.49M
-// dev_null_log_overhead 2.61us 382.57K
-// ============================================================================
-
-int main(int argc, char** argv) {
- testing::InitGoogleTest(&argc, argv);
- google::ParseCommandLineFlags(&argc, &argv, true);
-
- auto rv = RUN_ALL_TESTS();
- if (!rv && FLAGS_benchmark) {
- folly::runBenchmarks();
- }
- return rv;
+ EXPECT_EQ(10, count);
}