* limitations under the License.
*/
+#ifndef __STDC_FORMAT_MACROS
+#define __STDC_FORMAT_MACROS 1
+#endif
+
+#include <boost/lexical_cast.hpp>
#include <folly/Conv.h>
#include <folly/Foreach.h>
-#include <boost/lexical_cast.hpp>
#include <gtest/gtest.h>
+#include <algorithm>
+#include <cinttypes>
#include <limits>
+#include <sstream>
#include <stdexcept>
+#include <tuple>
using namespace std;
using namespace folly;
// try the first X nonnegatives.
// Covers some more cases of 2^p, 10^p
for (uint64_t i = 0; i < 100000; i++) {
- snprintf(buffer, sizeof(buffer), "%lu", i);
+ snprintf(buffer, sizeof(buffer), "%" PRIu64, i);
EXPECT_EQ(strlen(buffer), digits10(i));
}
// try powers of 2
power = 1;
for (int p = 0; p < 64; p++) {
- snprintf(buffer, sizeof(buffer), "%lu", power);
+ snprintf(buffer, sizeof(buffer), "%" PRIu64, power);
EXPECT_EQ(strlen(buffer), digits10(power));
- snprintf(buffer, sizeof(buffer), "%lu", power - 1);
+ snprintf(buffer, sizeof(buffer), "%" PRIu64, power - 1);
EXPECT_EQ(strlen(buffer), digits10(power - 1));
- snprintf(buffer, sizeof(buffer), "%lu", power + 1);
+ snprintf(buffer, sizeof(buffer), "%" PRIu64, power + 1);
EXPECT_EQ(strlen(buffer), digits10(power + 1));
power *= 2;
}
// try powers of 10
power = 1;
for (int p = 0; p < 20; p++) {
- snprintf(buffer, sizeof(buffer), "%lu", power);
+ snprintf(buffer, sizeof(buffer), "%" PRIu64, power);
EXPECT_EQ(strlen(buffer), digits10(power));
- snprintf(buffer, sizeof(buffer), "%lu", power - 1);
+ snprintf(buffer, sizeof(buffer), "%" PRIu64, power - 1);
EXPECT_EQ(strlen(buffer), digits10(power - 1));
- snprintf(buffer, sizeof(buffer), "%lu", power + 1);
+ snprintf(buffer, sizeof(buffer), "%" PRIu64, power + 1);
EXPECT_EQ(strlen(buffer), digits10(power + 1));
power *= 10;
}
int intV = 42;
EXPECT_EQ(to<int>(intV), 42);
- float floatV = 4.2;
+ float floatV = 4.2f;
EXPECT_EQ(to<float>(floatV), 4.2f);
double doubleV = 0.42;
}
TEST(Conv, Floating2Floating) {
- float f1 = 1e3;
+ float f1 = 1e3f;
double d1 = to<double>(f1);
EXPECT_EQ(f1, d1);
svalue = 0;
EXPECT_EQ(to<String>(svalue), "0");
+ value = ~__int128(0);
+ EXPECT_EQ(to<String>(value), "340282366920938463463374607431768211455");
+
+ svalue = -(Uint(1) << 127);
+ EXPECT_EQ(to<String>(svalue), "-170141183460469231731687303715884105728");
+
+ svalue = (Uint(1) << 127) - 1;
+ EXPECT_EQ(to<String>(svalue), "170141183460469231731687303715884105727");
+
// TODO: the following do not compile to<__int128> ...
#if 0
#endif
TEST(Conv, Integral2String) {
- testIntegral2String<std::string, char, short, int, long>();
- testIntegral2String<fbstring, char, short, int, long>();
+ testIntegral2String<std::string, int8_t, int16_t, int32_t, int64_t>();
+ testIntegral2String<fbstring, int8_t, int16_t, int32_t, int64_t>();
#if FOLLY_HAVE_INT128_T
test128Bit2String<std::string>();
}
TEST(Conv, String2Integral) {
- testString2Integral<const char*, signed char, short, int, long, long long>();
- testString2Integral<std::string, signed char, short, int, long, long long>();
- testString2Integral<fbstring, signed char, short, int, long, long long>();
+ testString2Integral<const char*, int8_t, int16_t, int32_t, int64_t>();
+ testString2Integral<std::string, int8_t, int16_t, int32_t, int64_t>();
+ testString2Integral<fbstring, int8_t, int16_t, int32_t, int64_t>();
// Testing the behavior of the StringPiece* API
// StringPiece* normally parses as much valid data as it can,
}
TEST(Conv, StringPieceToDouble) {
- string s = "2134123.125 zorro";
- StringPiece pc(s);
- EXPECT_EQ(to<double>(&pc), 2134123.125);
- EXPECT_EQ(pc, " zorro");
-
- EXPECT_THROW(to<double>(StringPiece(s)), std::range_error);
- EXPECT_EQ(to<double>(StringPiece(s.data(), pc.data())), 2134123.125);
+ vector<tuple<const char*, const char*, double>> strs{
+ make_tuple("2134123.125 zorro", " zorro", 2134123.125),
+ make_tuple(" 2134123.125 zorro", " zorro", 2134123.125),
+ make_tuple(" 2134123.125 zorro", " zorro", 2134123.125),
+ make_tuple(" 2134123.125 zorro ", " zorro ", 2134123.125),
+ make_tuple("2134123.125zorro", "zorro", 2134123.125),
+ make_tuple("0 zorro", " zorro", 0.0),
+ make_tuple(" 0 zorro", " zorro", 0.0),
+ make_tuple(" 0 zorro", " zorro", 0.0),
+ make_tuple(" 0 zorro ", " zorro ", 0.0),
+ make_tuple("0zorro", "zorro", 0.0),
+ make_tuple("0.0 zorro", " zorro", 0.0),
+ make_tuple(" 0.0 zorro", " zorro", 0.0),
+ make_tuple(" 0.0 zorro", " zorro", 0.0),
+ make_tuple(" 0.0 zorro ", " zorro ", 0.0),
+ make_tuple("0.0zorro", "zorro", 0.0),
+ };
+ for (const auto& s : strs) {
+ StringPiece pc(get<0>(s));
+ EXPECT_EQ(get<2>(s), to<double>(&pc)) << "\"" << get<0>(s) << "\"";
+ EXPECT_EQ(get<1>(s), pc);
+ EXPECT_THROW(to<double>(StringPiece(get<0>(s))), std::range_error);
+ EXPECT_EQ(get<2>(s), to<double>(StringPiece(get<0>(s), pc.data())));
+ }
-// Test NaN conversion
+ // Test NaN conversion
try {
to<double>("not a number");
EXPECT_TRUE(false);
auto u = to<uint32_t>(E::x);
EXPECT_GT(u, 0);
EXPECT_EQ(u, 3000000000U);
- auto s = to<string>(E::x);
- EXPECT_EQ("3000000000", s);
- auto e = to<E>(3000000000U);
- EXPECT_EQ(e, E::x);
- try {
- auto i = to<int32_t>(E::x);
- LOG(ERROR) << "to<int32_t> returned " << i << " instead of throwing";
- EXPECT_TRUE(false);
- } catch (std::range_error& e) {
- }
+ EXPECT_EQ("3000000000", to<string>(E::x));
+ EXPECT_EQ(E::x, to<E>(3000000000U));
+ EXPECT_EQ(E::x, to<E>("3000000000"));
+ E e;
+ EXPECT_TRUE(parseTo("3000000000", e).hasValue());
+ EXPECT_EQ(E::x, e);
+ EXPECT_THROW(to<int32_t>(E::x), std::range_error);
}
// Multi-argument to<string> uses toAppend, a different code path than
EXPECT_EQ(buf5, sp5.begin());
}
+TEST(Conv, Transform) {
+ const std::vector<int64_t> in{1, 2, 3};
+ std::vector<std::string> out(in.size());
+ std::transform(in.begin(), in.end(), out.begin(), to<std::string, int64_t>);
+ const std::vector<std::string> ref{"1", "2", "3"};
+ EXPECT_EQ(ref, out);
+}
+
+TEST(Conv, FloatToInt) {
+ EXPECT_EQ(to<int>(42.0f), 42);
+ EXPECT_EQ(to<int8_t>(-128.0f), int8_t(-128));
+ EXPECT_THROW(to<int8_t>(-129.0), std::range_error);
+ EXPECT_THROW(to<int8_t>(127.001), std::range_error);
+ EXPECT_THROW(to<uint8_t>(-0.0001), std::range_error);
+ EXPECT_THROW(
+ to<uint64_t>(static_cast<float>(std::numeric_limits<uint64_t>::max())),
+ std::range_error);
+}
+
+TEST(Conv, IntToFloat) {
+ EXPECT_EQ(to<float>(42ULL), 42.0);
+ EXPECT_EQ(to<float>(int8_t(-128)), -128.0);
+ EXPECT_THROW(
+ to<float>(std::numeric_limits<uint64_t>::max()), std::range_error);
+ EXPECT_THROW(
+ to<float>(std::numeric_limits<int64_t>::max()), std::range_error);
+ EXPECT_THROW(
+ to<float>(std::numeric_limits<int64_t>::min() + 1), std::range_error);
+#if FOLLY_HAVE_INT128_T
+ EXPECT_THROW(
+ to<double>(std::numeric_limits<unsigned __int128>::max()),
+ std::range_error);
+ EXPECT_THROW(
+ to<double>(std::numeric_limits<__int128>::max()), std::range_error);
+ EXPECT_THROW(
+ to<double>(std::numeric_limits<__int128>::min() + 1), std::range_error);
+#endif
+}
+
+TEST(Conv, BoolToFloat) {
+ EXPECT_EQ(to<double>(true), 1.0);
+ EXPECT_EQ(to<double>(false), 0.0);
+}
+
+TEST(Conv, FloatToBool) {
+ EXPECT_EQ(to<bool>(1.0), true);
+ EXPECT_EQ(to<bool>(0.0), false);
+ EXPECT_EQ(to<bool>(2.7), true);
+ EXPECT_EQ(to<bool>(std::numeric_limits<double>::max()), true);
+ EXPECT_EQ(to<bool>(std::numeric_limits<double>::min()), true);
+ EXPECT_EQ(to<bool>(std::numeric_limits<double>::lowest()), true);
+ EXPECT_EQ(to<bool>(std::numeric_limits<double>::quiet_NaN()), true);
+ EXPECT_EQ(to<bool>(std::numeric_limits<double>::infinity()), true);
+ EXPECT_EQ(to<bool>(-std::numeric_limits<double>::infinity()), true);
+}
+
+namespace {
+
+template <typename F>
+void testConvError(
+ F&& expr,
+ const char* exprStr,
+ ConversionCode code,
+ const char* value,
+ bool quotedValue,
+ int line) {
+ std::string where = to<std::string>(__FILE__, "(", line, "): ");
+ try {
+ auto res = expr();
+ EXPECT_TRUE(false) << where << exprStr << " -> " << res;
+ } catch (const ConversionError& e) {
+ EXPECT_EQ(code, e.errorCode()) << where << exprStr;
+ std::string str(e.what());
+ EXPECT_FALSE(str.empty()) << where << exprStr << " -> " << str;
+ auto pos = str.find(':');
+ if (value) {
+ std::ostringstream exp;
+ exp << str.substr(0, pos) + ": ";
+ if (quotedValue) {
+ exp << "\"" << value << "\"";
+ } else {
+ exp << value;
+ }
+ EXPECT_EQ(exp.str(), str) << where << exprStr << " -> " << str;
+ } else {
+ EXPECT_EQ(pos, std::string::npos) << where << exprStr << " -> " << str;
+ }
+ }
+}
+}
+
+#define EXPECT_CONV_ERROR_QUOTE(expr, code, value, quoted) \
+ testConvError( \
+ [&] { return expr; }, \
+ #expr, \
+ ConversionCode::code, \
+ value, \
+ quoted, \
+ __LINE__)
+
+#define EXPECT_CONV_ERROR(expr, code, value) \
+ EXPECT_CONV_ERROR_QUOTE(expr, code, value, true)
+
+#define EXPECT_CONV_ERROR_STR(type, str, code) \
+ EXPECT_CONV_ERROR(to<type>(str), code, str)
+
+#define EXPECT_CONV_ERROR_STR_NOVAL(type, str, code) \
+ EXPECT_CONV_ERROR(to<type>(str), code, nullptr)
+
+TEST(Conv, ConversionErrorStrToBool) {
+ EXPECT_CONV_ERROR_STR_NOVAL(bool, StringPiece(), EMPTY_INPUT_STRING);
+ EXPECT_CONV_ERROR_STR_NOVAL(bool, "", EMPTY_INPUT_STRING);
+ EXPECT_CONV_ERROR_STR(bool, " ", EMPTY_INPUT_STRING);
+ EXPECT_CONV_ERROR_STR(bool, " 11 ", BOOL_OVERFLOW);
+ EXPECT_CONV_ERROR_STR(bool, "other ", BOOL_INVALID_VALUE);
+ EXPECT_CONV_ERROR_STR(bool, " bla", BOOL_INVALID_VALUE);
+ EXPECT_CONV_ERROR(to<bool>(" offbla"), NON_WHITESPACE_AFTER_END, "bla");
+}
+
+TEST(Conv, ConversionErrorStrToFloat) {
+ EXPECT_CONV_ERROR_STR_NOVAL(float, StringPiece(), EMPTY_INPUT_STRING);
+ EXPECT_CONV_ERROR_STR_NOVAL(float, "", EMPTY_INPUT_STRING);
+ EXPECT_CONV_ERROR_STR(float, " ", EMPTY_INPUT_STRING);
+ EXPECT_CONV_ERROR_STR(float, " junk", STRING_TO_FLOAT_ERROR);
+ EXPECT_CONV_ERROR(to<float>(" 1bla"), NON_WHITESPACE_AFTER_END, "bla");
+}
+
+TEST(Conv, ConversionErrorStrToInt) {
+ // empty string handling
+ EXPECT_CONV_ERROR_STR_NOVAL(int, StringPiece(), EMPTY_INPUT_STRING);
+ EXPECT_CONV_ERROR_STR_NOVAL(int, "", EMPTY_INPUT_STRING);
+ EXPECT_CONV_ERROR_STR(int, " ", EMPTY_INPUT_STRING);
+
+ // signed integers
+ EXPECT_CONV_ERROR_STR(int, " *", INVALID_LEADING_CHAR);
+ EXPECT_CONV_ERROR_STR(int, " +", NO_DIGITS);
+ EXPECT_CONV_ERROR_STR(int, " +*", NON_DIGIT_CHAR);
+ EXPECT_CONV_ERROR_STR(int8_t, " 128", POSITIVE_OVERFLOW);
+ EXPECT_CONV_ERROR_STR(int8_t, " -129", NEGATIVE_OVERFLOW);
+ EXPECT_CONV_ERROR_STR(int8_t, " 1000", POSITIVE_OVERFLOW);
+ EXPECT_CONV_ERROR_STR(int8_t, "-1000", NEGATIVE_OVERFLOW);
+ EXPECT_CONV_ERROR(to<int>(" -13bla"), NON_WHITESPACE_AFTER_END, "bla");
+
+ // unsigned integers
+ EXPECT_CONV_ERROR_STR(unsigned, " -", NON_DIGIT_CHAR);
+ EXPECT_CONV_ERROR_STR(uint8_t, " 256", POSITIVE_OVERFLOW);
+ EXPECT_CONV_ERROR(to<unsigned>("42bla"), NON_WHITESPACE_AFTER_END, "bla");
+}
+
+#define EXPECT_CONV_ERROR_PP_VAL(type, str, code, val) \
+ do { \
+ StringPiece input(str); \
+ EXPECT_CONV_ERROR(to<type>(input.begin(), input.end()), code, val); \
+ } while (0)
+
+#define EXPECT_CONV_ERROR_PP(type, str, code) \
+ EXPECT_CONV_ERROR_PP_VAL(type, str, code, str)
+
+TEST(Conv, ConversionErrorPtrPairToInt) {
+ // signed integers
+ EXPECT_CONV_ERROR_PP(int, "", INVALID_LEADING_CHAR);
+ EXPECT_CONV_ERROR_PP(int, " ", INVALID_LEADING_CHAR);
+ EXPECT_CONV_ERROR_PP(int, "*", INVALID_LEADING_CHAR);
+ EXPECT_CONV_ERROR_PP(int, "+", NO_DIGITS);
+ EXPECT_CONV_ERROR_PP(int8_t, "128", POSITIVE_OVERFLOW);
+ EXPECT_CONV_ERROR_PP(int8_t, "-129", NEGATIVE_OVERFLOW);
+ EXPECT_CONV_ERROR_PP(int8_t, "1000", POSITIVE_OVERFLOW);
+ EXPECT_CONV_ERROR_PP(int8_t, "-1000", NEGATIVE_OVERFLOW);
+ EXPECT_CONV_ERROR_PP(int, "-junk", NON_DIGIT_CHAR);
+
+ // unsigned integers
+ EXPECT_CONV_ERROR_PP(unsigned, "", NO_DIGITS);
+ EXPECT_CONV_ERROR_PP(uint8_t, "256", POSITIVE_OVERFLOW);
+ EXPECT_CONV_ERROR_PP(unsigned, "junk", NON_DIGIT_CHAR);
+}
+
+namespace {
+
+template <typename T, typename V>
+std::string prefixWithType(V value) {
+ std::ostringstream oss;
+#ifdef FOLLY_HAS_RTTI
+ oss << "(" << demangle(typeid(T)) << ") ";
+#endif
+ oss << to<std::string>(value);
+ return oss.str();
+}
+}
+
+#define EXPECT_CONV_ERROR_ARITH(type, val, code) \
+ EXPECT_CONV_ERROR_QUOTE( \
+ to<type>(val), code, prefixWithType<type>(val).c_str(), false)
+
+TEST(Conv, ConversionErrorIntToInt) {
+ EXPECT_CONV_ERROR_ARITH(signed char, 128, ARITH_POSITIVE_OVERFLOW);
+ EXPECT_CONV_ERROR_ARITH(unsigned char, -1, ARITH_NEGATIVE_OVERFLOW);
+}
+
+TEST(Conv, ConversionErrorFloatToFloat) {
+ EXPECT_CONV_ERROR_ARITH(
+ float, std::numeric_limits<double>::max(), ARITH_POSITIVE_OVERFLOW);
+ EXPECT_CONV_ERROR_ARITH(
+ float, std::numeric_limits<double>::lowest(), ARITH_NEGATIVE_OVERFLOW);
+}
+
+TEST(Conv, ConversionErrorIntToFloat) {
+ EXPECT_CONV_ERROR_ARITH(
+ float, std::numeric_limits<long long>::max(), ARITH_LOSS_OF_PRECISION);
+}
+
+TEST(Conv, ConversionErrorFloatToInt) {
+ EXPECT_CONV_ERROR_ARITH(int8_t, 65.5, ARITH_LOSS_OF_PRECISION);
+}
+
+TEST(Conv, TryStringToBool) {
+ auto rv1 = folly::tryTo<bool>("xxxx");
+ EXPECT_FALSE(rv1.hasValue());
+ auto rv2 = folly::tryTo<bool>("false");
+ EXPECT_TRUE(rv2.hasValue());
+ EXPECT_FALSE(rv2.value());
+ auto rv3 = folly::tryTo<bool>("yes");
+ EXPECT_TRUE(rv3.hasValue());
+ EXPECT_TRUE(rv3.value());
+}
+
+TEST(Conv, TryStringToInt) {
+ auto rv1 = folly::tryTo<int>("1000000000000000000000000000000");
+ EXPECT_FALSE(rv1.hasValue());
+ auto rv2 = folly::tryTo<int>("4711");
+ EXPECT_TRUE(rv2.hasValue());
+ EXPECT_EQ(rv2.value(), 4711);
+}
+
+TEST(Conv, TryStringToFloat) {
+ auto rv1 = folly::tryTo<float>("");
+ EXPECT_FALSE(rv1.hasValue());
+ auto rv2 = folly::tryTo<float>("3.14");
+ EXPECT_TRUE(rv2.hasValue());
+ EXPECT_NEAR(rv2.value(), 3.14, 1e-5);
+}
+
+TEST(Conv, TryStringToDouble) {
+ auto rv1 = folly::tryTo<double>("");
+ EXPECT_FALSE(rv1.hasValue());
+ auto rv2 = folly::tryTo<double>("3.14");
+ EXPECT_TRUE(rv2.hasValue());
+ EXPECT_NEAR(rv2.value(), 3.14, 1e-10);
+}
+
+TEST(Conv, TryIntToInt) {
+ auto rv1 = folly::tryTo<uint8_t>(256);
+ EXPECT_FALSE(rv1.hasValue());
+ auto rv2 = folly::tryTo<uint8_t>(255);
+ EXPECT_TRUE(rv2.hasValue());
+ EXPECT_EQ(rv2.value(), 255);
+}
+
+TEST(Conv, TryFloatToFloat) {
+ auto rv1 = folly::tryTo<float>(1e100);
+ EXPECT_FALSE(rv1.hasValue());
+ auto rv2 = folly::tryTo<double>(25.5f);
+ EXPECT_TRUE(rv2.hasValue());
+ EXPECT_NEAR(rv2.value(), 25.5, 1e-10);
+}
+
+TEST(Conv, TryFloatToInt) {
+ auto rv1 = folly::tryTo<int>(100.001);
+ EXPECT_FALSE(rv1.hasValue());
+ auto rv2 = folly::tryTo<int>(100.0);
+ EXPECT_TRUE(rv2.hasValue());
+ EXPECT_EQ(rv2.value(), 100);
+}
+
+TEST(Conv, TryIntToFloat) {
+ auto rv1 = folly::tryTo<float>(std::numeric_limits<uint64_t>::max());
+ EXPECT_FALSE(rv1.hasValue());
+ auto rv2 = folly::tryTo<float>(1000ULL);
+ EXPECT_TRUE(rv2.hasValue());
+ EXPECT_EQ(rv2.value(), 1000.0f);
+}
+
+TEST(Conv, TryPtrPairToInt) {
+ StringPiece sp1("1000000000000000000000000000000");
+ auto rv1 = folly::tryTo<int>(sp1.begin(), sp1.end());
+ EXPECT_FALSE(rv1.hasValue());
+ StringPiece sp2("4711");
+ auto rv2 = folly::tryTo<int>(sp2.begin(), sp2.end());
+ EXPECT_TRUE(rv2.hasValue());
+ EXPECT_EQ(rv2.value(), 4711);
+ StringPiece sp3("-4711");
+ auto rv3 = folly::tryTo<int>(sp3.begin(), sp3.end());
+ EXPECT_TRUE(rv3.hasValue());
+ EXPECT_EQ(rv3.value(), -4711);
+ StringPiece sp4("4711");
+ auto rv4 = folly::tryTo<uint16_t>(sp4.begin(), sp4.end());
+ EXPECT_TRUE(rv4.hasValue());
+ EXPECT_EQ(rv4.value(), 4711);
+}
+
TEST(Conv, NewUint64ToString) {
char buf[21];
toAppendDelimFit(",", str1, str2, &res3);
EXPECT_EQ(res3, str1 + "," + str2);
}
+
+namespace my {
+struct Dimensions {
+ int w, h;
+ std::tuple<const int&, const int&> tuple_view() const {
+ return tie(w, h);
+ }
+ bool operator==(const Dimensions& other) const {
+ return this->tuple_view() == other.tuple_view();
+ }
+};
+
+Expected<StringPiece, ConversionCode> parseTo(
+ folly::StringPiece in,
+ Dimensions& out) {
+ return parseTo(in, out.w)
+ .then([](StringPiece sp) { return sp.removePrefix("x"), sp; })
+ .then([&](StringPiece sp) { return parseTo(sp, out.h); });
+}
+
+template <class String>
+void toAppend(const Dimensions& in, String* result) {
+ folly::toAppend(in.w, 'x', in.h, result);
+}
+
+size_t estimateSpaceNeeded(const Dimensions&in) {
+ return 2000 + folly::estimateSpaceNeeded(in.w) +
+ folly::estimateSpaceNeeded(in.h);
+}
+}
+
+TEST(Conv, custom_kkproviders) {
+ my::Dimensions expected{7, 8};
+ EXPECT_EQ(expected, folly::to<my::Dimensions>("7x8"));
+ auto str = folly::to<std::string>(expected);
+ EXPECT_EQ("7x8", str);
+ // make sure above implementation of estimateSpaceNeeded() is used.
+ EXPECT_GT(str.capacity(), 2000);
+ EXPECT_LT(str.capacity(), 2500);
+}
+
+TEST(Conv, TryToThenWithVoid) {
+ auto x = tryTo<int>("42").then([](int) {});
+ EXPECT_TRUE(x.hasValue());
+ Unit u = x.value();
+ (void)u;
+}
projects / folly.git / blobdiff