Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs
[firefly-linux-kernel-4.4.55.git] / drivers / scsi / megaraid / megaraid_sas_base.c
index 71b884dae27c7e1413c0aa300b9ce1e30a556d83..eaa81e552fd26f715122da4ee5e38427bb4ddb72 100644 (file)
@@ -216,7 +216,7 @@ struct megasas_cmd *megasas_get_cmd(struct megasas_instance
                                 struct megasas_cmd, list);
                list_del_init(&cmd->list);
        } else {
-               printk(KERN_ERR "megasas: Command pool empty!\n");
+               dev_err(&instance->pdev->dev, "Command pool empty!\n");
        }
 
        spin_unlock_irqrestore(&instance->mfi_pool_lock, flags);
@@ -273,6 +273,7 @@ static inline void
 megasas_enable_intr_xscale(struct megasas_instance *instance)
 {
        struct megasas_register_set __iomem *regs;
+
        regs = instance->reg_set;
        writel(0, &(regs)->outbound_intr_mask);
 
@@ -289,6 +290,7 @@ megasas_disable_intr_xscale(struct megasas_instance *instance)
 {
        struct megasas_register_set __iomem *regs;
        u32 mask = 0x1f;
+
        regs = instance->reg_set;
        writel(mask, &regs->outbound_intr_mask);
        /* Dummy readl to force pci flush */
@@ -313,6 +315,7 @@ megasas_clear_intr_xscale(struct megasas_register_set __iomem * regs)
 {
        u32 status;
        u32 mfiStatus = 0;
+
        /*
         * Check if it is our interrupt
         */
@@ -348,6 +351,7 @@ megasas_fire_cmd_xscale(struct megasas_instance *instance,
                struct megasas_register_set __iomem *regs)
 {
        unsigned long flags;
+
        spin_lock_irqsave(&instance->hba_lock, flags);
        writel((frame_phys_addr >> 3)|(frame_count),
               &(regs)->inbound_queue_port);
@@ -364,15 +368,16 @@ megasas_adp_reset_xscale(struct megasas_instance *instance,
 {
        u32 i;
        u32 pcidata;
+
        writel(MFI_ADP_RESET, &regs->inbound_doorbell);
 
        for (i = 0; i < 3; i++)
                msleep(1000); /* sleep for 3 secs */
        pcidata  = 0;
        pci_read_config_dword(instance->pdev, MFI_1068_PCSR_OFFSET, &pcidata);
-       printk(KERN_NOTICE "pcidata = %x\n", pcidata);
+       dev_notice(&instance->pdev->dev, "pcidata = %x\n", pcidata);
        if (pcidata & 0x2) {
-               printk(KERN_NOTICE "mfi 1068 offset read=%x\n", pcidata);
+               dev_notice(&instance->pdev->dev, "mfi 1068 offset read=%x\n", pcidata);
                pcidata &= ~0x2;
                pci_write_config_dword(instance->pdev,
                                MFI_1068_PCSR_OFFSET, pcidata);
@@ -383,9 +388,9 @@ megasas_adp_reset_xscale(struct megasas_instance *instance,
                pcidata  = 0;
                pci_read_config_dword(instance->pdev,
                                MFI_1068_FW_HANDSHAKE_OFFSET, &pcidata);
-               printk(KERN_NOTICE "1068 offset handshake read=%x\n", pcidata);
+               dev_notice(&instance->pdev->dev, "1068 offset handshake read=%x\n", pcidata);
                if ((pcidata & 0xffff0000) == MFI_1068_FW_READY) {
-                       printk(KERN_NOTICE "1068 offset pcidt=%x\n", pcidata);
+                       dev_notice(&instance->pdev->dev, "1068 offset pcidt=%x\n", pcidata);
                        pcidata = 0;
                        pci_write_config_dword(instance->pdev,
                                MFI_1068_FW_HANDSHAKE_OFFSET, pcidata);
@@ -402,7 +407,6 @@ static int
 megasas_check_reset_xscale(struct megasas_instance *instance,
                struct megasas_register_set __iomem *regs)
 {
-
        if ((instance->adprecovery != MEGASAS_HBA_OPERATIONAL) &&
            (le32_to_cpu(*instance->consumer) ==
                MEGASAS_ADPRESET_INPROG_SIGN))
@@ -433,7 +437,7 @@ static struct megasas_instance_template megasas_instance_template_xscale = {
 
 /**
 *      The following functions are defined for ppc (deviceid : 0x60)
-*      controllers
+*      controllers
 */
 
 /**
@@ -444,6 +448,7 @@ static inline void
 megasas_enable_intr_ppc(struct megasas_instance *instance)
 {
        struct megasas_register_set __iomem *regs;
+
        regs = instance->reg_set;
        writel(0xFFFFFFFF, &(regs)->outbound_doorbell_clear);
 
@@ -462,6 +467,7 @@ megasas_disable_intr_ppc(struct megasas_instance *instance)
 {
        struct megasas_register_set __iomem *regs;
        u32 mask = 0xFFFFFFFF;
+
        regs = instance->reg_set;
        writel(mask, &regs->outbound_intr_mask);
        /* Dummy readl to force pci flush */
@@ -522,6 +528,7 @@ megasas_fire_cmd_ppc(struct megasas_instance *instance,
                struct megasas_register_set __iomem *regs)
 {
        unsigned long flags;
+
        spin_lock_irqsave(&instance->hba_lock, flags);
        writel((frame_phys_addr | (frame_count<<1))|1,
                        &(regs)->inbound_queue_port);
@@ -566,6 +573,7 @@ static inline void
 megasas_enable_intr_skinny(struct megasas_instance *instance)
 {
        struct megasas_register_set __iomem *regs;
+
        regs = instance->reg_set;
        writel(0xFFFFFFFF, &(regs)->outbound_intr_mask);
 
@@ -584,6 +592,7 @@ megasas_disable_intr_skinny(struct megasas_instance *instance)
 {
        struct megasas_register_set __iomem *regs;
        u32 mask = 0xFFFFFFFF;
+
        regs = instance->reg_set;
        writel(mask, &regs->outbound_intr_mask);
        /* Dummy readl to force pci flush */
@@ -634,8 +643,8 @@ megasas_clear_intr_skinny(struct megasas_register_set __iomem *regs)
        writel(status, &regs->outbound_intr_status);
 
        /*
-       * dummy read to flush PCI
-       */
+        * dummy read to flush PCI
+        */
        readl(&regs->outbound_intr_status);
 
        return mfiStatus;
@@ -654,6 +663,7 @@ megasas_fire_cmd_skinny(struct megasas_instance *instance,
                        struct megasas_register_set __iomem *regs)
 {
        unsigned long flags;
+
        spin_lock_irqsave(&instance->hba_lock, flags);
        writel(upper_32_bits(frame_phys_addr),
               &(regs)->inbound_high_queue_port);
@@ -706,6 +716,7 @@ static inline void
 megasas_enable_intr_gen2(struct megasas_instance *instance)
 {
        struct megasas_register_set __iomem *regs;
+
        regs = instance->reg_set;
        writel(0xFFFFFFFF, &(regs)->outbound_doorbell_clear);
 
@@ -725,6 +736,7 @@ megasas_disable_intr_gen2(struct megasas_instance *instance)
 {
        struct megasas_register_set __iomem *regs;
        u32 mask = 0xFFFFFFFF;
+
        regs = instance->reg_set;
        writel(mask, &regs->outbound_intr_mask);
        /* Dummy readl to force pci flush */
@@ -750,6 +762,7 @@ megasas_clear_intr_gen2(struct megasas_register_set __iomem *regs)
 {
        u32 status;
        u32 mfiStatus = 0;
+
        /*
         * Check if it is our interrupt
         */
@@ -786,6 +799,7 @@ megasas_fire_cmd_gen2(struct megasas_instance *instance,
                        struct megasas_register_set __iomem *regs)
 {
        unsigned long flags;
+
        spin_lock_irqsave(&instance->hba_lock, flags);
        writel((frame_phys_addr | (frame_count<<1))|1,
                        &(regs)->inbound_queue_port);
@@ -800,10 +814,10 @@ static int
 megasas_adp_reset_gen2(struct megasas_instance *instance,
                        struct megasas_register_set __iomem *reg_set)
 {
-       u32                     retry = 0 ;
-       u32                     HostDiag;
-       u32 __iomem             *seq_offset = &reg_set->seq_offset;
-       u32 __iomem             *hostdiag_offset = &reg_set->host_diag;
+       u32 retry = 0 ;
+       u32 HostDiag;
+       u32 __iomem *seq_offset = &reg_set->seq_offset;
+       u32 __iomem *hostdiag_offset = &reg_set->host_diag;
 
        if (instance->instancet == &megasas_instance_template_skinny) {
                seq_offset = &reg_set->fusion_seq_offset;
@@ -821,10 +835,10 @@ megasas_adp_reset_gen2(struct megasas_instance *instance,
 
        HostDiag = (u32)readl(hostdiag_offset);
 
-       while ( !( HostDiag & DIAG_WRITE_ENABLE) ) {
+       while (!(HostDiag & DIAG_WRITE_ENABLE)) {
                msleep(100);
                HostDiag = (u32)readl(hostdiag_offset);
-               printk(KERN_NOTICE "RESETGEN2: retry=%x, hostdiag=%x\n",
+               dev_notice(&instance->pdev->dev, "RESETGEN2: retry=%x, hostdiag=%x\n",
                                        retry, HostDiag);
 
                if (retry++ >= 100)
@@ -832,17 +846,17 @@ megasas_adp_reset_gen2(struct megasas_instance *instance,
 
        }
 
-       printk(KERN_NOTICE "ADP_RESET_GEN2: HostDiag=%x\n", HostDiag);
+       dev_notice(&instance->pdev->dev, "ADP_RESET_GEN2: HostDiag=%x\n", HostDiag);
 
        writel((HostDiag | DIAG_RESET_ADAPTER), hostdiag_offset);
 
        ssleep(10);
 
        HostDiag = (u32)readl(hostdiag_offset);
-       while ( ( HostDiag & DIAG_RESET_ADAPTER) ) {
+       while (HostDiag & DIAG_RESET_ADAPTER) {
                msleep(100);
                HostDiag = (u32)readl(hostdiag_offset);
-               printk(KERN_NOTICE "RESET_GEN2: retry=%x, hostdiag=%x\n",
+               dev_notice(&instance->pdev->dev, "RESET_GEN2: retry=%x, hostdiag=%x\n",
                                retry, HostDiag);
 
                if (retry++ >= 1000)
@@ -904,7 +918,6 @@ int
 megasas_issue_polled(struct megasas_instance *instance, struct megasas_cmd *cmd)
 {
        int seconds;
-
        struct megasas_header *frame_hdr = &cmd->frame->hdr;
 
        frame_hdr->cmd_status = MFI_CMD_STATUS_POLL_MODE;
@@ -940,6 +953,7 @@ megasas_issue_blocked_cmd(struct megasas_instance *instance,
                          struct megasas_cmd *cmd, int timeout)
 {
        int ret = 0;
+
        cmd->cmd_status_drv = MFI_STAT_INVALID_STATUS;
 
        instance->instancet->issue_dcmd(instance, cmd);
@@ -1120,7 +1134,7 @@ static u32 megasas_get_frame_count(struct megasas_instance *instance,
        int num_cnt;
        int sge_bytes;
        u32 sge_sz;
-       u32 frame_count=0;
+       u32 frame_count = 0;
 
        sge_sz = (IS_DMA64) ? sizeof(struct megasas_sge64) :
            sizeof(struct megasas_sge32);
@@ -1151,14 +1165,14 @@ static u32 megasas_get_frame_count(struct megasas_instance *instance,
                        num_cnt = sge_count - 3;
        }
 
-       if(num_cnt>0){
+       if (num_cnt > 0) {
                sge_bytes = sge_sz * num_cnt;
 
                frame_count = (sge_bytes / MEGAMFI_FRAME_SIZE) +
                    ((sge_bytes % MEGAMFI_FRAME_SIZE) ? 1 : 0) ;
        }
        /* Main frame */
-       frame_count +=1;
+       frame_count += 1;
 
        if (frame_count > 7)
                frame_count = 8;
@@ -1215,9 +1229,9 @@ megasas_build_dcdb(struct megasas_instance *instance, struct scsi_cmnd *scp,
        memcpy(pthru->cdb, scp->cmnd, scp->cmd_len);
 
        /*
-       * If the command is for the tape device, set the
-       * pthru timeout to the os layer timeout value.
-       */
+        * If the command is for the tape device, set the
+        * pthru timeout to the os layer timeout value.
+        */
        if (scp->device->type == TYPE_TAPE) {
                if ((scp->request->timeout / HZ) > 0xFFFF)
                        pthru->timeout = cpu_to_le16(0xFFFF);
@@ -1241,7 +1255,7 @@ megasas_build_dcdb(struct megasas_instance *instance, struct scsi_cmnd *scp,
                                                      &pthru->sgl);
 
        if (pthru->sge_count > instance->max_num_sge) {
-               printk(KERN_ERR "megasas: DCDB two many SGE NUM=%x\n",
+               dev_err(&instance->pdev->dev, "DCDB too many SGE NUM=%x\n",
                        pthru->sge_count);
                return 0;
        }
@@ -1382,7 +1396,7 @@ megasas_build_ldio(struct megasas_instance *instance, struct scsi_cmnd *scp,
                ldio->sge_count = megasas_make_sgl32(instance, scp, &ldio->sgl);
 
        if (ldio->sge_count > instance->max_num_sge) {
-               printk(KERN_ERR "megasas: build_ld_io: sge_count = %x\n",
+               dev_err(&instance->pdev->dev, "build_ld_io: sge_count = %x\n",
                        ldio->sge_count);
                return 0;
        }
@@ -1435,7 +1449,7 @@ inline int megasas_cmd_type(struct scsi_cmnd *cmd)
 
  /**
  * megasas_dump_pending_frames -       Dumps the frame address of all pending cmds
- *                                     in FW
+ *                                     in FW
  * @instance:                          Adapter soft state
  */
 static inline void
@@ -1449,63 +1463,60 @@ megasas_dump_pending_frames(struct megasas_instance *instance)
        u32 sgcount;
        u32 max_cmd = instance->max_fw_cmds;
 
-       printk(KERN_ERR "\nmegasas[%d]: Dumping Frame Phys Address of all pending cmds in FW\n",instance->host->host_no);
-       printk(KERN_ERR "megasas[%d]: Total OS Pending cmds : %d\n",instance->host->host_no,atomic_read(&instance->fw_outstanding));
+       dev_err(&instance->pdev->dev, "[%d]: Dumping Frame Phys Address of all pending cmds in FW\n",instance->host->host_no);
+       dev_err(&instance->pdev->dev, "[%d]: Total OS Pending cmds : %d\n",instance->host->host_no,atomic_read(&instance->fw_outstanding));
        if (IS_DMA64)
-               printk(KERN_ERR "\nmegasas[%d]: 64 bit SGLs were sent to FW\n",instance->host->host_no);
+               dev_err(&instance->pdev->dev, "[%d]: 64 bit SGLs were sent to FW\n",instance->host->host_no);
        else
-               printk(KERN_ERR "\nmegasas[%d]: 32 bit SGLs were sent to FW\n",instance->host->host_no);
+               dev_err(&instance->pdev->dev, "[%d]: 32 bit SGLs were sent to FW\n",instance->host->host_no);
 
-       printk(KERN_ERR "megasas[%d]: Pending OS cmds in FW : \n",instance->host->host_no);
+       dev_err(&instance->pdev->dev, "[%d]: Pending OS cmds in FW : \n",instance->host->host_no);
        for (i = 0; i < max_cmd; i++) {
                cmd = instance->cmd_list[i];
-               if(!cmd->scmd)
+               if (!cmd->scmd)
                        continue;
-               printk(KERN_ERR "megasas[%d]: Frame addr :0x%08lx : ",instance->host->host_no,(unsigned long)cmd->frame_phys_addr);
+               dev_err(&instance->pdev->dev, "[%d]: Frame addr :0x%08lx : ",instance->host->host_no,(unsigned long)cmd->frame_phys_addr);
                if (megasas_cmd_type(cmd->scmd) == READ_WRITE_LDIO) {
                        ldio = (struct megasas_io_frame *)cmd->frame;
                        mfi_sgl = &ldio->sgl;
                        sgcount = ldio->sge_count;
-                       printk(KERN_ERR "megasas[%d]: frame count : 0x%x, Cmd : 0x%x, Tgt id : 0x%x,"
+                       dev_err(&instance->pdev->dev, "[%d]: frame count : 0x%x, Cmd : 0x%x, Tgt id : 0x%x,"
                        " lba lo : 0x%x, lba_hi : 0x%x, sense_buf addr : 0x%x,sge count : 0x%x\n",
                        instance->host->host_no, cmd->frame_count, ldio->cmd, ldio->target_id,
                        le32_to_cpu(ldio->start_lba_lo), le32_to_cpu(ldio->start_lba_hi),
                        le32_to_cpu(ldio->sense_buf_phys_addr_lo), sgcount);
-               }
-               else {
+               } else {
                        pthru = (struct megasas_pthru_frame *) cmd->frame;
                        mfi_sgl = &pthru->sgl;
                        sgcount = pthru->sge_count;
-                       printk(KERN_ERR "megasas[%d]: frame count : 0x%x, Cmd : 0x%x, Tgt id : 0x%x, "
+                       dev_err(&instance->pdev->dev, "[%d]: frame count : 0x%x, Cmd : 0x%x, Tgt id : 0x%x, "
                        "lun : 0x%x, cdb_len : 0x%x, data xfer len : 0x%x, sense_buf addr : 0x%x,sge count : 0x%x\n",
                        instance->host->host_no, cmd->frame_count, pthru->cmd, pthru->target_id,
                        pthru->lun, pthru->cdb_len, le32_to_cpu(pthru->data_xfer_len),
                        le32_to_cpu(pthru->sense_buf_phys_addr_lo), sgcount);
                }
-       if(megasas_dbg_lvl & MEGASAS_DBG_LVL){
-               for (n = 0; n < sgcount; n++){
-                       if (IS_DMA64)
-                               printk(KERN_ERR "megasas: sgl len : 0x%x, sgl addr : 0x%llx ",
-                                       le32_to_cpu(mfi_sgl->sge64[n].length),
-                                       le64_to_cpu(mfi_sgl->sge64[n].phys_addr));
-                       else
-                               printk(KERN_ERR "megasas: sgl len : 0x%x, sgl addr : 0x%x ",
-                                       le32_to_cpu(mfi_sgl->sge32[n].length),
-                                       le32_to_cpu(mfi_sgl->sge32[n].phys_addr));
+               if (megasas_dbg_lvl & MEGASAS_DBG_LVL) {
+                       for (n = 0; n < sgcount; n++) {
+                               if (IS_DMA64)
+                                       dev_err(&instance->pdev->dev, "sgl len : 0x%x, sgl addr : 0x%llx\n",
+                                               le32_to_cpu(mfi_sgl->sge64[n].length),
+                                               le64_to_cpu(mfi_sgl->sge64[n].phys_addr));
+                               else
+                                       dev_err(&instance->pdev->dev, "sgl len : 0x%x, sgl addr : 0x%x\n",
+                                               le32_to_cpu(mfi_sgl->sge32[n].length),
+                                               le32_to_cpu(mfi_sgl->sge32[n].phys_addr));
                        }
                }
-               printk(KERN_ERR "\n");
        } /*for max_cmd*/
-       printk(KERN_ERR "\nmegasas[%d]: Pending Internal cmds in FW : \n",instance->host->host_no);
+       dev_err(&instance->pdev->dev, "[%d]: Pending Internal cmds in FW : \n",instance->host->host_no);
        for (i = 0; i < max_cmd; i++) {
 
                cmd = instance->cmd_list[i];
 
-               if(cmd->sync_cmd == 1){
-                       printk(KERN_ERR "0x%08lx : ", (unsigned long)cmd->frame_phys_addr);
-               }
+               if (cmd->sync_cmd == 1)
+                       dev_err(&instance->pdev->dev, "0x%08lx : ", (unsigned long)cmd->frame_phys_addr);
        }
-       printk(KERN_ERR "megasas[%d]: Dumping Done.\n\n",instance->host->host_no);
+       dev_err(&instance->pdev->dev, "[%d]: Dumping Done\n\n",instance->host->host_no);
 }
 
 u32
@@ -1623,7 +1634,7 @@ megasas_queue_command(struct Scsi_Host *shost, struct scsi_cmnd *scmd)
        }
 
        if (instance->instancet->build_and_issue_cmd(instance, scmd)) {
-               printk(KERN_ERR "megasas: Err returned from build_and_issue_cmd\n");
+               dev_err(&instance->pdev->dev, "Err returned from build_and_issue_cmd\n");
                return SCSI_MLQUEUE_HOST_BUSY;
        }
 
@@ -1651,8 +1662,8 @@ static struct megasas_instance *megasas_lookup_instance(u16 host_no)
 static int megasas_slave_configure(struct scsi_device *sdev)
 {
        /*
-       * The RAID firmware may require extended timeouts.
-       */
+        * The RAID firmware may require extended timeouts.
+        */
        blk_queue_rq_timeout(sdev->request_queue,
                MEGASAS_DEFAULT_CMD_TIMEOUT * HZ);
 
@@ -1661,8 +1672,9 @@ static int megasas_slave_configure(struct scsi_device *sdev)
 
 static int megasas_slave_alloc(struct scsi_device *sdev)
 {
-       u16             pd_index = 0;
+       u16 pd_index = 0;
        struct megasas_instance *instance ;
+
        instance = megasas_lookup_instance(sdev->host->host_no);
        if (sdev->channel < MEGASAS_MAX_PD_CHANNELS) {
                /*
@@ -1728,8 +1740,7 @@ void megaraid_sas_kill_hba(struct megasas_instance *instance)
                (instance->pdev->device == PCI_DEVICE_ID_LSI_PLASMA) ||
                (instance->pdev->device == PCI_DEVICE_ID_LSI_INVADER) ||
                (instance->pdev->device == PCI_DEVICE_ID_LSI_FURY)) {
-               writel(MFI_STOP_ADP,
-                       &instance->reg_set->doorbell);
+               writel(MFI_STOP_ADP, &instance->reg_set->doorbell);
                /* Flush */
                readl(&instance->reg_set->doorbell);
                if (instance->mpio && instance->requestorId)
@@ -1783,7 +1794,7 @@ static void megasas_complete_cmd_dpc(unsigned long instance_addr)
        unsigned long flags;
 
        /* If we have already declared adapter dead, donot complete cmds */
-       if (instance->adprecovery == MEGASAS_HW_CRITICAL_ERROR )
+       if (instance->adprecovery == MEGASAS_HW_CRITICAL_ERROR)
                return;
 
        spin_lock_irqsave(&instance->completion_lock, flags);
@@ -1794,7 +1805,7 @@ static void megasas_complete_cmd_dpc(unsigned long instance_addr)
        while (consumer != producer) {
                context = le32_to_cpu(instance->reply_queue[consumer]);
                if (context >= instance->max_fw_cmds) {
-                       printk(KERN_ERR "Unexpected context value %x\n",
+                       dev_err(&instance->pdev->dev, "Unexpected context value %x\n",
                                context);
                        BUG();
                }
@@ -1873,8 +1884,8 @@ static int megasas_get_ld_vf_affiliation_111(struct megasas_instance *instance,
        cmd = megasas_get_cmd(instance);
 
        if (!cmd) {
-               printk(KERN_DEBUG "megasas: megasas_get_ld_vf_affiliation_111:"
-                      "Failed to get cmd for scsi%d.\n",
+               dev_printk(KERN_DEBUG, &instance->pdev->dev, "megasas_get_ld_vf_affiliation_111:"
+                      "Failed to get cmd for scsi%d\n",
                        instance->host->host_no);
                return -ENOMEM;
        }
@@ -1882,8 +1893,8 @@ static int megasas_get_ld_vf_affiliation_111(struct megasas_instance *instance,
        dcmd = &cmd->frame->dcmd;
 
        if (!instance->vf_affiliation_111) {
-               printk(KERN_WARNING "megasas: SR-IOV: Couldn't get LD/VF "
-                      "affiliation for scsi%d.\n", instance->host->host_no);
+               dev_warn(&instance->pdev->dev, "SR-IOV: Couldn't get LD/VF "
+                      "affiliation for scsi%d\n", instance->host->host_no);
                megasas_return_cmd(instance, cmd);
                return -ENOMEM;
        }
@@ -1897,8 +1908,8 @@ static int megasas_get_ld_vf_affiliation_111(struct megasas_instance *instance,
                                             sizeof(struct MR_LD_VF_AFFILIATION_111),
                                             &new_affiliation_111_h);
                if (!new_affiliation_111) {
-                       printk(KERN_DEBUG "megasas: SR-IOV: Couldn't allocate "
-                              "memory for new affiliation for scsi%d.\n",
+                       dev_printk(KERN_DEBUG, &instance->pdev->dev, "SR-IOV: Couldn't allocate "
+                              "memory for new affiliation for scsi%d\n",
                               instance->host->host_no);
                        megasas_return_cmd(instance, cmd);
                        return -ENOMEM;
@@ -1929,14 +1940,14 @@ static int megasas_get_ld_vf_affiliation_111(struct megasas_instance *instance,
        dcmd->sgl.sge32[0].length = cpu_to_le32(
                sizeof(struct MR_LD_VF_AFFILIATION_111));
 
-       printk(KERN_WARNING "megasas: SR-IOV: Getting LD/VF affiliation for "
+       dev_warn(&instance->pdev->dev, "SR-IOV: Getting LD/VF affiliation for "
               "scsi%d\n", instance->host->host_no);
 
        megasas_issue_blocked_cmd(instance, cmd, 0);
 
        if (dcmd->cmd_status) {
-               printk(KERN_WARNING "megasas: SR-IOV: LD/VF affiliation DCMD"
-                      " failed with status 0x%x for scsi%d.\n",
+               dev_warn(&instance->pdev->dev, "SR-IOV: LD/VF affiliation DCMD"
+                      " failed with status 0x%x for scsi%d\n",
                       dcmd->cmd_status, instance->host->host_no);
                retval = 1; /* Do a scan if we couldn't get affiliation */
                goto out;
@@ -1947,9 +1958,8 @@ static int megasas_get_ld_vf_affiliation_111(struct megasas_instance *instance,
                for (ld = 0 ; ld < new_affiliation_111->vdCount; ld++)
                        if (instance->vf_affiliation_111->map[ld].policy[thisVf] !=
                            new_affiliation_111->map[ld].policy[thisVf]) {
-                               printk(KERN_WARNING "megasas: SR-IOV: "
-                                      "Got new LD/VF affiliation "
-                                      "for scsi%d.\n",
+                               dev_warn(&instance->pdev->dev, "SR-IOV: "
+                                      "Got new LD/VF affiliation for scsi%d\n",
                                       instance->host->host_no);
                                memcpy(instance->vf_affiliation_111,
                                       new_affiliation_111,
@@ -1985,8 +1995,8 @@ static int megasas_get_ld_vf_affiliation_12(struct megasas_instance *instance,
        cmd = megasas_get_cmd(instance);
 
        if (!cmd) {
-               printk(KERN_DEBUG "megasas: megasas_get_ld_vf_affiliation12: "
-                      "Failed to get cmd for scsi%d.\n",
+               dev_printk(KERN_DEBUG, &instance->pdev->dev, "megasas_get_ld_vf_affiliation12: "
+                      "Failed to get cmd for scsi%d\n",
                       instance->host->host_no);
                return -ENOMEM;
        }
@@ -1994,8 +2004,8 @@ static int megasas_get_ld_vf_affiliation_12(struct megasas_instance *instance,
        dcmd = &cmd->frame->dcmd;
 
        if (!instance->vf_affiliation) {
-               printk(KERN_WARNING "megasas: SR-IOV: Couldn't get LD/VF "
-                      "affiliation for scsi%d.\n", instance->host->host_no);
+               dev_warn(&instance->pdev->dev, "SR-IOV: Couldn't get LD/VF "
+                      "affiliation for scsi%d\n", instance->host->host_no);
                megasas_return_cmd(instance, cmd);
                return -ENOMEM;
        }
@@ -2010,8 +2020,8 @@ static int megasas_get_ld_vf_affiliation_12(struct megasas_instance *instance,
                                             sizeof(struct MR_LD_VF_AFFILIATION),
                                             &new_affiliation_h);
                if (!new_affiliation) {
-                       printk(KERN_DEBUG "megasas: SR-IOV: Couldn't allocate "
-                              "memory for new affiliation for scsi%d.\n",
+                       dev_printk(KERN_DEBUG, &instance->pdev->dev, "SR-IOV: Couldn't allocate "
+                              "memory for new affiliation for scsi%d\n",
                               instance->host->host_no);
                        megasas_return_cmd(instance, cmd);
                        return -ENOMEM;
@@ -2042,14 +2052,14 @@ static int megasas_get_ld_vf_affiliation_12(struct megasas_instance *instance,
        dcmd->sgl.sge32[0].length = cpu_to_le32((MAX_LOGICAL_DRIVES + 1) *
                sizeof(struct MR_LD_VF_AFFILIATION));
 
-       printk(KERN_WARNING "megasas: SR-IOV: Getting LD/VF affiliation for "
+       dev_warn(&instance->pdev->dev, "SR-IOV: Getting LD/VF affiliation for "
               "scsi%d\n", instance->host->host_no);
 
        megasas_issue_blocked_cmd(instance, cmd, 0);
 
        if (dcmd->cmd_status) {
-               printk(KERN_WARNING "megasas: SR-IOV: LD/VF affiliation DCMD"
-                      " failed with status 0x%x for scsi%d.\n",
+               dev_warn(&instance->pdev->dev, "SR-IOV: LD/VF affiliation DCMD"
+                      " failed with status 0x%x for scsi%d\n",
                       dcmd->cmd_status, instance->host->host_no);
                retval = 1; /* Do a scan if we couldn't get affiliation */
                goto out;
@@ -2057,8 +2067,8 @@ static int megasas_get_ld_vf_affiliation_12(struct megasas_instance *instance,
 
        if (!initial) {
                if (!new_affiliation->ldCount) {
-                       printk(KERN_WARNING "megasas: SR-IOV: Got new LD/VF "
-                              "affiliation for passive path for scsi%d.\n",
+                       dev_warn(&instance->pdev->dev, "SR-IOV: Got new LD/VF "
+                              "affiliation for passive path for scsi%d\n",
                               instance->host->host_no);
                        retval = 1;
                        goto out;
@@ -2123,8 +2133,8 @@ static int megasas_get_ld_vf_affiliation_12(struct megasas_instance *instance,
        }
 out:
        if (doscan) {
-               printk(KERN_WARNING "megasas: SR-IOV: Got new LD/VF "
-                      "affiliation for scsi%d.\n", instance->host->host_no);
+               dev_warn(&instance->pdev->dev, "SR-IOV: Got new LD/VF "
+                      "affiliation for scsi%d\n", instance->host->host_no);
                memcpy(instance->vf_affiliation, new_affiliation,
                       new_affiliation->size);
                retval = 1;
@@ -2164,8 +2174,8 @@ int megasas_sriov_start_heartbeat(struct megasas_instance *instance,
        cmd = megasas_get_cmd(instance);
 
        if (!cmd) {
-               printk(KERN_DEBUG "megasas: megasas_sriov_start_heartbeat: "
-                      "Failed to get cmd for scsi%d.\n",
+               dev_printk(KERN_DEBUG, &instance->pdev->dev, "megasas_sriov_start_heartbeat: "
+                      "Failed to get cmd for scsi%d\n",
                       instance->host->host_no);
                return -ENOMEM;
        }
@@ -2178,9 +2188,9 @@ int megasas_sriov_start_heartbeat(struct megasas_instance *instance,
                                              sizeof(struct MR_CTRL_HB_HOST_MEM),
                                              &instance->hb_host_mem_h);
                if (!instance->hb_host_mem) {
-                       printk(KERN_DEBUG "megasas: SR-IOV: Couldn't allocate"
-                              " memory for heartbeat host memory for "
-                              "scsi%d.\n", instance->host->host_no);
+                       dev_printk(KERN_DEBUG, &instance->pdev->dev, "SR-IOV: Couldn't allocate"
+                              " memory for heartbeat host memory for scsi%d\n",
+                              instance->host->host_no);
                        retval = -ENOMEM;
                        goto out;
                }
@@ -2200,7 +2210,7 @@ int megasas_sriov_start_heartbeat(struct megasas_instance *instance,
        dcmd->sgl.sge32[0].phys_addr = cpu_to_le32(instance->hb_host_mem_h);
        dcmd->sgl.sge32[0].length = cpu_to_le32(sizeof(struct MR_CTRL_HB_HOST_MEM));
 
-       printk(KERN_WARNING "megasas: SR-IOV: Starting heartbeat for scsi%d\n",
+       dev_warn(&instance->pdev->dev, "SR-IOV: Starting heartbeat for scsi%d\n",
               instance->host->host_no);
 
        if (instance->ctrl_context && !instance->mask_interrupts)
@@ -2236,7 +2246,7 @@ void megasas_sriov_heartbeat_handler(unsigned long instance_addr)
                mod_timer(&instance->sriov_heartbeat_timer,
                          jiffies + MEGASAS_SRIOV_HEARTBEAT_INTERVAL_VF);
        } else {
-               printk(KERN_WARNING "megasas: SR-IOV: Heartbeat never "
+               dev_warn(&instance->pdev->dev, "SR-IOV: Heartbeat never "
                       "completed for scsi%d\n", instance->host->host_no);
                schedule_work(&instance->work_init);
        }
@@ -2274,7 +2284,7 @@ static int megasas_wait_for_outstanding(struct megasas_instance *instance)
                                &clist_local);
                spin_unlock_irqrestore(&instance->hba_lock, flags);
 
-               printk(KERN_NOTICE "megasas: HBA reset wait ...\n");
+               dev_notice(&instance->pdev->dev, "HBA reset wait ...\n");
                for (i = 0; i < wait_time; i++) {
                        msleep(1000);
                        spin_lock_irqsave(&instance->hba_lock, flags);
@@ -2285,28 +2295,28 @@ static int megasas_wait_for_outstanding(struct megasas_instance *instance)
                }
 
                if (adprecovery != MEGASAS_HBA_OPERATIONAL) {
-                       printk(KERN_NOTICE "megasas: reset: Stopping HBA.\n");
+                       dev_notice(&instance->pdev->dev, "reset: Stopping HBA.\n");
                        spin_lock_irqsave(&instance->hba_lock, flags);
-                       instance->adprecovery   = MEGASAS_HW_CRITICAL_ERROR;
+                       instance->adprecovery = MEGASAS_HW_CRITICAL_ERROR;
                        spin_unlock_irqrestore(&instance->hba_lock, flags);
                        return FAILED;
                }
 
-               reset_index     = 0;
+               reset_index = 0;
                while (!list_empty(&clist_local)) {
-                       reset_cmd       = list_entry((&clist_local)->next,
+                       reset_cmd = list_entry((&clist_local)->next,
                                                struct megasas_cmd, list);
                        list_del_init(&reset_cmd->list);
                        if (reset_cmd->scmd) {
                                reset_cmd->scmd->result = DID_RESET << 16;
-                               printk(KERN_NOTICE "%d:%p reset [%02x]\n",
+                               dev_notice(&instance->pdev->dev, "%d:%p reset [%02x]\n",
                                        reset_index, reset_cmd,
                                        reset_cmd->scmd->cmnd[0]);
 
                                reset_cmd->scmd->scsi_done(reset_cmd->scmd);
                                megasas_return_cmd(instance, reset_cmd);
                        } else if (reset_cmd->sync_cmd) {
-                               printk(KERN_NOTICE "megasas:%p synch cmds"
+                               dev_notice(&instance->pdev->dev, "%p synch cmds"
                                                "reset queue\n",
                                                reset_cmd);
 
@@ -2315,7 +2325,7 @@ static int megasas_wait_for_outstanding(struct megasas_instance *instance)
                                                reset_cmd->frame_phys_addr,
                                                0, instance->reg_set);
                        } else {
-                               printk(KERN_NOTICE "megasas: %p unexpected"
+                               dev_notice(&instance->pdev->dev, "%p unexpected"
                                        "cmds lst\n",
                                        reset_cmd);
                        }
@@ -2326,14 +2336,13 @@ static int megasas_wait_for_outstanding(struct megasas_instance *instance)
        }
 
        for (i = 0; i < resetwaittime; i++) {
-
                int outstanding = atomic_read(&instance->fw_outstanding);
 
                if (!outstanding)
                        break;
 
                if (!(i % MEGASAS_RESET_NOTICE_INTERVAL)) {
-                       printk(KERN_NOTICE "megasas: [%2d]waiting for %d "
+                       dev_notice(&instance->pdev->dev, "[%2d]waiting for %d "
                               "commands to complete\n",i,outstanding);
                        /*
                         * Call cmd completion routine. Cmd to be
@@ -2365,10 +2374,8 @@ static int megasas_wait_for_outstanding(struct megasas_instance *instance)
                i++;
        } while (i <= 3);
 
-       if (atomic_read(&instance->fw_outstanding) &&
-                                       !kill_adapter_flag) {
+       if (atomic_read(&instance->fw_outstanding) && !kill_adapter_flag) {
                if (instance->disableOnlineCtrlReset == 0) {
-
                        megasas_do_ocr(instance);
 
                        /* wait for 5 secs to let FW finish the pending cmds */
@@ -2384,11 +2391,11 @@ static int megasas_wait_for_outstanding(struct megasas_instance *instance)
 
        if (atomic_read(&instance->fw_outstanding) ||
                                        (kill_adapter_flag == 2)) {
-               printk(KERN_NOTICE "megaraid_sas: pending cmds after reset\n");
+               dev_notice(&instance->pdev->dev, "pending cmds after reset\n");
                /*
-               * Send signal to FW to stop processing any pending cmds.
-               * The controller will be taken offline by the OS now.
-               */
+                * Send signal to FW to stop processing any pending cmds.
+                * The controller will be taken offline by the OS now.
+                */
                if ((instance->pdev->device ==
                        PCI_DEVICE_ID_LSI_SAS0073SKINNY) ||
                        (instance->pdev->device ==
@@ -2401,12 +2408,12 @@ static int megasas_wait_for_outstanding(struct megasas_instance *instance)
                }
                megasas_dump_pending_frames(instance);
                spin_lock_irqsave(&instance->hba_lock, flags);
-               instance->adprecovery   = MEGASAS_HW_CRITICAL_ERROR;
+               instance->adprecovery = MEGASAS_HW_CRITICAL_ERROR;
                spin_unlock_irqrestore(&instance->hba_lock, flags);
                return FAILED;
        }
 
-       printk(KERN_NOTICE "megaraid_sas: no pending cmds after reset\n");
+       dev_notice(&instance->pdev->dev, "no pending cmds after reset\n");
 
        return SUCCESS;
 }
@@ -2430,16 +2437,15 @@ static int megasas_generic_reset(struct scsi_cmnd *scmd)
                 scmd->cmnd[0], scmd->retries);
 
        if (instance->adprecovery == MEGASAS_HW_CRITICAL_ERROR) {
-               printk(KERN_ERR "megasas: cannot recover from previous reset "
-                      "failures\n");
+               dev_err(&instance->pdev->dev, "cannot recover from previous reset failures\n");
                return FAILED;
        }
 
        ret_val = megasas_wait_for_outstanding(instance);
        if (ret_val == SUCCESS)
-               printk(KERN_NOTICE "megasas: reset successful \n");
+               dev_notice(&instance->pdev->dev, "reset successful\n");
        else
-               printk(KERN_ERR "megasas: failed to do reset\n");
+               dev_err(&instance->pdev->dev, "failed to do reset\n");
 
        return ret_val;
 }
@@ -2481,14 +2487,10 @@ blk_eh_timer_return megasas_reset_timer(struct scsi_cmnd *scmd)
  */
 static int megasas_reset_device(struct scsi_cmnd *scmd)
 {
-       int ret;
-
        /*
         * First wait for all commands to complete
         */
-       ret = megasas_generic_reset(scmd);
-
-       return ret;
+       return megasas_generic_reset(scmd);
 }
 
 /**
@@ -2498,6 +2500,7 @@ static int megasas_reset_bus_host(struct scsi_cmnd *scmd)
 {
        int ret;
        struct megasas_instance *instance;
+
        instance = (struct megasas_instance *)scmd->device->host->hostdata;
 
        /*
@@ -2516,7 +2519,7 @@ static int megasas_reset_bus_host(struct scsi_cmnd *scmd)
 
 /**
  * megasas_bios_param - Returns disk geometry for a disk
- * @sdev:              device handle
+ * @sdev:              device handle
  * @bdev:              block device
  * @capacity:          drive capacity
  * @geom:              geometry parameters
@@ -2529,6 +2532,7 @@ megasas_bios_param(struct scsi_device *sdev, struct block_device *bdev,
        int sectors;
        sector_t cylinders;
        unsigned long tmp;
+
        /* Default heads (64) & sectors (32) */
        heads = 64;
        sectors = 32;
@@ -2575,6 +2579,7 @@ static void
 megasas_service_aen(struct megasas_instance *instance, struct megasas_cmd *cmd)
 {
        unsigned long flags;
+
        /*
         * Don't signal app if it is just an aborted previously registered aen
         */
@@ -2595,9 +2600,10 @@ megasas_service_aen(struct megasas_instance *instance, struct megasas_cmd *cmd)
        if ((instance->unload == 0) &&
                ((instance->issuepend_done == 1))) {
                struct megasas_aen_event *ev;
+
                ev = kzalloc(sizeof(*ev), GFP_ATOMIC);
                if (!ev) {
-                       printk(KERN_ERR "megasas_service_aen: out of memory\n");
+                       dev_err(&instance->pdev->dev, "megasas_service_aen: out of memory\n");
                } else {
                        ev->instance = instance;
                        instance->ev = ev;
@@ -2654,8 +2660,7 @@ megasas_fw_crash_buffer_show(struct device *cdev,
 
        buff_addr = (unsigned long) buf;
 
-       if (buff_offset >
-               (instance->fw_crash_buffer_size * dmachunk)) {
+       if (buff_offset > (instance->fw_crash_buffer_size * dmachunk)) {
                dev_err(&instance->pdev->dev,
                        "Firmware crash dump offset is out of range\n");
                spin_unlock_irqrestore(&instance->crashdump_lock, flags);
@@ -2667,7 +2672,7 @@ megasas_fw_crash_buffer_show(struct device *cdev,
 
        src_addr = (unsigned long)instance->crash_buf[buff_offset / dmachunk] +
                (buff_offset % dmachunk);
-       memcpy(buf, (void *)src_addr,  size);
+       memcpy(buf, (void *)src_addr, size);
        spin_unlock_irqrestore(&instance->crashdump_lock, flags);
 
        return size;
@@ -2727,6 +2732,7 @@ megasas_fw_crash_state_show(struct device *cdev,
        struct Scsi_Host *shost = class_to_shost(cdev);
        struct megasas_instance *instance =
                (struct megasas_instance *) shost->hostdata;
+
        return snprintf(buf, PAGE_SIZE, "%d\n", instance->fw_crash_state);
 }
 
@@ -2811,8 +2817,6 @@ megasas_complete_abort(struct megasas_instance *instance,
                cmd->cmd_status_drv = 0;
                wake_up(&instance->abort_cmd_wait_q);
        }
-
-       return;
 }
 
 /**
@@ -2820,10 +2824,10 @@ megasas_complete_abort(struct megasas_instance *instance,
  * @instance:                  Adapter soft state
  * @cmd:                       Command to be completed
  * @alt_status:                        If non-zero, use this value as status to
- *                             SCSI mid-layer instead of the value returned
- *                             by the FW. This should be used if caller wants
- *                             an alternate status (as in the case of aborted
- *                             commands)
+ *                             SCSI mid-layer instead of the value returned
+ *                             by the FW. This should be used if caller wants
+ *                             an alternate status (as in the case of aborted
+ *                             commands)
  */
 void
 megasas_complete_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd,
@@ -2847,10 +2851,10 @@ megasas_complete_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd,
                   MR_DCMD_CTRL_EVENT_GET_INFO left over from the main kernel
                   when booting the kdump kernel.  Ignore this command to
                   prevent a kernel panic on shutdown of the kdump kernel. */
-               printk(KERN_WARNING "megaraid_sas: MFI_CMD_INVALID command "
-                      "completed.\n");
-               printk(KERN_WARNING "megaraid_sas: If you have a controller "
-                      "other than PERC5, please upgrade your firmware.\n");
+               dev_warn(&instance->pdev->dev, "MFI_CMD_INVALID command "
+                      "completed\n");
+               dev_warn(&instance->pdev->dev, "If you have a controller "
+                      "other than PERC5, please upgrade your firmware\n");
                break;
        case MFI_CMD_PD_SCSI_IO:
        case MFI_CMD_LD_SCSI_IO:
@@ -2918,7 +2922,7 @@ megasas_complete_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd,
                        break;
 
                default:
-                       printk(KERN_DEBUG "megasas: MFI FW status %#x\n",
+                       dev_printk(KERN_DEBUG, &instance->pdev->dev, "MFI FW status %#x\n",
                               hdr->cmd_status);
                        cmd->scmd->result = DID_ERROR << 16;
                        break;
@@ -2944,8 +2948,7 @@ megasas_complete_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd,
                        if (cmd->frame->hdr.cmd_status != 0) {
                                if (cmd->frame->hdr.cmd_status !=
                                    MFI_STAT_NOT_FOUND)
-                                       printk(KERN_WARNING "megasas: map sync"
-                                              "failed, status = 0x%x.\n",
+                                       dev_warn(&instance->pdev->dev, "map syncfailed, status = 0x%x\n",
                                               cmd->frame->hdr.cmd_status);
                                else {
                                        megasas_return_cmd(instance, cmd);
@@ -2997,7 +3000,7 @@ megasas_complete_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd,
                break;
 
        default:
-               printk("megasas: Unknown command completed! [0x%X]\n",
+               dev_info(&instance->pdev->dev, "Unknown command completed! [0x%X]\n",
                       hdr->cmd);
                break;
        }
@@ -3005,7 +3008,7 @@ megasas_complete_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd,
 
 /**
  * megasas_issue_pending_cmds_again -  issue all pending cmds
- *                                     in FW again because of the fw reset
+ *                                     in FW again because of the fw reset
  * @instance:                          Adapter soft state
  */
 static inline void
@@ -3023,19 +3026,19 @@ megasas_issue_pending_cmds_again(struct megasas_instance *instance)
        spin_unlock_irqrestore(&instance->hba_lock, flags);
 
        while (!list_empty(&clist_local)) {
-               cmd     = list_entry((&clist_local)->next,
+               cmd = list_entry((&clist_local)->next,
                                        struct megasas_cmd, list);
                list_del_init(&cmd->list);
 
                if (cmd->sync_cmd || cmd->scmd) {
-                       printk(KERN_NOTICE "megaraid_sas: command %p, %p:%d"
-                               "detected to be pending while HBA reset.\n",
+                       dev_notice(&instance->pdev->dev, "command %p, %p:%d"
+                               "detected to be pending while HBA reset\n",
                                        cmd, cmd->scmd, cmd->sync_cmd);
 
                        cmd->retry_for_fw_reset++;
 
                        if (cmd->retry_for_fw_reset == 3) {
-                               printk(KERN_NOTICE "megaraid_sas: cmd %p, %p:%d"
+                               dev_notice(&instance->pdev->dev, "cmd %p, %p:%d"
                                        "was tried multiple times during reset."
                                        "Shutting down the HBA\n",
                                        cmd, cmd->scmd, cmd->sync_cmd);
@@ -3048,18 +3051,18 @@ megasas_issue_pending_cmds_again(struct megasas_instance *instance)
 
                if (cmd->sync_cmd == 1) {
                        if (cmd->scmd) {
-                               printk(KERN_NOTICE "megaraid_sas: unexpected"
+                               dev_notice(&instance->pdev->dev, "unexpected"
                                        "cmd attached to internal command!\n");
                        }
-                       printk(KERN_NOTICE "megasas: %p synchronous cmd"
+                       dev_notice(&instance->pdev->dev, "%p synchronous cmd"
                                                "on the internal reset queue,"
                                                "issue it again.\n", cmd);
                        cmd->cmd_status_drv = MFI_STAT_INVALID_STATUS;
                        instance->instancet->fire_cmd(instance,
-                                                       cmd->frame_phys_addr ,
+                                                       cmd->frame_phys_addr,
                                                        0, instance->reg_set);
                } else if (cmd->scmd) {
-                       printk(KERN_NOTICE "megasas: %p scsi cmd [%02x]"
+                       dev_notice(&instance->pdev->dev, "%p scsi cmd [%02x]"
                        "detected on the internal queue, issue again.\n",
                        cmd, cmd->scmd->cmnd[0]);
 
@@ -3068,22 +3071,22 @@ megasas_issue_pending_cmds_again(struct megasas_instance *instance)
                                        cmd->frame_phys_addr,
                                        cmd->frame_count-1, instance->reg_set);
                } else {
-                       printk(KERN_NOTICE "megasas: %p unexpected cmd on the"
+                       dev_notice(&instance->pdev->dev, "%p unexpected cmd on the"
                                "internal reset defer list while re-issue!!\n",
                                cmd);
                }
        }
 
        if (instance->aen_cmd) {
-               printk(KERN_NOTICE "megaraid_sas: aen_cmd in def process\n");
+               dev_notice(&instance->pdev->dev, "aen_cmd in def process\n");
                megasas_return_cmd(instance, instance->aen_cmd);
 
-               instance->aen_cmd       = NULL;
+               instance->aen_cmd = NULL;
        }
 
        /*
-       * Initiate AEN (Asynchronous Event Notification)
-       */
+        * Initiate AEN (Asynchronous Event Notification)
+        */
        seq_num = instance->last_seq_num;
        class_locale.members.reserved = 0;
        class_locale.members.locale = MR_EVT_LOCALE_ALL;
@@ -3110,17 +3113,17 @@ megasas_internal_reset_defer_cmds(struct megasas_instance *instance)
        u32 defer_index;
        unsigned long flags;
 
-       defer_index     = 0;
+       defer_index = 0;
        spin_lock_irqsave(&instance->mfi_pool_lock, flags);
        for (i = 0; i < max_cmd; i++) {
                cmd = instance->cmd_list[i];
                if (cmd->sync_cmd == 1 || cmd->scmd) {
-                       printk(KERN_NOTICE "megasas: moving cmd[%d]:%p:%d:%p"
+                       dev_notice(&instance->pdev->dev, "moving cmd[%d]:%p:%d:%p"
                                        "on the defer queue as internal\n",
                                defer_index, cmd, cmd->sync_cmd, cmd->scmd);
 
                        if (!list_empty(&cmd->list)) {
-                               printk(KERN_NOTICE "megaraid_sas: ERROR while"
+                               dev_notice(&instance->pdev->dev, "ERROR while"
                                        " moving this cmd:%p, %d %p, it was"
                                        "discovered on some list?\n",
                                        cmd, cmd->sync_cmd, cmd->scmd);
@@ -3145,13 +3148,13 @@ process_fw_state_change_wq(struct work_struct *work)
        unsigned long flags;
 
        if (instance->adprecovery != MEGASAS_ADPRESET_SM_INFAULT) {
-               printk(KERN_NOTICE "megaraid_sas: error, recovery st %x \n",
+               dev_notice(&instance->pdev->dev, "error, recovery st %x\n",
                                instance->adprecovery);
                return ;
        }
 
        if (instance->adprecovery == MEGASAS_ADPRESET_SM_INFAULT) {
-               printk(KERN_NOTICE "megaraid_sas: FW detected to be in fault"
+               dev_notice(&instance->pdev->dev, "FW detected to be in fault"
                                        "state, restarting it...\n");
 
                instance->instancet->disable_intr(instance);
@@ -3159,21 +3162,21 @@ process_fw_state_change_wq(struct work_struct *work)
 
                atomic_set(&instance->fw_reset_no_pci_access, 1);
                instance->instancet->adp_reset(instance, instance->reg_set);
-               atomic_set(&instance->fw_reset_no_pci_access, 0 );
+               atomic_set(&instance->fw_reset_no_pci_access, 0);
 
-               printk(KERN_NOTICE "megaraid_sas: FW restarted successfully,"
+               dev_notice(&instance->pdev->dev, "FW restarted successfully,"
                                        "initiating next stage...\n");
 
-               printk(KERN_NOTICE "megaraid_sas: HBA recovery state machine,"
+               dev_notice(&instance->pdev->dev, "HBA recovery state machine,"
                                        "state 2 starting...\n");
 
-               /*waitting for about 20 second before start the second init*/
+               /* waiting for about 20 second before start the second init */
                for (wait = 0; wait < 30; wait++) {
                        msleep(1000);
                }
 
                if (megasas_transition_to_ready(instance, 1)) {
-                       printk(KERN_NOTICE "megaraid_sas:adapter not ready\n");
+                       dev_notice(&instance->pdev->dev, "adapter not ready\n");
 
                        atomic_set(&instance->fw_reset_no_pci_access, 1);
                        megaraid_sas_kill_hba(instance);
@@ -3200,15 +3203,14 @@ process_fw_state_change_wq(struct work_struct *work)
                megasas_issue_pending_cmds_again(instance);
                instance->issuepend_done = 1;
        }
-       return ;
 }
 
 /**
  * megasas_deplete_reply_queue -       Processes all completed commands
  * @instance:                          Adapter soft state
  * @alt_status:                                Alternate status to be returned to
- *                                     SCSI mid-layer instead of the status
- *                                     returned by the FW
+ *                                     SCSI mid-layer instead of the status
+ *                                     returned by the FW
  * Note: this must be called with hba lock held
  */
 static int
@@ -3238,13 +3240,13 @@ megasas_deplete_reply_queue(struct megasas_instance *instance,
                                instance->reg_set) & MFI_STATE_MASK;
 
                if (fw_state != MFI_STATE_FAULT) {
-                       printk(KERN_NOTICE "megaraid_sas: fw state:%x\n",
+                       dev_notice(&instance->pdev->dev, "fw state:%x\n",
                                                fw_state);
                }
 
                if ((fw_state == MFI_STATE_FAULT) &&
                                (instance->disableOnlineCtrlReset == 0)) {
-                       printk(KERN_NOTICE "megaraid_sas: wait adp restart\n");
+                       dev_notice(&instance->pdev->dev, "wait adp restart\n");
 
                        if ((instance->pdev->device ==
                                        PCI_DEVICE_ID_LSI_SAS1064R) ||
@@ -3265,14 +3267,14 @@ megasas_deplete_reply_queue(struct megasas_instance *instance,
                        atomic_set(&instance->fw_outstanding, 0);
                        megasas_internal_reset_defer_cmds(instance);
 
-                       printk(KERN_NOTICE "megasas: fwState=%x, stage:%d\n",
+                       dev_notice(&instance->pdev->dev, "fwState=%x, stage:%d\n",
                                        fw_state, instance->adprecovery);
 
                        schedule_work(&instance->work_init);
                        return IRQ_HANDLED;
 
                } else {
-                       printk(KERN_NOTICE "megasas: fwstate:%x, dis_OCR=%x\n",
+                       dev_notice(&instance->pdev->dev, "fwstate:%x, dis_OCR=%x\n",
                                fw_state, instance->disableOnlineCtrlReset);
                }
        }
@@ -3288,13 +3290,13 @@ static irqreturn_t megasas_isr(int irq, void *devp)
        struct megasas_irq_context *irq_context = devp;
        struct megasas_instance *instance = irq_context->instance;
        unsigned long flags;
-       irqreturn_t     rc;
+       irqreturn_t rc;
 
        if (atomic_read(&instance->fw_reset_no_pci_access))
                return IRQ_HANDLED;
 
        spin_lock_irqsave(&instance->hba_lock, flags);
-       rc =  megasas_deplete_reply_queue(instance, DID_OK);
+       rc = megasas_deplete_reply_queue(instance, DID_OK);
        spin_unlock_irqrestore(&instance->hba_lock, flags);
 
        return rc;
@@ -3322,7 +3324,7 @@ megasas_transition_to_ready(struct megasas_instance *instance, int ocr)
        fw_state = abs_state & MFI_STATE_MASK;
 
        if (fw_state != MFI_STATE_READY)
-               printk(KERN_INFO "megasas: Waiting for FW to come to ready"
+               dev_info(&instance->pdev->dev, "Waiting for FW to come to ready"
                       " state\n");
 
        while (fw_state != MFI_STATE_READY) {
@@ -3330,7 +3332,7 @@ megasas_transition_to_ready(struct megasas_instance *instance, int ocr)
                switch (fw_state) {
 
                case MFI_STATE_FAULT:
-                       printk(KERN_DEBUG "megasas: FW in FAULT state!!\n");
+                       dev_printk(KERN_DEBUG, &instance->pdev->dev, "FW in FAULT state!!\n");
                        if (ocr) {
                                max_wait = MEGASAS_RESET_WAIT_TIME;
                                cur_state = MFI_STATE_FAULT;
@@ -3469,7 +3471,7 @@ megasas_transition_to_ready(struct megasas_instance *instance, int ocr)
                        break;
 
                default:
-                       printk(KERN_DEBUG "megasas: Unknown state 0x%x\n",
+                       dev_printk(KERN_DEBUG, &instance->pdev->dev, "Unknown state 0x%x\n",
                               fw_state);
                        return -ENODEV;
                }
@@ -3491,7 +3493,7 @@ megasas_transition_to_ready(struct megasas_instance *instance, int ocr)
                 * Return error if fw_state hasn't changed after max_wait
                 */
                if (curr_abs_state == abs_state) {
-                       printk(KERN_DEBUG "FW state [%d] hasn't changed "
+                       dev_printk(KERN_DEBUG, &instance->pdev->dev, "FW state [%d] hasn't changed "
                               "in %d secs\n", fw_state, max_wait);
                        return -ENODEV;
                }
@@ -3499,7 +3501,7 @@ megasas_transition_to_ready(struct megasas_instance *instance, int ocr)
                abs_state = curr_abs_state;
                fw_state = curr_abs_state & MFI_STATE_MASK;
        }
-       printk(KERN_INFO "megasas: FW now in Ready state\n");
+       dev_info(&instance->pdev->dev, "FW now in Ready state\n");
 
        return 0;
 }
@@ -3570,9 +3572,8 @@ static int megasas_create_frame_pool(struct megasas_instance *instance)
        sge_sz = (IS_DMA64) ? sizeof(struct megasas_sge64) :
            sizeof(struct megasas_sge32);
 
-       if (instance->flag_ieee) {
+       if (instance->flag_ieee)
                sge_sz = sizeof(struct megasas_sge_skinny);
-       }
 
        /*
         * For MFI controllers.
@@ -3594,7 +3595,7 @@ static int megasas_create_frame_pool(struct megasas_instance *instance)
                                        instance->pdev, total_sz, 256, 0);
 
        if (!instance->frame_dma_pool) {
-               printk(KERN_DEBUG "megasas: failed to setup frame pool\n");
+               dev_printk(KERN_DEBUG, &instance->pdev->dev, "failed to setup frame pool\n");
                return -ENOMEM;
        }
 
@@ -3602,7 +3603,7 @@ static int megasas_create_frame_pool(struct megasas_instance *instance)
                                                   instance->pdev, 128, 4, 0);
 
        if (!instance->sense_dma_pool) {
-               printk(KERN_DEBUG "megasas: failed to setup sense pool\n");
+               dev_printk(KERN_DEBUG, &instance->pdev->dev, "failed to setup sense pool\n");
 
                pci_pool_destroy(instance->frame_dma_pool);
                instance->frame_dma_pool = NULL;
@@ -3630,7 +3631,7 @@ static int megasas_create_frame_pool(struct megasas_instance *instance)
                 * whatever has been allocated
                 */
                if (!cmd->frame || !cmd->sense) {
-                       printk(KERN_DEBUG "megasas: pci_pool_alloc failed \n");
+                       dev_printk(KERN_DEBUG, &instance->pdev->dev, "pci_pool_alloc failed\n");
                        megasas_teardown_frame_pool(instance);
                        return -ENOMEM;
                }
@@ -3656,6 +3657,7 @@ static int megasas_create_frame_pool(struct megasas_instance *instance)
 void megasas_free_cmds(struct megasas_instance *instance)
 {
        int i;
+
        /* First free the MFI frame pool */
        megasas_teardown_frame_pool(instance);
 
@@ -3708,7 +3710,7 @@ int megasas_alloc_cmds(struct megasas_instance *instance)
        instance->cmd_list = kcalloc(max_cmd, sizeof(struct megasas_cmd*), GFP_KERNEL);
 
        if (!instance->cmd_list) {
-               printk(KERN_DEBUG "megasas: out of memory\n");
+               dev_printk(KERN_DEBUG, &instance->pdev->dev, "out of memory\n");
                return -ENOMEM;
        }
 
@@ -3744,7 +3746,7 @@ int megasas_alloc_cmds(struct megasas_instance *instance)
         * Create a frame pool and assign one frame to each cmd
         */
        if (megasas_create_frame_pool(instance)) {
-               printk(KERN_DEBUG "megasas: Error creating frame DMA pool\n");
+               dev_printk(KERN_DEBUG, &instance->pdev->dev, "Error creating frame DMA pool\n");
                megasas_free_cmds(instance);
        }
 
@@ -3773,7 +3775,7 @@ megasas_get_pd_list(struct megasas_instance *instance)
        cmd = megasas_get_cmd(instance);
 
        if (!cmd) {
-               printk(KERN_DEBUG "megasas (get_pd_list): Failed to get cmd\n");
+               dev_printk(KERN_DEBUG, &instance->pdev->dev, "(get_pd_list): Failed to get cmd\n");
                return -ENOMEM;
        }
 
@@ -3783,7 +3785,7 @@ megasas_get_pd_list(struct megasas_instance *instance)
                  MEGASAS_MAX_PD * sizeof(struct MR_PD_LIST), &ci_h);
 
        if (!ci) {
-               printk(KERN_DEBUG "Failed to alloc mem for pd_list\n");
+               dev_printk(KERN_DEBUG, &instance->pdev->dev, "Failed to alloc mem for pd_list\n");
                megasas_return_cmd(instance, cmd);
                return -ENOMEM;
        }
@@ -3811,12 +3813,12 @@ megasas_get_pd_list(struct megasas_instance *instance)
                ret = megasas_issue_polled(instance, cmd);
 
        /*
-       * the following function will get the instance PD LIST.
-       */
+        * the following function will get the instance PD LIST.
+        */
 
        pd_addr = ci->addr;
 
-       if ( ret == 0 &&
+       if (ret == 0 &&
             (le32_to_cpu(ci->count) <
                  (MEGASAS_MAX_PD_CHANNELS * MEGASAS_MAX_DEV_PER_CHANNEL))) {
 
@@ -3868,7 +3870,7 @@ megasas_get_ld_list(struct megasas_instance *instance)
        cmd = megasas_get_cmd(instance);
 
        if (!cmd) {
-               printk(KERN_DEBUG "megasas_get_ld_list: Failed to get cmd\n");
+               dev_printk(KERN_DEBUG, &instance->pdev->dev, "megasas_get_ld_list: Failed to get cmd\n");
                return -ENOMEM;
        }
 
@@ -3879,7 +3881,7 @@ megasas_get_ld_list(struct megasas_instance *instance)
                                &ci_h);
 
        if (!ci) {
-               printk(KERN_DEBUG "Failed to alloc mem in get_ld_list\n");
+               dev_printk(KERN_DEBUG, &instance->pdev->dev, "Failed to alloc mem in get_ld_list\n");
                megasas_return_cmd(instance, cmd);
                return -ENOMEM;
        }
@@ -3954,8 +3956,8 @@ megasas_ld_list_query(struct megasas_instance *instance, u8 query_type)
        cmd = megasas_get_cmd(instance);
 
        if (!cmd) {
-               printk(KERN_WARNING
-                      "megasas:(megasas_ld_list_query): Failed to get cmd\n");
+               dev_warn(&instance->pdev->dev,
+                        "megasas_ld_list_query: Failed to get cmd\n");
                return -ENOMEM;
        }
 
@@ -3965,8 +3967,8 @@ megasas_ld_list_query(struct megasas_instance *instance, u8 query_type)
                                  sizeof(struct MR_LD_TARGETID_LIST), &ci_h);
 
        if (!ci) {
-               printk(KERN_WARNING
-                      "megasas: Failed to alloc mem for ld_list_query\n");
+               dev_warn(&instance->pdev->dev,
+                        "Failed to alloc mem for ld_list_query\n");
                megasas_return_cmd(instance, cmd);
                return -ENOMEM;
        }
@@ -4052,11 +4054,11 @@ static void megasas_update_ext_vd_details(struct megasas_instance *instance)
                instance->supportmax256vd ? "Extended VD(240 VD)firmware" :
                "Legacy(64 VD) firmware");
 
-       old_map_sz =  sizeof(struct MR_FW_RAID_MAP) +
+       old_map_sz = sizeof(struct MR_FW_RAID_MAP) +
                                (sizeof(struct MR_LD_SPAN_MAP) *
                                (instance->fw_supported_vd_count - 1));
-       new_map_sz =  sizeof(struct MR_FW_RAID_MAP_EXT);
-       fusion->drv_map_sz =  sizeof(struct MR_DRV_RAID_MAP) +
+       new_map_sz = sizeof(struct MR_FW_RAID_MAP_EXT);
+       fusion->drv_map_sz = sizeof(struct MR_DRV_RAID_MAP) +
                                (sizeof(struct MR_LD_SPAN_MAP) *
                                (instance->drv_supported_vd_count - 1));
 
@@ -4067,7 +4069,6 @@ static void megasas_update_ext_vd_details(struct megasas_instance *instance)
                fusion->current_map_sz = new_map_sz;
        else
                fusion->current_map_sz = old_map_sz;
-
 }
 
 /**
@@ -4093,7 +4094,7 @@ megasas_get_ctrl_info(struct megasas_instance *instance)
        cmd = megasas_get_cmd(instance);
 
        if (!cmd) {
-               printk(KERN_DEBUG "megasas: Failed to get a free cmd\n");
+               dev_printk(KERN_DEBUG, &instance->pdev->dev, "Failed to get a free cmd\n");
                return -ENOMEM;
        }
 
@@ -4103,7 +4104,7 @@ megasas_get_ctrl_info(struct megasas_instance *instance)
                                  sizeof(struct megasas_ctrl_info), &ci_h);
 
        if (!ci) {
-               printk(KERN_DEBUG "Failed to alloc mem for ctrl info\n");
+               dev_printk(KERN_DEBUG, &instance->pdev->dev, "Failed to alloc mem for ctrl info\n");
                megasas_return_cmd(instance, cmd);
                return -ENOMEM;
        }
@@ -4214,9 +4215,7 @@ static int
 megasas_issue_init_mfi(struct megasas_instance *instance)
 {
        __le32 context;
-
        struct megasas_cmd *cmd;
-
        struct megasas_init_frame *init_frame;
        struct megasas_init_queue_info *initq_info;
        dma_addr_t init_frame_h;
@@ -4269,7 +4268,7 @@ megasas_issue_init_mfi(struct megasas_instance *instance)
         */
 
        if (megasas_issue_polled(instance, cmd)) {
-               printk(KERN_ERR "megasas: Failed to init firmware\n");
+               dev_err(&instance->pdev->dev, "Failed to init firmware\n");
                megasas_return_cmd(instance, cmd);
                goto fail_fw_init;
        }
@@ -4342,7 +4341,7 @@ megasas_init_adapter_mfi(struct megasas_instance *instance)
                                                     &instance->reply_queue_h);
 
        if (!instance->reply_queue) {
-               printk(KERN_DEBUG "megasas: Out of DMA mem for reply queue\n");
+               dev_printk(KERN_DEBUG, &instance->pdev->dev, "Out of DMA mem for reply queue\n");
                goto fail_reply_queue;
        }
 
@@ -4361,7 +4360,7 @@ megasas_init_adapter_mfi(struct megasas_instance *instance)
                (instance->instancet->read_fw_status_reg(reg_set) &
                0x04000000);
 
-       printk(KERN_NOTICE "megasas_init_mfi: fw_support_ieee=%d",
+       dev_notice(&instance->pdev->dev, "megasas_init_mfi: fw_support_ieee=%d",
                        instance->fw_support_ieee);
 
        if (instance->fw_support_ieee)
@@ -4505,7 +4504,7 @@ static int megasas_init_fw(struct megasas_instance *instance)
        instance->bar = find_first_bit(&bar_list, sizeof(unsigned long));
        if (pci_request_selected_regions(instance->pdev, instance->bar,
                                         "megasas: LSI")) {
-               printk(KERN_DEBUG "megasas: IO memory region busy!\n");
+               dev_printk(KERN_DEBUG, &instance->pdev->dev, "IO memory region busy!\n");
                return -EBUSY;
        }
 
@@ -4513,7 +4512,7 @@ static int megasas_init_fw(struct megasas_instance *instance)
        instance->reg_set = ioremap_nocache(base_addr, 8192);
 
        if (!instance->reg_set) {
-               printk(KERN_DEBUG "megasas: Failed to map IO mem\n");
+               dev_printk(KERN_DEBUG, &instance->pdev->dev, "Failed to map IO mem\n");
                goto fail_ioremap;
        }
 
@@ -4551,7 +4550,7 @@ static int megasas_init_fw(struct megasas_instance *instance)
                        (instance, instance->reg_set);
                atomic_set(&instance->fw_reset_no_pci_access, 0);
                dev_info(&instance->pdev->dev,
-                       "megasas: FW restarted successfully from %s!\n",
+                       "FW restarted successfully from %s!\n",
                        __func__);
 
                /*waitting for about 30 second before retry*/
@@ -4652,16 +4651,15 @@ static int megasas_init_fw(struct megasas_instance *instance)
 
        instance->instancet->enable_intr(instance);
 
-       printk(KERN_ERR "megasas: INIT adapter done\n");
+       dev_err(&instance->pdev->dev, "INIT adapter done\n");
 
        /** for passthrough
-       * the following function will get the PD LIST.
-       */
-
-       memset(instance->pd_list, 0 ,
+        * the following function will get the PD LIST.
+        */
+       memset(instance->pd_list, 0,
                (MEGASAS_MAX_PD * sizeof(struct megasas_pd_list)));
        if (megasas_get_pd_list(instance) < 0) {
-               printk(KERN_ERR "megasas: failed to get PD list\n");
+               dev_err(&instance->pdev->dev, "failed to get PD list\n");
                goto fail_get_pd_list;
        }
 
@@ -4686,7 +4684,7 @@ static int megasas_init_fw(struct megasas_instance *instance)
                le16_to_cpu(ctrl_info->max_strips_per_io);
        max_sectors_2 = le32_to_cpu(ctrl_info->max_request_size);
 
-       tmp_sectors = min_t(u32, max_sectors_1 , max_sectors_2);
+       tmp_sectors = min_t(u32, max_sectors_1, max_sectors_2);
 
        instance->disableOnlineCtrlReset =
        ctrl_info->properties.OnOffProperties.disableOnlineCtrlReset;
@@ -4960,7 +4958,7 @@ megasas_register_aen(struct megasas_instance *instance, u32 seq_num,
                                                                  aen_cmd, 30);
 
                        if (ret_val) {
-                               printk(KERN_DEBUG "megasas: Failed to abort "
+                               dev_printk(KERN_DEBUG, &instance->pdev->dev, "Failed to abort "
                                       "previous AEN command\n");
                                return ret_val;
                        }
@@ -5051,7 +5049,7 @@ static int megasas_start_aen(struct megasas_instance *instance)
 static int megasas_io_attach(struct megasas_instance *instance)
 {
        struct Scsi_Host *host = instance->host;
-       u32             error;
+       u32 error;
 
        /*
         * Export parameters required by SCSI mid-layer
@@ -5079,7 +5077,7 @@ static int megasas_io_attach(struct megasas_instance *instance)
                                (max_sectors <= MEGASAS_MAX_SECTORS)) {
                                instance->max_sectors_per_req = max_sectors;
                        } else {
-                       printk(KERN_INFO "megasas: max_sectors should be > 0"
+                       dev_info(&instance->pdev->dev, "max_sectors should be > 0"
                                "and <= %d (or < 1MB for GEN2 controller)\n",
                                instance->max_sectors_per_req);
                        }
@@ -5126,7 +5124,7 @@ static int
 megasas_set_dma_mask(struct pci_dev *pdev)
 {
        /*
-        * All our contollers are capable of performing 64-bit DMA
+        * All our controllers are capable of performing 64-bit DMA
         */
        if (IS_DMA64) {
                if (pci_set_dma_mask(pdev, DMA_BIT_MASK(64)) != 0) {
@@ -5206,13 +5204,13 @@ static int megasas_probe_one(struct pci_dev *pdev,
                               sizeof(struct megasas_instance));
 
        if (!host) {
-               printk(KERN_DEBUG "megasas: scsi_host_alloc failed\n");
+               dev_printk(KERN_DEBUG, &pdev->dev, "scsi_host_alloc failed\n");
                goto fail_alloc_instance;
        }
 
        instance = (struct megasas_instance *)host->hostdata;
        memset(instance, 0, sizeof(*instance));
-       atomic_set( &instance->fw_reset_no_pci_access, 0 );
+       atomic_set(&instance->fw_reset_no_pci_access, 0);
        instance->pdev = pdev;
 
        switch (instance->pdev->device) {
@@ -5226,7 +5224,7 @@ static int megasas_probe_one(struct pci_dev *pdev,
                instance->ctrl_context = (void *)__get_free_pages(GFP_KERNEL,
                                instance->ctrl_context_pages);
                if (!instance->ctrl_context) {
-                       printk(KERN_DEBUG "megasas: Failed to allocate "
+                       dev_printk(KERN_DEBUG, &pdev->dev, "Failed to allocate "
                               "memory for Fusion context info\n");
                        goto fail_alloc_dma_buf;
                }
@@ -5245,7 +5243,7 @@ static int megasas_probe_one(struct pci_dev *pdev,
                                             &instance->consumer_h);
 
                if (!instance->producer || !instance->consumer) {
-                       printk(KERN_DEBUG "megasas: Failed to allocate"
+                       dev_printk(KERN_DEBUG, &pdev->dev, "Failed to allocate"
                               "memory for producer, consumer\n");
                        goto fail_alloc_dma_buf;
                }
@@ -5276,7 +5274,7 @@ static int megasas_probe_one(struct pci_dev *pdev,
                                                CRASH_DMA_BUF_SIZE,
                                                &instance->crash_dump_h);
        if (!instance->crash_dump_buf)
-               dev_err(&instance->pdev->dev, "Can't allocate Firmware "
+               dev_err(&pdev->dev, "Can't allocate Firmware "
                        "crash dump DMA buffer\n");
 
        megasas_poll_wait_aen = 0;
@@ -5292,7 +5290,7 @@ static int megasas_probe_one(struct pci_dev *pdev,
                                                    &instance->evt_detail_h);
 
        if (!instance->evt_detail) {
-               printk(KERN_DEBUG "megasas: Failed to allocate memory for "
+               dev_printk(KERN_DEBUG, &pdev->dev, "Failed to allocate memory for "
                       "event detail structure\n");
                goto fail_alloc_dma_buf;
        }
@@ -5356,7 +5354,7 @@ static int megasas_probe_one(struct pci_dev *pdev,
                                pci_alloc_consistent(pdev, sizeof(struct MR_LD_VF_AFFILIATION_111),
                                                     &instance->vf_affiliation_111_h);
                        if (!instance->vf_affiliation_111)
-                               printk(KERN_WARNING "megasas: Can't allocate "
+                               dev_warn(&pdev->dev, "Can't allocate "
                                       "memory for VF affiliation buffer\n");
                } else {
                        instance->vf_affiliation =
@@ -5365,7 +5363,7 @@ static int megasas_probe_one(struct pci_dev *pdev,
                                                     sizeof(struct MR_LD_VF_AFFILIATION),
                                                     &instance->vf_affiliation_h);
                        if (!instance->vf_affiliation)
-                               printk(KERN_WARNING "megasas: Can't allocate "
+                               dev_warn(&pdev->dev, "Can't allocate "
                                       "memory for VF affiliation buffer\n");
                }
        }
@@ -5399,7 +5397,7 @@ static int megasas_probe_one(struct pci_dev *pdev,
         * Initiate AEN (Asynchronous Event Notification)
         */
        if (megasas_start_aen(instance)) {
-               printk(KERN_DEBUG "megasas: start aen failed\n");
+               dev_printk(KERN_DEBUG, &pdev->dev, "start aen failed\n");
                goto fail_start_aen;
        }
 
@@ -5409,8 +5407,8 @@ static int megasas_probe_one(struct pci_dev *pdev,
 
        return 0;
 
-      fail_start_aen:
-      fail_io_attach:
+fail_start_aen:
+fail_io_attach:
        megasas_mgmt_info.count--;
        megasas_mgmt_info.instance[megasas_mgmt_info.max_index] = NULL;
        megasas_mgmt_info.max_index--;
@@ -5428,7 +5426,7 @@ static int megasas_probe_one(struct pci_dev *pdev,
        if (instance->msix_vectors)
                pci_disable_msix(instance->pdev);
 fail_init_mfi:
-      fail_alloc_dma_buf:
+fail_alloc_dma_buf:
        if (instance->evt_detail)
                pci_free_consistent(pdev, sizeof(struct megasas_evt_detail),
                                    instance->evt_detail,
@@ -5442,8 +5440,8 @@ fail_init_mfi:
                                    instance->consumer_h);
        scsi_host_put(host);
 
-      fail_alloc_instance:
-      fail_set_dma_mask:
+fail_alloc_instance:
+fail_set_dma_mask:
        pci_disable_device(pdev);
 
        return -ENODEV;
@@ -5485,8 +5483,6 @@ static void megasas_flush_cache(struct megasas_instance *instance)
                        " from %s\n", __func__);
 
        megasas_return_cmd(instance, cmd);
-
-       return;
 }
 
 /**
@@ -5532,8 +5528,6 @@ static void megasas_shutdown_controller(struct megasas_instance *instance,
                        "from %s\n", __func__);
 
        megasas_return_cmd(instance, cmd);
-
-       return;
 }
 
 #ifdef CONFIG_PM
@@ -5607,7 +5601,7 @@ megasas_resume(struct pci_dev *pdev)
        rval = pci_enable_device_mem(pdev);
 
        if (rval) {
-               printk(KERN_ERR "megasas: Enable device failed\n");
+               dev_err(&pdev->dev, "Enable device failed\n");
                return rval;
        }
 
@@ -5686,7 +5680,7 @@ megasas_resume(struct pci_dev *pdev)
         * Initiate AEN (Asynchronous Event Notification)
         */
        if (megasas_start_aen(instance))
-               printk(KERN_ERR "megasas: Start AEN failed\n");
+               dev_err(&instance->pdev->dev, "Start AEN failed\n");
 
        return 0;
 
@@ -5839,8 +5833,6 @@ static void megasas_detach_one(struct pci_dev *pdev)
        scsi_host_put(host);
 
        pci_disable_device(pdev);
-
-       return;
 }
 
 /**
@@ -5909,11 +5901,11 @@ static unsigned int megasas_mgmt_poll(struct file *file, poll_table *wait)
 {
        unsigned int mask;
        unsigned long flags;
+
        poll_wait(file, &megasas_poll_wait, wait);
        spin_lock_irqsave(&poll_aen_lock, flags);
        if (megasas_poll_wait_aen)
-               mask =   (POLLIN | POLLRDNORM);
-
+               mask = (POLLIN | POLLRDNORM);
        else
                mask = 0;
        megasas_poll_wait_aen = 0;
@@ -5927,8 +5919,7 @@ static unsigned int megasas_mgmt_poll(struct file *file, poll_table *wait)
  * @cmd:       MFI command frame
  */
 
-static int megasas_set_crash_dump_params_ioctl(
-       struct megasas_cmd *cmd)
+static int megasas_set_crash_dump_params_ioctl(struct megasas_cmd *cmd)
 {
        struct megasas_instance *local_instance;
        int i, error = 0;
@@ -5982,14 +5973,14 @@ megasas_mgmt_fw_ioctl(struct megasas_instance *instance,
        memset(kbuff_arr, 0, sizeof(kbuff_arr));
 
        if (ioc->sge_count > MAX_IOCTL_SGE) {
-               printk(KERN_DEBUG "megasas: SGE count [%d] >  max limit [%d]\n",
+               dev_printk(KERN_DEBUG, &instance->pdev->dev, "SGE count [%d] >  max limit [%d]\n",
                       ioc->sge_count, MAX_IOCTL_SGE);
                return -EINVAL;
        }
 
        cmd = megasas_get_cmd(instance);
        if (!cmd) {
-               printk(KERN_DEBUG "megasas: Failed to get a cmd packet\n");
+               dev_printk(KERN_DEBUG, &instance->pdev->dev, "Failed to get a cmd packet\n");
                return -ENOMEM;
        }
 
@@ -6034,8 +6025,8 @@ megasas_mgmt_fw_ioctl(struct megasas_instance *instance,
                                                    ioc->sgl[i].iov_len,
                                                    &buf_handle, GFP_KERNEL);
                if (!kbuff_arr[i]) {
-                       printk(KERN_DEBUG "megasas: Failed to alloc "
-                              "kernel SGL buffer for IOCTL \n");
+                       dev_printk(KERN_DEBUG, &instance->pdev->dev, "Failed to alloc "
+                              "kernel SGL buffer for IOCTL\n");
                        error = -ENOMEM;
                        goto out;
                }
@@ -6108,7 +6099,7 @@ megasas_mgmt_fw_ioctl(struct megasas_instance *instance,
 
                if (copy_to_user((void __user *)((unsigned long)(*sense_ptr)),
                                 sense, ioc->sense_len)) {
-                       printk(KERN_ERR "megasas: Failed to copy out to user "
+                       dev_err(&instance->pdev->dev, "Failed to copy out to user "
                                        "sense data\n");
                        error = -EFAULT;
                        goto out;
@@ -6120,11 +6111,11 @@ megasas_mgmt_fw_ioctl(struct megasas_instance *instance,
         */
        if (copy_to_user(&user_ioc->frame.hdr.cmd_status,
                         &cmd->frame->hdr.cmd_status, sizeof(u8))) {
-               printk(KERN_DEBUG "megasas: Error copying out cmd_status\n");
+               dev_printk(KERN_DEBUG, &instance->pdev->dev, "Error copying out cmd_status\n");
                error = -EFAULT;
        }
 
-      out:
+out:
        if (sense) {
                dma_free_coherent(&instance->pdev->dev, ioc->sense_len,
                                    sense, sense_handle);
@@ -6180,7 +6171,7 @@ static int megasas_mgmt_ioctl_fw(struct file *file, unsigned long arg)
        }
 
        if (instance->adprecovery == MEGASAS_HW_CRITICAL_ERROR) {
-               printk(KERN_ERR "Controller in crit error\n");
+               dev_err(&instance->pdev->dev, "Controller in crit error\n");
                error = -ENODEV;
                goto out_kfree_ioc;
        }
@@ -6205,7 +6196,7 @@ static int megasas_mgmt_ioctl_fw(struct file *file, unsigned long arg)
                spin_unlock_irqrestore(&instance->hba_lock, flags);
 
                if (!(i % MEGASAS_RESET_NOTICE_INTERVAL)) {
-                       printk(KERN_NOTICE "megasas: waiting"
+                       dev_notice(&instance->pdev->dev, "waiting"
                                "for controller reset to finish\n");
                }
 
@@ -6216,7 +6207,7 @@ static int megasas_mgmt_ioctl_fw(struct file *file, unsigned long arg)
        if (instance->adprecovery != MEGASAS_HBA_OPERATIONAL) {
                spin_unlock_irqrestore(&instance->hba_lock, flags);
 
-               printk(KERN_ERR "megaraid_sas: timed out while"
+               dev_err(&instance->pdev->dev, "timed out while"
                        "waiting for HBA to recover\n");
                error = -ENODEV;
                goto out_up;
@@ -6224,10 +6215,10 @@ static int megasas_mgmt_ioctl_fw(struct file *file, unsigned long arg)
        spin_unlock_irqrestore(&instance->hba_lock, flags);
 
        error = megasas_mgmt_fw_ioctl(instance, user_ioc, ioc);
-      out_up:
+out_up:
        up(&instance->ioctl_sem);
 
-      out_kfree_ioc:
+out_kfree_ioc:
        kfree(ioc);
        return error;
 }
@@ -6275,7 +6266,7 @@ static int megasas_mgmt_ioctl_aen(struct file *file, unsigned long arg)
                spin_unlock_irqrestore(&instance->hba_lock, flags);
 
                if (!(i % MEGASAS_RESET_NOTICE_INTERVAL)) {
-                       printk(KERN_NOTICE "megasas: waiting for"
+                       dev_notice(&instance->pdev->dev, "waiting for"
                                "controller reset to finish\n");
                }
 
@@ -6285,8 +6276,8 @@ static int megasas_mgmt_ioctl_aen(struct file *file, unsigned long arg)
        spin_lock_irqsave(&instance->hba_lock, flags);
        if (instance->adprecovery != MEGASAS_HBA_OPERATIONAL) {
                spin_unlock_irqrestore(&instance->hba_lock, flags);
-               printk(KERN_ERR "megaraid_sas: timed out while waiting"
-                               "for HBA to recover.\n");
+               dev_err(&instance->pdev->dev, "timed out while waiting"
+                               "for HBA to recover\n");
                return -ENODEV;
        }
        spin_unlock_irqrestore(&instance->hba_lock, flags);
@@ -6462,7 +6453,8 @@ static ssize_t
 megasas_sysfs_set_dbg_lvl(struct device_driver *dd, const char *buf, size_t count)
 {
        int retval = count;
-       if(sscanf(buf,"%u",&megasas_dbg_lvl)<1){
+
+       if (sscanf(buf, "%u", &megasas_dbg_lvl) < 1) {
                printk(KERN_ERR "megasas: could not set dbg_lvl\n");
                retval = -EINVAL;
        }
@@ -6502,7 +6494,7 @@ megasas_aen_polling(struct work_struct *work)
                if (instance->adprecovery == MEGASAS_HBA_OPERATIONAL)
                        break;
                if (!(i % MEGASAS_RESET_NOTICE_INTERVAL)) {
-                       printk(KERN_NOTICE "megasas: %s waiting for "
+                       dev_notice(&instance->pdev->dev, "%s waiting for "
                               "controller reset to finish for scsi%d\n",
                               __func__, instance->host->host_no);
                }
@@ -6524,14 +6516,12 @@ megasas_aen_polling(struct work_struct *work)
                                pd_index =
                                (i * MEGASAS_MAX_DEV_PER_CHANNEL) + j;
 
-                               sdev1 =
-                               scsi_device_lookup(host, i, j, 0);
+                               sdev1 = scsi_device_lookup(host, i, j, 0);
 
                                if (instance->pd_list[pd_index].driveState
                                                == MR_PD_STATE_SYSTEM) {
-                                               if (!sdev1) {
+                                       if (!sdev1)
                                                scsi_add_device(host, i, j, 0);
-                                               }
 
                                        if (sdev1)
                                                scsi_device_put(sdev1);
@@ -6552,14 +6542,12 @@ megasas_aen_polling(struct work_struct *work)
                                pd_index =
                                (i * MEGASAS_MAX_DEV_PER_CHANNEL) + j;
 
-                               sdev1 =
-                               scsi_device_lookup(host, i, j, 0);
+                               sdev1 = scsi_device_lookup(host, i, j, 0);
 
                                if (instance->pd_list[pd_index].driveState
                                        == MR_PD_STATE_SYSTEM) {
-                                       if (sdev1) {
+                                       if (sdev1)
                                                scsi_device_put(sdev1);
-                                       }
                                } else {
                                        if (sdev1) {
                                                scsi_remove_device(sdev1);
@@ -6644,13 +6632,13 @@ megasas_aen_polling(struct work_struct *work)
                        break;
                }
        } else {
-               printk(KERN_ERR "invalid evt_detail!\n");
+               dev_err(&instance->pdev->dev, "invalid evt_detail!\n");
                kfree(ev);
                return;
        }
 
        if (doscan) {
-               printk(KERN_INFO "megaraid_sas: scanning for scsi%d...\n",
+               dev_info(&instance->pdev->dev, "scanning for scsi%d...\n",
                       instance->host->host_no);
                if (megasas_get_pd_list(instance) == 0) {
                        for (i = 0; i < MEGASAS_MAX_PD_CHANNELS; i++) {
@@ -6705,7 +6693,7 @@ megasas_aen_polling(struct work_struct *work)
                }
        }
 
-       if ( instance->aen_cmd != NULL ) {
+       if (instance->aen_cmd != NULL) {
                kfree(ev);
                return ;
        }
@@ -6722,7 +6710,7 @@ megasas_aen_polling(struct work_struct *work)
        mutex_unlock(&instance->aen_mutex);
 
        if (error)
-               printk(KERN_ERR "register aen failed error %x\n", error);
+               dev_err(&instance->pdev->dev, "register aen failed error %x\n", error);
 
        kfree(ev);
 }