drm/rockchip: vop: add vop full series of vop support
[firefly-linux-kernel-4.4.55.git] / drivers / gpu / drm / rockchip / rockchip_drm_vop.c
index d83bf87ba71e4f8dddf1ea8d31298fa1f45b21a5..c332a505538cb83f103d9e4c8f93025073388bc5 100644 (file)
 
 #include <linux/reset.h>
 #include <linux/delay.h>
+#include <linux/sort.h>
 
 #include "rockchip_drm_drv.h"
 #include "rockchip_drm_gem.h"
 #include "rockchip_drm_fb.h"
 #include "rockchip_drm_vop.h"
 
-#define __REG_SET_RELAXED(x, off, mask, shift, v) \
-               vop_mask_write_relaxed(x, off, (mask) << shift, (v) << shift)
-#define __REG_SET_NORMAL(x, off, mask, shift, v) \
-               vop_mask_write(x, off, (mask) << shift, (v) << shift)
+#define VOP_REG_SUPPORT(vop, reg) \
+               (!reg.major || (reg.major == VOP_MAJOR(vop->data->version) && \
+               reg.begin_minor <= VOP_MINOR(vop->data->version) && \
+               reg.end_minor >= VOP_MINOR(vop->data->version) && \
+               reg.mask))
 
-#define REG_SET(x, base, reg, v, mode) \
-               __REG_SET_##mode(x, base + reg.offset, reg.mask, reg.shift, v)
-#define REG_SET_MASK(x, base, reg, v, mode) \
-               __REG_SET_##mode(x, base + reg.offset, reg.mask, reg.shift, v)
+#define VOP_WIN_SUPPORT(vop, win, name) \
+               VOP_REG_SUPPORT(vop, win->phy->name)
+
+#define VOP_CTRL_SUPPORT(vop, win, name) \
+               VOP_REG_SUPPORT(vop, vop->data->ctrl->name)
+
+#define VOP_INTR_SUPPORT(vop, win, name) \
+               VOP_REG_SUPPORT(vop, vop->data->intr->name)
+
+#define __REG_SET(x, off, mask, shift, v, write_mask, relaxed) \
+               vop_mask_write(x, off, mask, shift, v, write_mask, relaxed)
+
+#define _REG_SET(vop, name, off, reg, mask, v, relaxed) \
+       do { \
+               if (VOP_REG_SUPPORT(vop, reg)) \
+                       __REG_SET(vop, off + reg.offset, mask, reg.shift, \
+                                 v, reg.write_mask, relaxed); \
+               else \
+                       dev_dbg(vop->dev, "Warning: not support "#name"\n"); \
+       } while(0)
+
+#define REG_SET(x, name, off, reg, v, relaxed) \
+               _REG_SET(x, name, off, reg, reg.mask, v, relaxed)
+#define REG_SET_MASK(x, name, off, reg, mask, v, relaxed) \
+               _REG_SET(x, name, off, reg, reg.mask & mask, v, relaxed)
 
 #define VOP_WIN_SET(x, win, name, v) \
-               REG_SET(x, win->base, win->phy->name, v, RELAXED)
+               REG_SET(x, name, win->offset, VOP_WIN_NAME(win, name), v, true)
 #define VOP_SCL_SET(x, win, name, v) \
-               REG_SET(x, win->base, win->phy->scl->name, v, RELAXED)
+               REG_SET(x, name, win->offset, win->phy->scl->name, v, true)
 #define VOP_SCL_SET_EXT(x, win, name, v) \
-               REG_SET(x, win->base, win->phy->scl->ext->name, v, RELAXED)
+               REG_SET(x, name, win->offset, win->phy->scl->ext->name, v, true)
+
 #define VOP_CTRL_SET(x, name, v) \
-               REG_SET(x, 0, (x)->data->ctrl->name, v, NORMAL)
+               REG_SET(x, name, 0, (x)->data->ctrl->name, v, false)
 
 #define VOP_INTR_GET(vop, name) \
                vop_read_reg(vop, 0, &vop->data->ctrl->name)
 
-#define VOP_INTR_SET(vop, name, v) \
-               REG_SET(vop, 0, vop->data->intr->name, v, NORMAL)
+#define VOP_INTR_SET(vop, name, mask, v) \
+               REG_SET_MASK(vop, name, 0, vop->data->intr->name, \
+                            mask, v, false)
+
 #define VOP_INTR_SET_TYPE(vop, name, type, v) \
        do { \
-               int i, reg = 0; \
+               int i, reg = 0, mask = 0; \
                for (i = 0; i < vop->data->intr->nintrs; i++) { \
-                       if (vop->data->intr->intrs[i] & type) \
+                       if (vop->data->intr->intrs[i] & type) \
                                reg |= (v) << i; \
+                               mask |= 1 << i; \
+                       } \
                } \
-               VOP_INTR_SET(vop, name, reg); \
+               VOP_INTR_SET(vop, name, mask, reg); \
        } while (0)
 #define VOP_INTR_GET_TYPE(vop, name, type) \
                vop_get_intr_type(vop, &vop->data->intr->name, type)
 
+#define VOP_CTRL_GET(x, name) \
+               vop_read_reg(x, 0, vop->data->ctrl->name)
+
 #define VOP_WIN_GET(x, win, name) \
-               vop_read_reg(x, win->base, &win->phy->name)
+               vop_read_reg(x, win->offset, &VOP_WIN_NAME(win, name))
+
+#define VOP_WIN_NAME(win, name) \
+               (vop_get_win_phy(win, &win->phy->name)->name)
 
 #define VOP_WIN_GET_YRGBADDR(vop, win) \
-               vop_readl(vop, win->base + win->phy->yrgb_mst.offset)
+               vop_readl(vop, win->offset + VOP_WIN_NAME(win, yrgb_mst).offset)
 
 #define to_vop(x) container_of(x, struct vop, crtc)
 #define to_vop_win(x) container_of(x, struct vop_win, base)
 #define to_vop_plane_state(x) container_of(x, struct vop_plane_state, base)
 
+struct vop_zpos {
+       int win_id;
+       int zpos;
+};
+
 struct vop_plane_state {
        struct drm_plane_state base;
        int format;
+       int zpos;
        struct drm_rect src;
        struct drm_rect dest;
        dma_addr_t yrgb_mst;
@@ -92,10 +132,19 @@ struct vop_plane_state {
 };
 
 struct vop_win {
+       struct vop_win *parent;
        struct drm_plane base;
-       const struct vop_win_data *data;
+
+       int win_id;
+       int area_id;
+       uint32_t offset;
+       enum drm_plane_type type;
+       const struct vop_win_phy *phy;
+       const uint32_t *data_formats;
+       uint32_t nformats;
        struct vop *vop;
 
+       struct drm_property *rotation_prop;
        struct vop_plane_state state;
 };
 
@@ -103,6 +152,7 @@ struct vop {
        struct drm_crtc crtc;
        struct device *dev;
        struct drm_device *drm_dev;
+       struct drm_property *plane_zpos_prop;
        bool is_enabled;
 
        /* mutex vsync_ work */
@@ -113,6 +163,7 @@ struct vop {
        struct drm_pending_vblank_event *event;
 
        const struct vop_data *data;
+       int num_wins;
 
        uint32_t *regsbak;
        void __iomem *regs;
@@ -158,27 +209,34 @@ static inline uint32_t vop_read_reg(struct vop *vop, uint32_t base,
 }
 
 static inline void vop_mask_write(struct vop *vop, uint32_t offset,
-                                 uint32_t mask, uint32_t v)
+                                 uint32_t mask, uint32_t shift, uint32_t v,
+                                 bool write_mask, bool relaxed)
 {
-       if (mask) {
+       if (!mask)
+               return;
+
+       if (write_mask) {
+               v = ((v & mask) << shift) | (mask << (shift + 16));
+       } else {
                uint32_t cached_val = vop->regsbak[offset >> 2];
 
-               cached_val = (cached_val & ~mask) | v;
-               writel(cached_val, vop->regs + offset);
-               vop->regsbak[offset >> 2] = cached_val;
+               v = (cached_val & ~(mask << shift)) | ((v & mask) << shift);
+               vop->regsbak[offset >> 2] = v;
        }
+
+       if (relaxed)
+               writel_relaxed(v, vop->regs + offset);
+       else
+               writel(v, vop->regs + offset);
 }
 
-static inline void vop_mask_write_relaxed(struct vop *vop, uint32_t offset,
-                                         uint32_t mask, uint32_t v)
+static inline const struct vop_win_phy *
+vop_get_win_phy(struct vop_win *win, const struct vop_reg *reg)
 {
-       if (mask) {
-               uint32_t cached_val = vop->regsbak[offset >> 2];
+       if (!reg->mask && win->parent)
+               return win->parent->phy;
 
-               cached_val = (cached_val & ~mask) | v;
-               writel_relaxed(cached_val, vop->regs + offset);
-               vop->regsbak[offset >> 2] = cached_val;
-       }
+       return win->phy;
 }
 
 static inline uint32_t vop_get_intr_type(struct vop *vop,
@@ -293,9 +351,9 @@ static uint16_t scl_vop_cal_scale(enum scale_mode mode, uint32_t src,
        return val;
 }
 
-static void scl_vop_cal_scl_fac(struct vop *vop, const struct vop_win_data *win,
-                            uint32_t src_w, uint32_t src_h, uint32_t dst_w,
-                            uint32_t dst_h, uint32_t pixel_format)
+static void scl_vop_cal_scl_fac(struct vop *vop, struct vop_win *win,
+                               uint32_t src_w, uint32_t src_h, uint32_t dst_w,
+                               uint32_t dst_h, uint32_t pixel_format)
 {
        uint16_t yrgb_hor_scl_mode, yrgb_ver_scl_mode;
        uint16_t cbcr_hor_scl_mode = SCALE_NONE;
@@ -308,7 +366,10 @@ static void scl_vop_cal_scl_fac(struct vop *vop, const struct vop_win_data *win,
        uint16_t vsu_mode;
        uint16_t lb_mode;
        uint32_t val;
-       int vskiplines;
+       int vskiplines = 0;
+
+       if (!win->phy->scl)
+               return;
 
        if (dst_w > 3840) {
                DRM_ERROR("Maximum destination width (3840) exceeded\n");
@@ -322,9 +383,9 @@ static void scl_vop_cal_scl_fac(struct vop *vop, const struct vop_win_data *win,
                            scl_cal_scale2(src_h, dst_h));
                if (is_yuv) {
                        VOP_SCL_SET(vop, win, scale_cbcr_x,
-                                   scl_cal_scale2(src_w, dst_w));
+                                   scl_cal_scale2(cbcr_src_w, dst_w));
                        VOP_SCL_SET(vop, win, scale_cbcr_y,
-                                   scl_cal_scale2(src_h, dst_h));
+                                   scl_cal_scale2(cbcr_src_h, dst_h));
                }
                return;
        }
@@ -432,12 +493,6 @@ static void vop_enable(struct drm_crtc *crtc)
        if (vop->is_enabled)
                return;
 
-       ret = pm_runtime_get_sync(vop->dev);
-       if (ret < 0) {
-               dev_err(vop->dev, "failed to get pm runtime: %d\n", ret);
-               return;
-       }
-
        ret = clk_enable(vop->hclk);
        if (ret < 0) {
                dev_err(vop->dev, "failed to enable hclk - %d\n", ret);
@@ -456,6 +511,12 @@ static void vop_enable(struct drm_crtc *crtc)
                goto err_disable_dclk;
        }
 
+       ret = pm_runtime_get_sync(vop->dev);
+       if (ret < 0) {
+               dev_err(vop->dev, "failed to get pm runtime: %d\n", ret);
+               return;
+       }
+
        /*
         * Slave iommu shares power, irq and clock with vop.  It was associated
         * automatically with this master device via common driver code.
@@ -497,10 +558,24 @@ err_disable_hclk:
 static void vop_crtc_disable(struct drm_crtc *crtc)
 {
        struct vop *vop = to_vop(crtc);
+       int i;
 
        if (!vop->is_enabled)
                return;
 
+       /*
+        * We need to make sure that all windows are disabled before we
+        * disable that crtc. Otherwise we might try to scan from a destroyed
+        * buffer later.
+        */
+       for (i = 0; i < vop->num_wins; i++) {
+               struct vop_win *win = &vop->win[i];
+
+               spin_lock(&vop->reg_lock);
+               VOP_WIN_SET(vop, win, enable, 0);
+               spin_unlock(&vop->reg_lock);
+       }
+
        drm_crtc_vblank_off(crtc);
 
        /*
@@ -532,10 +607,10 @@ static void vop_crtc_disable(struct drm_crtc *crtc)
         */
        rockchip_drm_dma_detach_device(vop->drm_dev, vop->dev);
 
+       pm_runtime_put(vop->dev);
        clk_disable(vop->dclk);
        clk_disable(vop->aclk);
        clk_disable(vop->hclk);
-       pm_runtime_put(vop->dev);
 }
 
 static void vop_plane_destroy(struct drm_plane *plane)
@@ -543,14 +618,30 @@ static void vop_plane_destroy(struct drm_plane *plane)
        drm_plane_cleanup(plane);
 }
 
+static int vop_plane_prepare_fb(struct drm_plane *plane,
+                               const struct drm_plane_state *new_state)
+{
+       if (plane->state->fb)
+               drm_framebuffer_reference(plane->state->fb);
+
+       return 0;
+}
+
+static void vop_plane_cleanup_fb(struct drm_plane *plane,
+                                const struct drm_plane_state *old_state)
+{
+       if (old_state->fb)
+               drm_framebuffer_unreference(old_state->fb);
+}
+
 static int vop_plane_atomic_check(struct drm_plane *plane,
                           struct drm_plane_state *state)
 {
        struct drm_crtc *crtc = state->crtc;
        struct drm_framebuffer *fb = state->fb;
-       struct vop_win *vop_win = to_vop_win(plane);
+       struct vop_win *win = to_vop_win(plane);
        struct vop_plane_state *vop_plane_state = to_vop_plane_state(state);
-       const struct vop_win_data *win = vop_win->data;
+       struct drm_crtc_state *crtc_state;
        bool visible;
        int ret;
        struct drm_rect *dest = &vop_plane_state->dest;
@@ -567,6 +658,11 @@ static int vop_plane_atomic_check(struct drm_plane *plane,
         */
        if (!crtc || !fb)
                goto out_disable;
+
+       crtc_state = drm_atomic_get_crtc_state(state->state, crtc);
+       if (IS_ERR(crtc_state))
+               return PTR_ERR(crtc_state);
+
        src->x1 = state->src_x;
        src->y1 = state->src_y;
        src->x2 = state->src_x + state->src_w;
@@ -578,8 +674,8 @@ static int vop_plane_atomic_check(struct drm_plane *plane,
 
        clip.x1 = 0;
        clip.y1 = 0;
-       clip.x2 = crtc->mode.hdisplay;
-       clip.y2 = crtc->mode.vdisplay;
+       clip.x2 = crtc_state->mode.hdisplay;
+       clip.y2 = crtc_state->mode.vdisplay;
 
        ret = drm_plane_helper_check_update(plane, crtc, state->fb,
                                            src, dest, &clip,
@@ -616,8 +712,7 @@ static void vop_plane_atomic_disable(struct drm_plane *plane,
                                     struct drm_plane_state *old_state)
 {
        struct vop_plane_state *vop_plane_state = to_vop_plane_state(old_state);
-       struct vop_win *vop_win = to_vop_win(plane);
-       const struct vop_win_data *win = vop_win->data;
+       struct vop_win *win = to_vop_win(plane);
        struct vop *vop = to_vop(old_state->crtc);
 
        if (!old_state->crtc)
@@ -637,9 +732,9 @@ static void vop_plane_atomic_update(struct drm_plane *plane,
 {
        struct drm_plane_state *state = plane->state;
        struct drm_crtc *crtc = state->crtc;
-       struct vop_win *vop_win = to_vop_win(plane);
+       struct vop_win *win = to_vop_win(plane);
        struct vop_plane_state *vop_plane_state = to_vop_plane_state(state);
-       const struct vop_win_data *win = vop_win->data;
+       struct rockchip_crtc_state *s = to_rockchip_crtc_state(crtc->state);
        struct vop *vop = to_vop(state->crtc);
        struct drm_framebuffer *fb = state->fb;
        unsigned int actual_w, actual_h;
@@ -651,6 +746,7 @@ static void vop_plane_atomic_update(struct drm_plane *plane,
        struct rockchip_gem_object *rk_obj, *rk_uv_obj;
        unsigned long offset;
        dma_addr_t dma_addr;
+       int ymirror, xmirror;
        uint32_t val;
        bool rb_swap;
 
@@ -683,11 +779,19 @@ static void vop_plane_atomic_update(struct drm_plane *plane,
        dsp_st = dsp_sty << 16 | (dsp_stx & 0xffff);
 
        offset = (src->x1 >> 16) * drm_format_plane_cpp(fb->pixel_format, 0);
-       offset += (src->y1 >> 16) * fb->pitches[0];
+       if (state->rotation & BIT(DRM_REFLECT_Y))
+               offset += ((src->y2 >> 16) - 1) * fb->pitches[0];
+       else
+               offset += (src->y1 >> 16) * fb->pitches[0];
        vop_plane_state->yrgb_mst = rk_obj->dma_addr + offset + fb->offsets[0];
 
+       ymirror = !!(state->rotation & BIT(DRM_REFLECT_Y));
+       xmirror = !!(state->rotation & BIT(DRM_REFLECT_X));
+
        spin_lock(&vop->reg_lock);
 
+       VOP_WIN_SET(vop, win, xmirror, xmirror);
+       VOP_WIN_SET(vop, win, ymirror, ymirror);
        VOP_WIN_SET(vop, win, format, vop_plane_state->format);
        VOP_WIN_SET(vop, win, yrgb_vir, fb->pitches[0] >> 2);
        VOP_WIN_SET(vop, win, yrgb_mst, vop_plane_state->yrgb_mst);
@@ -707,10 +811,9 @@ static void vop_plane_atomic_update(struct drm_plane *plane,
                VOP_WIN_SET(vop, win, uv_mst, dma_addr);
        }
 
-       if (win->phy->scl)
-               scl_vop_cal_scl_fac(vop, win, actual_w, actual_h,
-                                   drm_rect_width(dest), drm_rect_height(dest),
-                                   fb->pixel_format);
+       scl_vop_cal_scl_fac(vop, win, actual_w, actual_h,
+                           drm_rect_width(dest), drm_rect_height(dest),
+                           fb->pixel_format);
 
        VOP_WIN_SET(vop, win, act_info, act_info);
        VOP_WIN_SET(vop, win, dsp_info, dsp_info);
@@ -719,7 +822,8 @@ static void vop_plane_atomic_update(struct drm_plane *plane,
        rb_swap = has_rb_swapped(fb->pixel_format);
        VOP_WIN_SET(vop, win, rb_swap, rb_swap);
 
-       if (is_alpha_support(fb->pixel_format)) {
+       if (is_alpha_support(fb->pixel_format) &&
+           (s->dsp_layer_sel & 0x3) != win->win_id) {
                VOP_WIN_SET(vop, win, dst_alpha_ctl,
                            DST_FACTOR_M0(ALPHA_SRC_INVERSE));
                val = SRC_ALPHA_EN(1) | SRC_COLOR_M0(ALPHA_SRC_PRE_MUL) |
@@ -728,8 +832,11 @@ static void vop_plane_atomic_update(struct drm_plane *plane,
                        SRC_ALPHA_CAL_M0(ALPHA_NO_SATURATION) |
                        SRC_FACTOR_M0(ALPHA_ONE);
                VOP_WIN_SET(vop, win, src_alpha_ctl, val);
+               VOP_WIN_SET(vop, win, alpha_mode, 1);
+               VOP_WIN_SET(vop, win, alpha_en, 1);
        } else {
                VOP_WIN_SET(vop, win, src_alpha_ctl, SRC_ALPHA_EN(0));
+               VOP_WIN_SET(vop, win, alpha_en, 0);
        }
 
        VOP_WIN_SET(vop, win, enable, 1);
@@ -737,6 +844,8 @@ static void vop_plane_atomic_update(struct drm_plane *plane,
 }
 
 static const struct drm_plane_helper_funcs plane_helper_funcs = {
+       .prepare_fb = vop_plane_prepare_fb,
+       .cleanup_fb = vop_plane_cleanup_fb,
        .atomic_check = vop_plane_atomic_check,
        .atomic_update = vop_plane_atomic_update,
        .atomic_disable = vop_plane_atomic_disable,
@@ -744,6 +853,7 @@ static const struct drm_plane_helper_funcs plane_helper_funcs = {
 
 void vop_atomic_plane_reset(struct drm_plane *plane)
 {
+       struct vop_win *win = to_vop_win(plane);
        struct vop_plane_state *vop_plane_state =
                                        to_vop_plane_state(plane->state);
 
@@ -755,6 +865,7 @@ void vop_atomic_plane_reset(struct drm_plane *plane)
        if (!vop_plane_state)
                return;
 
+       vop_plane_state->zpos = win->win_id;
        plane->state = &vop_plane_state->base;
        plane->state->plane = plane;
 }
@@ -790,6 +901,50 @@ static void vop_atomic_plane_destroy_state(struct drm_plane *plane,
        kfree(vop_state);
 }
 
+static int vop_atomic_plane_set_property(struct drm_plane *plane,
+                                        struct drm_plane_state *state,
+                                        struct drm_property *property,
+                                        uint64_t val)
+{
+       struct vop_win *win = to_vop_win(plane);
+       struct vop_plane_state *plane_state = to_vop_plane_state(state);
+
+       if (property == win->vop->plane_zpos_prop) {
+               plane_state->zpos = val;
+               return 0;
+       }
+
+       if (property == win->rotation_prop) {
+               state->rotation = val;
+               return 0;
+       }
+
+       DRM_ERROR("failed to set vop plane property\n");
+       return -EINVAL;
+}
+
+static int vop_atomic_plane_get_property(struct drm_plane *plane,
+                                        const struct drm_plane_state *state,
+                                        struct drm_property *property,
+                                        uint64_t *val)
+{
+       struct vop_win *win = to_vop_win(plane);
+       struct vop_plane_state *plane_state = to_vop_plane_state(state);
+
+       if (property == win->vop->plane_zpos_prop) {
+               *val = plane_state->zpos;
+               return 0;
+       }
+
+       if (property == win->rotation_prop) {
+               *val = state->rotation;
+               return 0;
+       }
+
+       DRM_ERROR("failed to get vop plane property\n");
+       return -EINVAL;
+}
+
 static const struct drm_plane_funcs vop_plane_funcs = {
        .update_plane   = drm_atomic_helper_update_plane,
        .disable_plane  = drm_atomic_helper_disable_plane,
@@ -797,37 +952,10 @@ static const struct drm_plane_funcs vop_plane_funcs = {
        .reset = vop_atomic_plane_reset,
        .atomic_duplicate_state = vop_atomic_plane_duplicate_state,
        .atomic_destroy_state = vop_atomic_plane_destroy_state,
+       .atomic_set_property = vop_atomic_plane_set_property,
+       .atomic_get_property = vop_atomic_plane_get_property,
 };
 
-int rockchip_drm_crtc_mode_config(struct drm_crtc *crtc,
-                                 int connector_type,
-                                 int out_mode)
-{
-       struct vop *vop = to_vop(crtc);
-
-       if (WARN_ON(!vop->is_enabled))
-               return -EINVAL;
-
-       switch (connector_type) {
-       case DRM_MODE_CONNECTOR_LVDS:
-               VOP_CTRL_SET(vop, rgb_en, 1);
-               break;
-       case DRM_MODE_CONNECTOR_eDP:
-               VOP_CTRL_SET(vop, edp_en, 1);
-               break;
-       case DRM_MODE_CONNECTOR_HDMIA:
-               VOP_CTRL_SET(vop, hdmi_en, 1);
-               break;
-       default:
-               DRM_ERROR("unsupport connector_type[%d]\n", connector_type);
-               return -EINVAL;
-       };
-       VOP_CTRL_SET(vop, out_mode, out_mode);
-
-       return 0;
-}
-EXPORT_SYMBOL_GPL(rockchip_drm_crtc_mode_config);
-
 static int vop_crtc_enable_vblank(struct drm_crtc *crtc)
 {
        struct vop *vop = to_vop(crtc);
@@ -868,18 +996,40 @@ static void vop_crtc_wait_for_update(struct drm_crtc *crtc)
        WARN_ON(!wait_for_completion_timeout(&vop->wait_update_complete, 100));
 }
 
+static void vop_crtc_cancel_pending_vblank(struct drm_crtc *crtc,
+                                          struct drm_file *file_priv)
+{
+       struct drm_device *drm = crtc->dev;
+       struct vop *vop = to_vop(crtc);
+       struct drm_pending_vblank_event *e;
+       unsigned long flags;
+
+       spin_lock_irqsave(&drm->event_lock, flags);
+       e = vop->event;
+       if (e && e->base.file_priv == file_priv) {
+               vop->event = NULL;
+
+               e->base.destroy(&e->base);
+               file_priv->event_space += sizeof(e->event);
+       }
+       spin_unlock_irqrestore(&drm->event_lock, flags);
+}
+
 static const struct rockchip_crtc_funcs private_crtc_funcs = {
        .enable_vblank = vop_crtc_enable_vblank,
        .disable_vblank = vop_crtc_disable_vblank,
        .wait_for_update = vop_crtc_wait_for_update,
+       .cancel_pending_vblank = vop_crtc_cancel_pending_vblank,
 };
 
 static bool vop_crtc_mode_fixup(struct drm_crtc *crtc,
                                const struct drm_display_mode *mode,
                                struct drm_display_mode *adjusted_mode)
 {
-       if (adjusted_mode->htotal == 0 || adjusted_mode->vtotal == 0)
-               return false;
+       struct vop *vop = to_vop(crtc);
+
+       adjusted_mode->clock =
+               clk_round_rate(vop->dclk, mode->clock * 1000) / 1000;
 
        return true;
 }
@@ -887,6 +1037,8 @@ static bool vop_crtc_mode_fixup(struct drm_crtc *crtc,
 static void vop_crtc_enable(struct drm_crtc *crtc)
 {
        struct vop *vop = to_vop(crtc);
+       const struct vop_data *vop_data = vop->data;
+       struct rockchip_crtc_state *s = to_rockchip_crtc_state(crtc->state);
        struct drm_display_mode *adjusted_mode = &crtc->state->adjusted_mode;
        u16 hsync_len = adjusted_mode->hsync_end - adjusted_mode->hsync_start;
        u16 hdisplay = adjusted_mode->hdisplay;
@@ -941,6 +1093,32 @@ static void vop_crtc_enable(struct drm_crtc *crtc)
        val |= (adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC) ? 0 : 1;
        val |= (adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC) ? 0 : (1 << 1);
        VOP_CTRL_SET(vop, pin_pol, val);
+       switch (s->output_type) {
+       case DRM_MODE_CONNECTOR_LVDS:
+               VOP_CTRL_SET(vop, rgb_en, 1);
+               VOP_CTRL_SET(vop, rgb_pin_pol, val);
+               break;
+       case DRM_MODE_CONNECTOR_eDP:
+               VOP_CTRL_SET(vop, edp_en, 1);
+               VOP_CTRL_SET(vop, edp_pin_pol, val);
+               break;
+       case DRM_MODE_CONNECTOR_HDMIA:
+               VOP_CTRL_SET(vop, hdmi_en, 1);
+               VOP_CTRL_SET(vop, hdmi_pin_pol, val);
+               break;
+       case DRM_MODE_CONNECTOR_DSI:
+               VOP_CTRL_SET(vop, mipi_en, 1);
+               VOP_CTRL_SET(vop, mipi_pin_pol, val);
+               break;
+       default:
+               DRM_ERROR("unsupport connector_type[%d]\n", s->output_type);
+       }
+
+       if (s->output_mode == ROCKCHIP_OUT_MODE_AAAA &&
+           !(vop_data->feature & VOP_FEATURE_OUTPUT_10BIT))
+               s->output_mode = ROCKCHIP_OUT_MODE_P888;
+
+       VOP_CTRL_SET(vop, out_mode, s->output_mode);
 
        VOP_CTRL_SET(vop, htotal_pw, (htotal << 16) | hsync_len);
        val = hact_st << 16;
@@ -959,9 +1137,90 @@ static void vop_crtc_enable(struct drm_crtc *crtc)
        VOP_CTRL_SET(vop, standby, 0);
 }
 
+static int vop_zpos_cmp(const void *a, const void *b)
+{
+       struct vop_zpos *pa = (struct vop_zpos *)a;
+       struct vop_zpos *pb = (struct vop_zpos *)b;
+
+       return pa->zpos - pb->zpos;
+}
+
+static int vop_crtc_atomic_check(struct drm_crtc *crtc,
+                                struct drm_crtc_state *crtc_state)
+{
+       struct drm_atomic_state *state = crtc_state->state;
+       struct rockchip_crtc_state *s = to_rockchip_crtc_state(crtc_state);
+       struct vop *vop = to_vop(crtc);
+       const struct vop_data *vop_data = vop->data;
+       struct drm_plane *plane;
+       struct drm_plane_state *pstate;
+       struct vop_plane_state *plane_state;
+       struct vop_zpos *pzpos;
+       int dsp_layer_sel = 0;
+       int i, j, cnt = 0, ret = 0;
+
+       pzpos = kmalloc_array(vop_data->win_size, sizeof(*pzpos), GFP_KERNEL);
+       if (!pzpos)
+               return -ENOMEM;
+
+       for (i = 0; i < vop_data->win_size; i++) {
+               const struct vop_win_data *win_data = &vop_data->win[i];
+               struct vop_win *win;
+
+               if (!win_data->phy)
+                       continue;
+
+               for (j = 0; j < vop->num_wins; j++) {
+                       win = &vop->win[j];
+
+                       if (win->win_id == i && !win->area_id)
+                               break;
+               }
+               if (WARN_ON(j >= vop->num_wins)) {
+                       ret = -EINVAL;
+                       goto err_free_pzpos;
+               }
+
+               plane = &win->base;
+               pstate = state->plane_states[drm_plane_index(plane)];
+               /*
+                * plane might not have changed, in which case take
+                * current state:
+                */
+               if (!pstate)
+                       pstate = plane->state;
+               plane_state = to_vop_plane_state(pstate);
+               pzpos[cnt].zpos = plane_state->zpos;
+               pzpos[cnt++].win_id = win->win_id;
+       }
+
+       sort(pzpos, cnt, sizeof(pzpos[0]), vop_zpos_cmp, NULL);
+
+       for (i = 0, cnt = 0; i < vop_data->win_size; i++) {
+               const struct vop_win_data *win_data = &vop_data->win[i];
+               int shift = i * 2;
+
+               if (win_data->phy) {
+                       struct vop_zpos *zpos = &pzpos[cnt++];
+
+                       dsp_layer_sel |= zpos->win_id << shift;
+               } else {
+                       dsp_layer_sel |= i << shift;
+               }
+       }
+
+       s->dsp_layer_sel = dsp_layer_sel;
+
+err_free_pzpos:
+       kfree(pzpos);
+       return ret;
+}
+
 static void vop_crtc_atomic_flush(struct drm_crtc *crtc,
                                  struct drm_crtc_state *old_crtc_state)
 {
+       struct rockchip_crtc_state *s =
+                       to_rockchip_crtc_state(crtc->state);
        struct vop *vop = to_vop(crtc);
 
        if (WARN_ON(!vop->is_enabled))
@@ -969,6 +1228,7 @@ static void vop_crtc_atomic_flush(struct drm_crtc *crtc,
 
        spin_lock(&vop->reg_lock);
 
+       VOP_CTRL_SET(vop, dsp_layer_sel, s->dsp_layer_sel);
        vop_cfg_done(vop);
 
        spin_unlock(&vop->reg_lock);
@@ -991,6 +1251,7 @@ static const struct drm_crtc_helper_funcs vop_crtc_helper_funcs = {
        .enable = vop_crtc_enable,
        .disable = vop_crtc_disable,
        .mode_fixup = vop_crtc_mode_fixup,
+       .atomic_check = vop_crtc_atomic_check,
        .atomic_flush = vop_crtc_atomic_flush,
        .atomic_begin = vop_crtc_atomic_begin,
 };
@@ -1000,13 +1261,34 @@ static void vop_crtc_destroy(struct drm_crtc *crtc)
        drm_crtc_cleanup(crtc);
 }
 
+static struct drm_crtc_state *vop_crtc_duplicate_state(struct drm_crtc *crtc)
+{
+       struct rockchip_crtc_state *rockchip_state;
+
+       rockchip_state = kzalloc(sizeof(*rockchip_state), GFP_KERNEL);
+       if (!rockchip_state)
+               return NULL;
+
+       __drm_atomic_helper_crtc_duplicate_state(crtc, &rockchip_state->base);
+       return &rockchip_state->base;
+}
+
+static void vop_crtc_destroy_state(struct drm_crtc *crtc,
+                                  struct drm_crtc_state *state)
+{
+       struct rockchip_crtc_state *s = to_rockchip_crtc_state(state);
+
+       __drm_atomic_helper_crtc_destroy_state(crtc, &s->base);
+       kfree(s);
+}
+
 static const struct drm_crtc_funcs vop_crtc_funcs = {
        .set_config = drm_atomic_helper_set_config,
        .page_flip = drm_atomic_helper_page_flip,
        .destroy = vop_crtc_destroy,
        .reset = drm_atomic_helper_crtc_reset,
-       .atomic_duplicate_state = drm_atomic_helper_crtc_duplicate_state,
-       .atomic_destroy_state = drm_atomic_helper_crtc_destroy_state,
+       .atomic_duplicate_state = vop_crtc_duplicate_state,
+       .atomic_destroy_state = vop_crtc_destroy_state,
 };
 
 static bool vop_win_pending_is_complete(struct vop_win *vop_win)
@@ -1016,9 +1298,9 @@ static bool vop_win_pending_is_complete(struct vop_win *vop_win)
        dma_addr_t yrgb_mst;
 
        if (!state->enable)
-               return VOP_WIN_GET(vop_win->vop, vop_win->data, enable) == 0;
+               return VOP_WIN_GET(vop_win->vop, vop_win, enable) == 0;
 
-       yrgb_mst = VOP_WIN_GET_YRGBADDR(vop_win->vop, vop_win->data);
+       yrgb_mst = VOP_WIN_GET_YRGBADDR(vop_win->vop, vop_win);
 
        return yrgb_mst == state->yrgb_mst;
 }
@@ -1030,7 +1312,7 @@ static void vop_handle_vblank(struct vop *vop)
        unsigned long flags;
        int i;
 
-       for (i = 0; i < vop->data->win_size; i++) {
+       for (i = 0; i < vop->num_wins; i++) {
                if (!vop_win_pending_is_complete(&vop->win[i]))
                        return;
        }
@@ -1093,12 +1375,55 @@ static irqreturn_t vop_isr(int irq, void *data)
        return ret;
 }
 
+static int vop_plane_init(struct vop *vop, struct vop_win *win,
+                         unsigned long possible_crtcs)
+{
+       struct drm_plane *share = NULL;
+       unsigned int rotations = 0;
+       struct drm_property *prop;
+       int ret;
+
+       if (win->parent)
+               share = &win->parent->base;
+
+       ret = drm_share_plane_init(vop->drm_dev, &win->base, share,
+                                  possible_crtcs, &vop_plane_funcs,
+                                  win->data_formats, win->nformats, win->type);
+       if (ret) {
+               DRM_ERROR("failed to initialize plane\n");
+               return ret;
+       }
+       drm_plane_helper_add(&win->base, &plane_helper_funcs);
+       drm_object_attach_property(&win->base.base,
+                                  vop->plane_zpos_prop, win->win_id);
+
+       if (VOP_WIN_SUPPORT(vop, win, xmirror))
+               rotations |= BIT(DRM_REFLECT_X);
+
+       if (VOP_WIN_SUPPORT(vop, win, ymirror))
+               rotations |= BIT(DRM_REFLECT_Y);
+
+       if (rotations) {
+               rotations |= BIT(DRM_ROTATE_0);
+               prop = drm_mode_create_rotation_property(vop->drm_dev,
+                                                        rotations);
+               if (!prop) {
+                       DRM_ERROR("failed to create zpos property\n");
+                       return -EINVAL;
+               }
+               drm_object_attach_property(&win->base.base, prop,
+                                          BIT(DRM_ROTATE_0));
+               win->rotation_prop = prop;
+       }
+
+       return 0;
+}
+
 static int vop_create_crtc(struct vop *vop)
 {
-       const struct vop_data *vop_data = vop->data;
        struct device *dev = vop->dev;
        struct drm_device *drm_dev = vop->drm_dev;
-       struct drm_plane *primary = NULL, *cursor = NULL, *plane;
+       struct drm_plane *primary = NULL, *cursor = NULL, *plane, *tmp;
        struct drm_crtc *crtc = &vop->crtc;
        struct device_node *port;
        int ret;
@@ -1109,36 +1434,29 @@ static int vop_create_crtc(struct vop *vop)
         * to pass them to drm_crtc_init_with_planes, which sets the
         * "possible_crtcs" to the newly initialized crtc.
         */
-       for (i = 0; i < vop_data->win_size; i++) {
-               struct vop_win *vop_win = &vop->win[i];
-               const struct vop_win_data *win_data = vop_win->data;
+       for (i = 0; i < vop->num_wins; i++) {
+               struct vop_win *win = &vop->win[i];
 
-               if (win_data->type != DRM_PLANE_TYPE_PRIMARY &&
-                   win_data->type != DRM_PLANE_TYPE_CURSOR)
+               if (win->type != DRM_PLANE_TYPE_PRIMARY &&
+                   win->type != DRM_PLANE_TYPE_CURSOR)
                        continue;
 
-               ret = drm_universal_plane_init(vop->drm_dev, &vop_win->base,
-                                              0, &vop_plane_funcs,
-                                              win_data->phy->data_formats,
-                                              win_data->phy->nformats,
-                                              win_data->type, NULL);
-               if (ret) {
-                       DRM_ERROR("failed to initialize plane\n");
+               ret = vop_plane_init(vop, win, 0);
+               if (ret)
                        goto err_cleanup_planes;
-               }
 
-               plane = &vop_win->base;
-               drm_plane_helper_add(plane, &plane_helper_funcs);
+               plane = &win->base;
                if (plane->type == DRM_PLANE_TYPE_PRIMARY)
                        primary = plane;
                else if (plane->type == DRM_PLANE_TYPE_CURSOR)
                        cursor = plane;
+
        }
 
        ret = drm_crtc_init_with_planes(drm_dev, crtc, primary, cursor,
                                        &vop_crtc_funcs, NULL);
        if (ret)
-               return ret;
+               goto err_cleanup_planes;
 
        drm_crtc_helper_add(crtc, &vop_crtc_helper_funcs);
 
@@ -1146,31 +1464,23 @@ static int vop_create_crtc(struct vop *vop)
         * Create drm_planes for overlay windows with possible_crtcs restricted
         * to the newly created crtc.
         */
-       for (i = 0; i < vop_data->win_size; i++) {
-               struct vop_win *vop_win = &vop->win[i];
-               const struct vop_win_data *win_data = vop_win->data;
+       for (i = 0; i < vop->num_wins; i++) {
+               struct vop_win *win = &vop->win[i];
                unsigned long possible_crtcs = 1 << drm_crtc_index(crtc);
 
-               if (win_data->type != DRM_PLANE_TYPE_OVERLAY)
+               if (win->type != DRM_PLANE_TYPE_OVERLAY)
                        continue;
 
-               ret = drm_universal_plane_init(vop->drm_dev, &vop_win->base,
-                                              possible_crtcs,
-                                              &vop_plane_funcs,
-                                              win_data->phy->data_formats,
-                                              win_data->phy->nformats,
-                                              win_data->type, NULL);
-               if (ret) {
-                       DRM_ERROR("failed to initialize overlay plane\n");
+               ret = vop_plane_init(vop, win, possible_crtcs);
+               if (ret)
                        goto err_cleanup_crtc;
-               }
-               drm_plane_helper_add(&vop_win->base, &plane_helper_funcs);
        }
 
        port = of_get_child_by_name(dev->of_node, "port");
        if (!port) {
                DRM_ERROR("no port node found in %s\n",
                          dev->of_node->full_name);
+               ret = -ENOENT;
                goto err_cleanup_crtc;
        }
 
@@ -1184,7 +1494,8 @@ static int vop_create_crtc(struct vop *vop)
 err_cleanup_crtc:
        drm_crtc_cleanup(crtc);
 err_cleanup_planes:
-       list_for_each_entry(plane, &drm_dev->mode_config.plane_list, head)
+       list_for_each_entry_safe(plane, tmp, &drm_dev->mode_config.plane_list,
+                                head)
                drm_plane_cleanup(plane);
        return ret;
 }
@@ -1192,16 +1503,33 @@ err_cleanup_planes:
 static void vop_destroy_crtc(struct vop *vop)
 {
        struct drm_crtc *crtc = &vop->crtc;
+       struct drm_device *drm_dev = vop->drm_dev;
+       struct drm_plane *plane, *tmp;
 
        rockchip_unregister_crtc_funcs(crtc);
        of_node_put(crtc->port);
+
+       /*
+        * We need to cleanup the planes now.  Why?
+        *
+        * The planes are "&vop->win[i].base".  That means the memory is
+        * all part of the big "struct vop" chunk of memory.  That memory
+        * was devm allocated and associated with this component.  We need to
+        * free it ourselves before vop_unbind() finishes.
+        */
+       list_for_each_entry_safe(plane, tmp, &drm_dev->mode_config.plane_list,
+                                head)
+               vop_plane_destroy(plane);
+
+       /*
+        * Destroy CRTC after vop_plane_destroy() since vop_disable_plane()
+        * references the CRTC.
+        */
        drm_crtc_cleanup(crtc);
 }
 
 static int vop_initial(struct vop *vop)
 {
-       const struct vop_data *vop_data = vop->data;
-       const struct vop_reg_data *init_table = vop_data->init_table;
        struct reset_control *ahb_rst;
        int i, ret;
 
@@ -1255,13 +1583,12 @@ static int vop_initial(struct vop *vop)
 
        memcpy(vop->regsbak, vop->regs, vop->len);
 
-       for (i = 0; i < vop_data->table_size; i++)
-               vop_writel(vop, init_table[i].offset, init_table[i].value);
+       VOP_CTRL_SET(vop, global_regdone_en, 1);
 
-       for (i = 0; i < vop_data->win_size; i++) {
-               const struct vop_win_data *win = &vop_data->win[i];
+       for (i = 0; i < vop->num_wins; i++) {
+               struct vop_win *win = &vop->win[i];
 
-               VOP_WIN_SET(vop, win, enable, 0);
+               VOP_WIN_SET(vop, win, gate, 1);
        }
 
        vop_cfg_done(vop);
@@ -1298,18 +1625,58 @@ err_unprepare_dclk:
 /*
  * Initialize the vop->win array elements.
  */
-static void vop_win_init(struct vop *vop)
+static int vop_win_init(struct vop *vop)
 {
        const struct vop_data *vop_data = vop->data;
-       unsigned int i;
+       unsigned int i, j;
+       unsigned int num_wins = 0;
+       struct drm_property *prop;
 
        for (i = 0; i < vop_data->win_size; i++) {
-               struct vop_win *vop_win = &vop->win[i];
+               struct vop_win *vop_win = &vop->win[num_wins];
                const struct vop_win_data *win_data = &vop_data->win[i];
 
-               vop_win->data = win_data;
+               if (!win_data->phy)
+                       continue;
+
+               vop_win->phy = win_data->phy;
+               vop_win->offset = win_data->base;
+               vop_win->type = win_data->type;
+               vop_win->data_formats = win_data->phy->data_formats;
+               vop_win->nformats = win_data->phy->nformats;
                vop_win->vop = vop;
+               vop_win->win_id = i;
+               vop_win->area_id = 0;
+               num_wins++;
+
+               for (j = 0; j < win_data->area_size; j++) {
+                       struct vop_win *vop_area = &vop->win[num_wins];
+                       const struct vop_win_phy *area = win_data->area[j];
+
+                       vop_area->parent = vop_win;
+                       vop_area->offset = vop_win->offset;
+                       vop_area->phy = area;
+                       vop_area->type = DRM_PLANE_TYPE_OVERLAY;
+                       vop_area->data_formats = vop_win->data_formats;
+                       vop_area->nformats = vop_win->nformats;
+                       vop_area->vop = vop;
+                       vop_area->win_id = i;
+                       vop_area->area_id = j;
+                       num_wins++;
+               }
        }
+
+       vop->num_wins = num_wins;
+
+       prop = drm_property_create_range(vop->drm_dev, DRM_MODE_PROP_ATOMIC,
+                                        "ZPOS", 0, vop->data->win_size);
+       if (!prop) {
+               DRM_ERROR("failed to create zpos property\n");
+               return -EINVAL;
+       }
+       vop->plane_zpos_prop = prop;
+
+       return 0;
 }
 
 static int vop_bind(struct device *dev, struct device *master, void *data)
@@ -1320,14 +1687,21 @@ static int vop_bind(struct device *dev, struct device *master, void *data)
        struct vop *vop;
        struct resource *res;
        size_t alloc_size;
-       int ret, irq;
+       int ret, irq, i;
+       int num_wins = 0;
 
        vop_data = of_device_get_match_data(dev);
        if (!vop_data)
                return -ENODEV;
 
+       for (i = 0; i < vop_data->win_size; i++) {
+               const struct vop_win_data *win_data = &vop_data->win[i];
+
+               num_wins += win_data->area_size + 1;
+       }
+
        /* Allocate vop struct and its vop_win array */
-       alloc_size = sizeof(*vop) + sizeof(*vop->win) * vop_data->win_size;
+       alloc_size = sizeof(*vop) + sizeof(*vop->win) * num_wins;
        vop = devm_kzalloc(dev, alloc_size, GFP_KERNEL);
        if (!vop)
                return -ENOMEM;
@@ -1335,9 +1709,12 @@ static int vop_bind(struct device *dev, struct device *master, void *data)
        vop->dev = dev;
        vop->data = vop_data;
        vop->drm_dev = drm_dev;
+       vop->num_wins = num_wins;
        dev_set_drvdata(dev, vop);
 
-       vop_win_init(vop);
+       ret = vop_win_init(vop);
+       if (ret)
+               return ret;
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        vop->len = resource_size(res);
@@ -1395,3 +1772,4 @@ const struct component_ops vop_component_ops = {
        .bind = vop_bind,
        .unbind = vop_unbind,
 };
+EXPORT_SYMBOL_GPL(vop_component_ops);