//$$CDS-header$$
-#ifndef __CDS_INTRUSIVE_MICHAEL_LIST_RCU_H
-#define __CDS_INTRUSIVE_MICHAEL_LIST_RCU_H
+#ifndef CDSLIB_INTRUSIVE_MICHAEL_LIST_RCU_H
+#define CDSLIB_INTRUSIVE_MICHAEL_LIST_RCU_H
#include <cds/intrusive/details/michael_list_base.h>
#include <cds/urcu/details/check_deadlock.h>
#include <cds/details/binary_functor_wrapper.h>
+#include <cds/details/make_const_type.h>
#include <cds/urcu/exempt_ptr.h>
+#include <cds/urcu/raw_ptr.h>
namespace cds { namespace intrusive {
+ //@cond
+ namespace michael_list {
+
+ /// Node specialization for uRCU
+ template <class RCU, typename Tag>
+ struct node< cds::urcu::gc< RCU >, Tag >
+ {
+ typedef cds::urcu::gc< RCU > gc; ///< Garbage collector
+ typedef Tag tag; ///< tag
+
+ typedef cds::details::marked_ptr<node, 1> marked_ptr ; ///< marked pointer
+ typedef typename gc::template atomic_marked_ptr< marked_ptr> atomic_marked_ptr ; ///< atomic marked pointer specific for GC
+
+ atomic_marked_ptr m_pNext ; ///< pointer to the next node in the container
+ node * m_pDelChain; ///< Deleted node chain (local for a thread)
+
+ CDS_CONSTEXPR node() CDS_NOEXCEPT
+ : m_pNext( nullptr )
+ , m_pDelChain( nullptr )
+ {}
+ };
+ } // namespace michael_list
+ //@endcond
+
/// Michael's lock-free ordered single-linked list (template specialization for \ref cds_urcu_desc "RCU")
/** @ingroup cds_intrusive_list
\anchor cds_intrusive_MichaelList_rcu
- \p RCU - one of \ref cds_urcu_gc "RCU type"
- \p T - type to be stored in the list; the type \p T should be based on (or has a member of type)
cds::intrusive::micheal_list::node
- - \p Traits - type traits. See michael_list::type_traits for explanation.
-
- It is possible to declare option-based list with \p %cds::intrusive::michael_list::make_traits metafunction istead of \p Traits template
- argument. Template argument list \p Options of cds::intrusive::michael_list::make_traits metafunction are:
- - opt::hook - hook used. Possible values are: michael_list::base_hook, michael_list::member_hook, michael_list::traits_hook.
- If the option is not specified, <tt>michael_list::base_hook<></tt> is used.
- - opt::compare - key comparison functor. No default functor is provided.
- If the option is not specified, the opt::less is used.
- - opt::less - specifies binary predicate used for key comparison. Default is \p std::less<T>.
- - opt::disposer - the functor used for dispose removed items. Default is opt::v::empty_disposer
- - opt::rcu_check_deadlock - a deadlock checking policy. Default is opt::v::rcu_throw_deadlock
- - opt::item_counter - the type of item counting feature. Default is \ref atomicity::empty_item_counter
- - opt::memory_model - C++ memory ordering model. Can be opt::v::relaxed_ordering (relaxed memory model, the default)
- or opt::v::sequential_consistent (sequentially consisnent memory model).
+ - \p Traits - type traits. See \p michael_list::traits for explanation. It is possible to declare option-based
+ list with \p cds::intrusive::michael_list::make_traits metafunction,
+ see \ref cds_intrusive_MichaelList_hp "here" for explanations.
\par Usage
Before including <tt><cds/intrusive/michael_list_rcu.h></tt> you should include appropriate RCU header file,
typedef cds::intrusive::MichaelList<cds::urcu::gc< cds::urcu::general_buffered<> >, Foo > rcu_michael_list;
\endcode
*/
- template < typename RCU, typename T, class Traits >
+ template < typename RCU, typename T,
+#ifdef CDS_DOXYGEN_INVOKED
+ class Traits = michael_list::traits
+#else
+ class Traits
+#endif
+ >
class MichaelList<cds::urcu::gc<RCU>, T, Traits>
{
public:
- typedef T value_type ; ///< type of value stored in the queue
- typedef Traits options ; ///< Traits template parameter
+ typedef T value_type; ///< type of value stored in the list
+ typedef Traits traits; ///< Traits template parameter
- typedef typename options::hook hook ; ///< hook type
- typedef typename hook::node_type node_type ; ///< node type
+ typedef typename traits::hook hook; ///< hook type
+ typedef typename hook::node_type node_type; ///< node type
# ifdef CDS_DOXYGEN_INVOKED
typedef implementation_defined key_comparator ; ///< key comparison functor based on opt::compare and opt::less option setter.
# else
- typedef typename opt::details::make_comparator< value_type, options >::type key_comparator;
+ typedef typename opt::details::make_comparator< value_type, traits >::type key_comparator;
# endif
- typedef typename options::disposer disposer ; ///< disposer used
+ typedef typename traits::disposer disposer; ///< disposer used
typedef typename get_node_traits< value_type, node_type, hook>::type node_traits ; ///< node traits
- typedef typename michael_list::get_link_checker< node_type, options::link_checker >::type link_checker ; ///< link checker
+ typedef typename michael_list::get_link_checker< node_type, traits::link_checker >::type link_checker; ///< link checker
- typedef cds::urcu::gc<RCU> gc ; ///< RCU schema
- typedef typename options::back_off back_off ; ///< back-off strategy
- typedef typename options::item_counter item_counter; ///< Item counting policy used
- typedef typename options::memory_model memory_model; ///< Memory ordering. See cds::opt::memory_model option
- typedef typename options::rcu_check_deadlock rcu_check_deadlock ; ///< Deadlock checking policy
+ typedef cds::urcu::gc<RCU> gc; ///< RCU schema
+ typedef typename traits::back_off back_off; ///< back-off strategy
+ typedef typename traits::item_counter item_counter; ///< Item counting policy used
+ typedef typename traits::memory_model memory_model; ///< Memory ordering. See cds::opt::memory_model option
+ typedef typename traits::rcu_check_deadlock rcu_check_deadlock; ///< Deadlock checking policy
typedef typename gc::scoped_lock rcu_lock ; ///< RCU scoped lock
- static CDS_CONSTEXPR const bool c_bExtractLockExternal = true; ///< Group of \p extract_xxx functions require external locking
+ static CDS_CONSTEXPR const bool c_bExtractLockExternal = false; ///< Group of \p extract_xxx functions do not require external locking
//@cond
- // Rebind options (split-list support)
+ // Rebind traits (split-list support)
template <typename... Options>
- struct rebind_options {
+ struct rebind_traits {
typedef MichaelList<
gc
, value_type
- , typename cds::opt::make_options< options, Options...>::type
+ , typename cds::opt::make_options< traits, Options...>::type
> type;
};
//@endcond
atomic_node_ptr m_pHead ; ///< Head pointer
item_counter m_ItemCounter ; ///< Item counter
+ protected:
//@cond
- /// Position pointer for item search
- struct position {
- atomic_node_ptr * pPrev ; ///< Previous node
- node_type * pCur ; ///< Current node
- node_type * pNext ; ///< Next node
+ enum erase_node_mask
+ {
+ erase_mask = 1,
+ extract_mask = 3
};
typedef cds::urcu::details::check_deadlock_policy< gc, rcu_check_deadlock> check_deadlock_policy;
static void clear_links( node_type * pNode )
{
pNode->m_pNext.store( marked_node_ptr(), memory_model::memory_order_relaxed );
+ pNode->m_pDelChain = nullptr;
}
struct clear_and_dispose {
disposer()( p );
}
};
- //@endcond
-
- public:
- typedef cds::urcu::exempt_ptr< gc, value_type, value_type, clear_and_dispose, void > exempt_ptr ; ///< pointer to extracted node
-
- protected:
- //@cond
static void dispose_node( node_type * pNode )
{
gc::template retire_ptr<clear_and_dispose>( node_traits::to_value_ptr( *pNode ) );
}
+ static void dispose_chain( node_type * pChain )
+ {
+ if ( pChain ) {
+ assert( !gc::is_locked() );
+
+ auto f = [&pChain]() -> cds::urcu::retired_ptr {
+ node_type * p = pChain;
+ pChain = p->m_pDelChain;
+ return cds::urcu::make_retired_ptr<clear_and_dispose>( node_traits::to_value_ptr( p ));
+ };
+ gc::batch_retire(std::ref(f));
+ }
+ }
+
+ /// Position pointer for item search
+ struct position {
+ atomic_node_ptr * pPrev ; ///< Previous node
+ node_type * pCur ; ///< Current node
+ node_type * pNext ; ///< Next node
+
+ atomic_node_ptr& refHead;
+ node_type * pDelChain; ///< Head of deleted node chain
+
+ position( atomic_node_ptr& head )
+ : refHead( head )
+ , pDelChain( nullptr )
+ {}
+
+ ~position()
+ {
+ dispose_chain( pDelChain );
+ }
+ };
+
+ //@endcond
+
+ public:
+ using exempt_ptr = cds::urcu::exempt_ptr< gc, value_type, value_type, clear_and_dispose, void >; ///< pointer to extracted node
+
+ private:
+ //@cond
+ struct raw_ptr_disposer
+ {
+ node_type * pReclaimedChain;
+
+ raw_ptr_disposer()
+ : pReclaimedChain( nullptr )
+ {}
+
+ raw_ptr_disposer( position& pos )
+ : pReclaimedChain( pos.pDelChain )
+ {
+ pos.pDelChain = nullptr;
+ }
+
+ raw_ptr_disposer( raw_ptr_disposer&& d )
+ : pReclaimedChain( d.pReclaimedChain )
+ {
+ d.pReclaimedChain = nullptr;
+ }
+
+ raw_ptr_disposer( raw_ptr_disposer const& ) = delete;
+
+ ~raw_ptr_disposer()
+ {
+ apply();
+ }
+
+ void apply()
+ {
+ if ( pReclaimedChain ) {
+ dispose_chain( pReclaimedChain );
+ pReclaimedChain = nullptr;
+ }
+ }
+ };
+ //@endcond
+
+ public:
+ /// Result of \p get(), \p get_with() functions - pointer to the node found
+ typedef cds::urcu::raw_ptr< gc, value_type, raw_ptr_disposer > raw_ptr;
+
+ protected:
+ //@cond
+
bool link_node( node_type * pNode, position& pos )
{
assert( pNode != nullptr );
link_checker::is_empty( pNode );
marked_node_ptr p( pos.pCur );
- pNode->m_pNext.store( p, memory_model::memory_order_relaxed );
+ pNode->m_pNext.store( p, memory_model::memory_order_release );
return pos.pPrev->compare_exchange_strong( p, marked_node_ptr(pNode), memory_model::memory_order_release, atomics::memory_order_relaxed );
}
- bool unlink_node( position& pos )
+ static void link_to_remove_chain( position& pos, node_type * pDel )
{
- // Mark the node (logical deleting)
+ assert( pDel->m_pDelChain == nullptr );
+
+ pDel->m_pDelChain = pos.pDelChain;
+ pos.pDelChain = pDel;
+ }
+
+ bool unlink_node( position& pos, erase_node_mask nMask )
+ {
+ // Mark the node (logical deletion)
marked_node_ptr next(pos.pNext, 0);
- if ( pos.pCur->m_pNext.compare_exchange_strong( next, marked_node_ptr(pos.pNext, 1), memory_model::memory_order_acquire, atomics::memory_order_relaxed )) {
+
+ if ( pos.pCur->m_pNext.compare_exchange_strong( next, next | nMask, memory_model::memory_order_acq_rel, atomics::memory_order_relaxed )) {
+
+ // Try physical removal - fast path
marked_node_ptr cur(pos.pCur);
- if ( pos.pPrev->compare_exchange_strong( cur, marked_node_ptr( pos.pNext ), memory_model::memory_order_release, atomics::memory_order_relaxed ))
- return true;
- next |= 1;
- CDS_VERIFY( pos.pCur->m_pNext.compare_exchange_strong( next, next ^ 1, memory_model::memory_order_release, atomics::memory_order_relaxed ));
+ if ( pos.pPrev->compare_exchange_strong(cur, marked_node_ptr(pos.pNext), memory_model::memory_order_acquire, atomics::memory_order_relaxed) ) {
+ if ( nMask == erase_mask )
+ link_to_remove_chain( pos, pos.pCur );
+ }
+ else {
+ // Slow path
+ search( pos.refHead, *node_traits::to_value_ptr( pos.pCur ), pos, key_comparator() );
+ }
+ return true;
}
return false;
}
return const_iterator(m_pHead );
}
/// Returns a forward const iterator addressing the first element in a list
- const_iterator cbegin()
+ const_iterator cbegin() const
{
return const_iterator(m_pHead );
}
return const_iterator();
}
/// Returns an const iterator that addresses the location succeeding the last element in a list
- const_iterator cend()
+ const_iterator cend() const
{
return const_iterator();
}
The function allows to split new item creating into two part:
- create item with key only
- insert new item into the list
- - if inserting is success, calls \p f functor to initialize value-field of \p val.
+ - if inserting is success, calls \p f functor to initialize value-field of \p val.
The functor signature is:
\code
\endcode
where \p val is the item inserted. User-defined functor \p f should guarantee that during changing
\p val no any other changes could be made on this list's item by concurrent threads.
- The user-defined functor is called only if the inserting is success and may be passed by reference
- using \p std::ref.
+ The user-defined functor is called only if the inserting is success.
The function makes RCU lock internally.
+
+ @warning See \ref cds_intrusive_item_creating "insert item troubleshooting"
*/
template <typename Func>
bool insert( value_type& val, Func f )
The functor may change non-key fields of the \p item; however, \p func must guarantee
that during changing no any other modifications could be made on this item by concurrent threads.
- You can pass \p func argument by value or by reference using \p std::ref.
-
Returns <tt> std::pair<bool, bool> </tt> where \p first is true if operation is successfull,
\p second is true if new item has been added or \p false if the item with \p key
already is in the list.
The function makes RCU lock internally.
- */
+ @warning See \ref cds_intrusive_item_creating "insert item troubleshooting"
+ */
template <typename Func>
std::pair<bool, bool> ensure( value_type& val, Func func )
{
Difference between \ref erase and \p unlink functions: \p erase finds <i>a key</i>
and deletes the item found. \p unlink finds an item by key and deletes it
- only if \p val is an item of that list, i.e. the pointer to item found
+ only if \p val is an item of that list, i.e. the pointer to the item found
is equal to <tt> &val </tt>.
The function returns \p true if success and \p false otherwise.
/// Deletes the item from the list
/** \anchor cds_intrusive_MichaelList_rcu_erase_val
- The function searches an item with key equal to \p val in the list,
+ The function searches an item with key equal to \p key in the list,
unlinks it from the list, and returns \p true.
- If the item with the key equal to \p val is not found the function return \p false.
+ If the item with the key equal to \p key is not found the function return \p false.
RCU \p synchronize method can be called.
Note that depending on RCU type used the \ref disposer call can be deferred.
The function can throw \ref cds_urcu_rcu_deadlock "cds::urcu::rcu_deadlock" exception if a deadlock is detected and
- the deadlock checking policy is opt::v::rcu_throw_deadlock.
+ the deadlock checking policy is \p opt::v::rcu_throw_deadlock.
*/
template <typename Q>
- bool erase( Q const& val )
+ bool erase( Q const& key )
{
- return erase_at( m_pHead, val, key_comparator() );
+ return erase_at( m_pHead, key, key_comparator() );
}
/// Deletes the item from the list using \p pred predicate for searching
\p pred must imply the same element order as the comparator used for building the list.
*/
template <typename Q, typename Less>
- bool erase_with( Q const& val, Less pred )
+ bool erase_with( Q const& key, Less pred )
{
- return erase_at( m_pHead, val, cds::opt::details::make_comparator_from_less<Less>() );
+ CDS_UNUSED( pred );
+ return erase_at( m_pHead, key, cds::opt::details::make_comparator_from_less<Less>() );
}
/// Deletes the item from the list
/** \anchor cds_intrusive_MichaelList_rcu_erase_func
- The function searches an item with key equal to \p val in the list,
+ The function searches an item with key equal to \p key in the list,
call \p func functor with item found, unlinks it from the list, and returns \p true.
The \p Func interface is
\code
void operator()( value_type const& item );
};
\endcode
- The functor may be passed by reference using <tt>boost:ref</tt>
- If the item with the key equal to \p val is not found the function return \p false.
+ If the item with the key equal to \p key is not found the function return \p false.
RCU \p synchronize method can be called.
Note that depending on RCU type used the \ref disposer call can be deferred.
The function can throw \ref cds_urcu_rcu_deadlock "cds::urcu::rcu_deadlock" exception if a deadlock is detected and
- the deadlock checking policy is opt::v::rcu_throw_deadlock.
+ the deadlock checking policy is \p opt::v::rcu_throw_deadlock.
*/
template <typename Q, typename Func>
- bool erase( Q const& val, Func func )
+ bool erase( Q const& key, Func func )
{
- return erase_at( m_pHead, val, key_comparator(), func );
+ return erase_at( m_pHead, key, key_comparator(), func );
}
/// Deletes the item from the list using \p pred predicate for searching
\p pred must imply the same element order as the comparator used for building the list.
*/
template <typename Q, typename Less, typename Func>
- bool erase_with( Q const& val, Less pred, Func func )
+ bool erase_with( Q const& key, Less pred, Func func )
{
- return erase_at( m_pHead, val, cds::opt::details::make_comparator_from_less<Less>(), func );
+ CDS_UNUSED( pred );
+ return erase_at( m_pHead, key, cds::opt::details::make_comparator_from_less<Less>(), func );
}
/// Extracts an item from the list
/**
@anchor cds_intrusive_MichaelList_rcu_extract
- The function searches an item with key equal to \p val in the list,
- unlinks it from the list, and returns pointer to an item found in \p dest parameter.
- If the item with the key equal to \p val is not found the function returns \p false,
- \p dest is empty.
+ The function searches an item with key equal to \p key in the list,
+ unlinks it from the list, and returns \ref cds::urcu::exempt_ptr "exempt_ptr" pointer to the item found.
+ If \p key is not found the function returns an empty \p exempt_ptr.
- @note The function does NOT call RCU read-side lock or synchronization,
- and does NOT dispose the item found. It just excludes the item from the list
+ @note The function does NOT dispose the item found. It just unlinks the item from the list
and returns a pointer to item found.
- You should lock RCU before calling this function, and you should manually release
+ You shouldn't lock RCU before calling this function, and you should manually release
\p dest exempt pointer outside the RCU lock before reusing the pointer.
\code
// ...
rcu_michael_list::exempt_ptr p1;
- {
- // first, we should lock RCU
- rcu::scoped_lock sl;
-
- // Now, you can apply extract function
- // Note that you must not delete the item found inside the RCU lock
- if ( theList.extract( p1, 10 )) {
- // do something with p1
- ...
- }
+
+ // The RCU should NOT be locked when extract() is called!
+ assert( !rcu::is_locked() );
+
+ // You can call extract() function
+ p1 = theList.extract( 10 );
+ if ( p1 ) {
+ // do something with p1
+ ...
}
// We may safely release p1 here
\endcode
*/
template <typename Q>
- bool extract( exempt_ptr& dest, Q const& val )
+ exempt_ptr extract( Q const& key )
{
- dest = extract_at( m_pHead, val, key_comparator() );
- return !dest.empty();
+ return exempt_ptr( extract_at( m_pHead, key, key_comparator() ));
}
/// Extracts an item from the list using \p pred predicate for searching
/**
- This function is the analog for \ref cds_intrusive_MichaelList_rcu_extract "extract(exempt_ptr&, Q const&)".
+ This function is the analog for \p extract(Q const&)
The \p pred is a predicate used for key comparing.
\p Less has the interface like \p std::less.
\p pred must imply the same element order as \ref key_comparator.
*/
template <typename Q, typename Less>
- bool extract_with( exempt_ptr& dest, Q const& val, Less pred )
+ exempt_ptr extract_with( Q const& key, Less pred )
{
- dest = extract_at( m_pHead, val, cds::opt::details::make_comparator_from_less<Less>() );
- return !dest.empty();
+ CDS_UNUSED( pred );
+ return exempt_ptr( extract_at( m_pHead, key, cds::opt::details::make_comparator_from_less<Less>() ));
}
/// Find the key \p val
/** \anchor cds_intrusive_MichaelList_rcu_find_func
- The function searches the item with key equal to \p val
+ The function searches the item with key equal to \p key
and calls the functor \p f for item found.
The interface of \p Func functor is:
\code
struct functor {
- void operator()( value_type& item, Q& val );
+ void operator()( value_type& item, Q& key );
};
\endcode
- where \p item is the item found, \p val is the <tt>find</tt> function argument.
-
- You can pass \p f argument by value or by reference using \p std::ref.
+ where \p item is the item found, \p key is the <tt>find</tt> function argument.
The functor can change non-key fields of \p item.
The function \p find does not serialize simultaneous access to the list \p item. If such access is
The function returns \p true if \p val is found, \p false otherwise.
*/
template <typename Q, typename Func>
- bool find( Q& val, Func f ) const
+ bool find( Q& key, Func f )
{
- return find_at( const_cast<atomic_node_ptr&>(m_pHead), val, key_comparator(), f );
+ return find_at( m_pHead, key, key_comparator(), f );
}
+ //@cond
+ template <typename Q, typename Func>
+ bool find( Q const& key, Func f )
+ {
+ return find_at( m_pHead, key, key_comparator(), f );
+ }
+ //@endcond
- /// Finds the key \p val using \p pred predicate for searching
+ /// Finds \p key using \p pred predicate for searching
/**
The function is an analog of \ref cds_intrusive_MichaelList_rcu_find_func "find(Q&, Func)"
but \p pred is used for key comparing.
\p pred must imply the same element order as the comparator used for building the list.
*/
template <typename Q, typename Less, typename Func>
- bool find_with( Q& val, Less pred, Func f ) const
+ bool find_with( Q& key, Less pred, Func f )
{
- return find_at( const_cast<atomic_node_ptr&>( m_pHead ), val, cds::opt::details::make_comparator_from_less<Less>(), f );
+ CDS_UNUSED( pred );
+ return find_at( m_pHead, key, cds::opt::details::make_comparator_from_less<Less>(), f );
}
-
- /// Find the key \p val
- /** \anchor cds_intrusive_MichaelList_rcu_find_cfunc
- The function searches the item with key equal to \p val
- and calls the functor \p f for item found.
- The interface of \p Func functor is:
- \code
- struct functor {
- void operator()( value_type& item, Q const& val );
- };
- \endcode
- where \p item is the item found, \p val is the <tt>find</tt> function argument.
-
- You can pass \p f argument by value or by reference using \p std::ref.
-
- The functor can change non-key fields of \p item.
- The function \p find does not serialize simultaneous access to the list \p item. If such access is
- possible you must provide your own synchronization schema to exclude unsafe item modifications.
-
- The function makes RCU lock internally.
-
- The function returns \p true if \p val is found, \p false otherwise.
- */
- template <typename Q, typename Func>
- bool find( Q const& val, Func f ) const
- {
- return find_at( const_cast<atomic_node_ptr&>( m_pHead ), val, key_comparator(), f );
- }
-
- /// Finds the key \p val using \p pred predicate for searching
- /**
- The function is an analog of \ref cds_intrusive_MichaelList_rcu_find_cfunc "find(Q const&, Func)"
- but \p pred is used for key comparing.
- \p Less functor has the interface like \p std::less.
- \p pred must imply the same element order as the comparator used for building the list.
- */
+ //@cond
template <typename Q, typename Less, typename Func>
- bool find_with( Q const& val, Less pred, Func f ) const
+ bool find_with( Q const& key, Less pred, Func f )
{
- return find_at( const_cast<atomic_node_ptr&>( m_pHead ), val, cds::opt::details::make_comparator_from_less<Less>(), f );
+ CDS_UNUSED( pred );
+ return find_at( m_pHead, key, cds::opt::details::make_comparator_from_less<Less>(), f );
}
+ //@endcond
- /// Find the key \p val
+ /// Finds \p key
/** \anchor cds_intrusive_MichaelList_rcu_find_val
- The function searches the item with key equal to \p val
+ The function searches the item with key equal to \p key
and returns \p true if \p val found or \p false otherwise.
*/
template <typename Q>
- bool find( Q const& val ) const
+ bool find( Q const& key )
{
- return find_at( const_cast<atomic_node_ptr&>( m_pHead ), val, key_comparator() );
+ return find_at( m_pHead, key, key_comparator() );
}
- /// Finds the key \p val using \p pred predicate for searching
+ /// Finds \p key using \p pred predicate for searching
/**
The function is an analog of \ref cds_intrusive_MichaelList_rcu_find_val "find(Q const&)"
but \p pred is used for key comparing.
\p pred must imply the same element order as the comparator used for building the list.
*/
template <typename Q, typename Less>
- bool find_with( Q const& val, Less pred ) const
+ bool find_with( Q const& key, Less pred )
{
- return find_at( const_cast<atomic_node_ptr&>( m_pHead ), val, cds::opt::details::make_comparator_from_less<Less>() );
+ CDS_UNUSED( pred );
+ return find_at( m_pHead, key, cds::opt::details::make_comparator_from_less<Less>() );
}
- /// Finds the key \p val and return the item found
+ /// Finds \p key and return the item found
/** \anchor cds_intrusive_MichaelList_rcu_get
- The function searches the item with key equal to \p val and returns the pointer to item found.
- If \p val is not found it returns \p nullptr.
+ The function searches the item with key equal to \p key and returns the pointer to item found.
+ If \p key is not found it returns empty \p raw_ptr object.
Note the compare functor should accept a parameter of type \p Q that can be not the same as \p value_type.
typedef cds::intrusive::MichaelList< cds::urcu::gc< cds::urcu::general_buffered<> >, foo, my_traits > ord_list;
ord_list theList;
// ...
+ typename ord_list::raw_ptr rp;
{
// Lock RCU
ord_list::rcu_lock lock;
- foo * pVal = theList.get( 5 );
- if ( pVal ) {
- // Deal with pVal
+ rp = theList.get( 5 );
+ if ( rp ) {
+ // Deal with rp
//...
}
// Unlock RCU by rcu_lock destructor
- // pVal can be retired by disposer at any time after RCU has been unlocked
+ // Node owned by rp can be retired by disposer at any time after RCU has been unlocked
}
+ // You can manually release rp after RCU-locked section
+ rp.release();
\endcode
*/
template <typename Q>
- value_type * get( Q const& val ) const
+ raw_ptr get( Q const& key )
{
- return get_at( const_cast<atomic_node_ptr&>( m_pHead ), val, key_comparator());
+ return get_at( m_pHead, key, key_comparator());
}
- /// Finds the key \p val and return the item found
+ /// Finds \p key and return the item found
/**
The function is an analog of \ref cds_intrusive_MichaelList_rcu_get "get(Q const&)"
but \p pred is used for comparing the keys.
- \p Less functor has the semantics like \p std::less but should take arguments of type \ref value_type and \p Q
+ \p Less functor has the semantics like \p std::less but should take arguments of type \p value_type and \p Q
in any order.
\p pred must imply the same element order as the comparator used for building the list.
*/
template <typename Q, typename Less>
- value_type * get_with( Q const& val, Less pred ) const
+ raw_ptr get_with( Q const& key, Less pred )
{
- return get_at( const_cast<atomic_node_ptr&>( m_pHead ), val, cds::opt::details::make_comparator_from_less<Less>());
+ CDS_UNUSED( pred );
+ return get_at( m_pHead, key, cds::opt::details::make_comparator_from_less<Less>());
}
/// Clears the list using default disposer
/**
- The function clears the list using default (provided in class template) disposer functor.
+ The function clears the list using default (provided by \p Traits class template argument) disposer functor.
RCU \p synchronize method can be called.
Note that depending on RCU type used the \ref disposer invocation can be deferred.
- The function can throw cds::urcu::rcu_deadlock exception if an deadlock is encountered and
- deadlock checking policy is opt::v::rcu_throw_deadlock.
+ The function can throw \p cds::urcu::rcu_deadlock exception if an deadlock is encountered and
+ deadlock checking policy is \p opt::v::rcu_throw_deadlock.
*/
void clear()
{
for (;;) {
{
rcu_lock l;
- pHead = m_pHead.load(memory_model::memory_order_consume);
+ pHead = m_pHead.load(memory_model::memory_order_acquire);
if ( !pHead.ptr() )
break;
marked_node_ptr pNext( pHead->m_pNext.load(memory_model::memory_order_relaxed) );
/// Returns list's item count
/**
- The value returned depends on opt::item_counter option. For atomics::empty_item_counter,
+ The value returned depends on item counter provided by \p Traits. For \p atomicity::empty_item_counter,
this function always returns 0.
- <b>Warning</b>: even if you use real item counter and it returns 0, this fact is not mean that the list
- is empty. To check list emptyness use \ref empty() method.
+ @note Even if you use real item counter and it returns 0, this fact does not mean that the list
+ is empty. To check list emptyness use \p empty() method.
*/
size_t size() const
{
return insert_at( refHead, *node_traits::to_value_ptr( pNode ) );
}
- bool insert_at( atomic_node_ptr& refHead, value_type& val, bool bLock = true )
+ bool insert_at( atomic_node_ptr& refHead, value_type& val )
{
- link_checker::is_empty( node_traits::to_node_ptr( val ) );
- position pos;
-
- rcu_lock l( bLock );
- while ( true ) {
- if ( search( refHead, val, pos, key_comparator() ) )
- return false;
-
- if ( link_node( node_traits::to_node_ptr( val ), pos ) ) {
- ++m_ItemCounter;
- return true;
- }
-
- // clear next field
- node_traits::to_node_ptr( val )->m_pNext.store( marked_node_ptr(), memory_model::memory_order_relaxed );
+ position pos( refHead );
+ {
+ rcu_lock l;
+ return insert_at_locked( pos, val );
}
}
bool insert_at( atomic_node_ptr& refHead, value_type& val, Func f )
{
link_checker::is_empty( node_traits::to_node_ptr( val ) );
- position pos;
+ position pos( refHead );
- rcu_lock l;
- while ( true ) {
- if ( search( refHead, val, pos, key_comparator() ) )
- return false;
+ {
+ rcu_lock l;
+ while ( true ) {
+ if ( search( refHead, val, pos, key_comparator()))
+ return false;
- if ( link_node( node_traits::to_node_ptr( val ), pos ) ) {
- f( val );
- ++m_ItemCounter;
- return true;
- }
+ if ( link_node( node_traits::to_node_ptr( val ), pos ) ) {
+ f( val );
+ ++m_ItemCounter;
+ return true;
+ }
- // clear next field
- node_traits::to_node_ptr( val )->m_pNext.store( marked_node_ptr(), memory_model::memory_order_relaxed );
+ // clear next field
+ node_traits::to_node_ptr( val )->m_pNext.store( marked_node_ptr(), memory_model::memory_order_relaxed );
+ }
}
+
}
- iterator insert_at_( atomic_node_ptr& refHead, value_type& val, bool bLock = true )
+ iterator insert_at_( atomic_node_ptr& refHead, value_type& val )
{
- rcu_lock l( bLock );
- if ( insert_at( refHead, val, false ))
+ rcu_lock l;
+ if ( insert_at_locked( refHead, val ))
return iterator( node_traits::to_node_ptr( val ));
return end();
}
template <typename Func>
- std::pair<iterator, bool> ensure_at_( atomic_node_ptr& refHead, value_type& val, Func func, bool bLock = true )
+ std::pair<iterator, bool> ensure_at_( atomic_node_ptr& refHead, value_type& val, Func func )
{
- position pos;
-
- rcu_lock l( bLock );
- while ( true ) {
- if ( search( refHead, val, pos, key_comparator() ) ) {
- assert( key_comparator()( val, *node_traits::to_value_ptr( *pos.pCur ) ) == 0 );
-
- func( false, *node_traits::to_value_ptr( *pos.pCur ), val );
- return std::make_pair( iterator( pos.pCur ), false );
- }
- else {
- link_checker::is_empty( node_traits::to_node_ptr( val ) );
-
- if ( link_node( node_traits::to_node_ptr( val ), pos ) ) {
- ++m_ItemCounter;
- func( true, val , val );
- return std::make_pair( iterator( node_traits::to_node_ptr( val )), true );
- }
-
- // clear the next field
- node_traits::to_node_ptr( val )->m_pNext.store( marked_node_ptr(), memory_model::memory_order_relaxed );
- }
+ position pos( refHead );
+ {
+ rcu_lock l;
+ return ensure_at_locked( pos, val, func );
}
}
template <typename Func>
- std::pair<bool, bool> ensure_at( atomic_node_ptr& refHead, value_type& val, Func func, bool bLock = true )
+ std::pair<bool, bool> ensure_at( atomic_node_ptr& refHead, value_type& val, Func func )
{
- rcu_lock l( bLock );
- std::pair<iterator, bool> ret = ensure_at_( refHead, val, func, false );
- return std::make_pair( ret.first != end(), ret.second );
+ position pos( refHead );
+ {
+ rcu_lock l;
+ std::pair<iterator, bool> ret = ensure_at_locked( pos, val, func );
+ return std::make_pair( ret.first != end(), ret.second );
+ }
}
bool unlink_at( atomic_node_ptr& refHead, value_type& val )
{
- position pos;
+ position pos( refHead );
back_off bkoff;
check_deadlock_policy::check();
rcu_lock l;
if ( !search( refHead, val, pos, key_comparator() ) || node_traits::to_value_ptr( *pos.pCur ) != &val )
return false;
- if ( !unlink_node( pos )) {
+ if ( !unlink_node( pos, erase_mask )) {
bkoff();
continue;
}
}
--m_ItemCounter;
- dispose_node( pos.pCur );
return true;
}
}
template <typename Q, typename Compare, typename Func>
- bool erase_at( atomic_node_ptr& refHead, Q const& val, Compare cmp, Func f, position& pos )
+ bool erase_at( position& pos, Q const& val, Compare cmp, Func f )
{
back_off bkoff;
check_deadlock_policy::check();
for (;;) {
{
rcu_lock l;
- if ( !search( refHead, val, pos, cmp ) )
+ if ( !search( pos.refHead, val, pos, cmp ) )
return false;
- if ( !unlink_node( pos )) {
+ if ( !unlink_node( pos, erase_mask )) {
bkoff();
continue;
}
f( *node_traits::to_value_ptr( *pos.pCur ) );
--m_ItemCounter;
- dispose_node( pos.pCur );
return true;
}
}
template <typename Q, typename Compare, typename Func>
bool erase_at( atomic_node_ptr& refHead, Q const& val, Compare cmp, Func f )
{
- position pos;
- return erase_at( refHead, val, cmp, f, pos );
+ position pos( refHead );
+ return erase_at( pos, val, cmp, f );
}
template <typename Q, typename Compare>
bool erase_at( atomic_node_ptr& refHead, const Q& val, Compare cmp )
{
- position pos;
- return erase_at( refHead, val, cmp, [](value_type const&){}, pos );
+ position pos( refHead );
+ return erase_at( pos, val, cmp, [](value_type const&){} );
}
template <typename Q, typename Compare >
value_type * extract_at( atomic_node_ptr& refHead, Q const& val, Compare cmp )
{
- position pos;
+ position pos( refHead );
back_off bkoff;
- assert( gc::is_locked() ) ; // RCU must be locked!!!
+ assert( !gc::is_locked() ) ; // RCU must not be locked!!!
- for (;;) {
- if ( !search( refHead, val, pos, cmp ) )
- return nullptr;
- if ( !unlink_node( pos )) {
- bkoff();
- continue;
- }
+ {
+ rcu_lock l;
+ for (;;) {
+ if ( !search( refHead, val, pos, cmp ) )
+ return nullptr;
+ if ( !unlink_node( pos, extract_mask )) {
+ bkoff();
+ continue;
+ }
- --m_ItemCounter;
- return node_traits::to_value_ptr( pos.pCur );
+ --m_ItemCounter;
+ return node_traits::to_value_ptr( pos.pCur );
+ }
}
}
template <typename Q, typename Compare, typename Func>
- bool find_at( atomic_node_ptr& refHead, Q& val, Compare cmp, Func f, bool bLock = true ) const
+ bool find_at( atomic_node_ptr& refHead, Q& val, Compare cmp, Func f )
{
- position pos;
+ position pos( refHead );
- rcu_lock l( bLock );
- if ( search( refHead, val, pos, cmp ) ) {
- assert( pos.pCur != nullptr );
- f( *node_traits::to_value_ptr( *pos.pCur ), val );
- return true;
+ {
+ rcu_lock l;
+ if ( search( refHead, val, pos, cmp ) ) {
+ assert( pos.pCur != nullptr );
+ f( *node_traits::to_value_ptr( *pos.pCur ), val );
+ return true;
+ }
+ return false;
}
- return false;
}
template <typename Q, typename Compare>
- bool find_at( atomic_node_ptr& refHead, Q const& val, Compare cmp ) const
+ bool find_at( atomic_node_ptr& refHead, Q const& val, Compare cmp )
{
- rcu_lock l;
- return find_at_( refHead, val, cmp ) != end();
+ position pos( refHead );
+ {
+ rcu_lock l;
+ return find_at_locked( pos, val, cmp ) != cend();
+ }
}
template <typename Q, typename Compare>
- value_type * get_at( atomic_node_ptr& refHead, Q const& val, Compare cmp ) const
+ raw_ptr get_at( atomic_node_ptr& refHead, Q const& val, Compare cmp )
{
- value_type * pFound = nullptr;
- return find_at( refHead, val, cmp,
- [&pFound](value_type& found, Q const& ) { pFound = &found; } )
- ? pFound : nullptr;
- }
+ // RCU should be locked!
+ assert(gc::is_locked() );
- template <typename Q, typename Compare>
- const_iterator find_at_( atomic_node_ptr& refHead, Q const& val, Compare cmp ) const
- {
- assert( gc::is_locked() );
- position pos;
+ position pos( refHead );
- if ( search( refHead, val, pos, cmp ) ) {
- assert( pos.pCur != nullptr );
- return const_iterator( pos.pCur );
- }
- return end();
+ if ( search( refHead, val, pos, cmp ))
+ return raw_ptr( node_traits::to_value_ptr( pos.pCur ), raw_ptr_disposer( pos ));
+ return raw_ptr( raw_ptr_disposer( pos ));
}
-
//@endcond
protected:
//@cond
template <typename Q, typename Compare>
- bool search( atomic_node_ptr& refHead, const Q& val, position& pos, Compare cmp ) const
+ bool search( atomic_node_ptr& refHead, const Q& val, position& pos, Compare cmp )
{
// RCU lock should be locked!!!
assert( gc::is_locked() );
while ( true ) {
if ( !pCur.ptr() ) {
pos.pPrev = pPrev;
- pos.pCur = pCur.ptr();
- pos.pNext = pNext.ptr();
+ pos.pCur = nullptr;
+ pos.pNext = nullptr;
return false;
}
- pNext = pCur->m_pNext.load(memory_model::memory_order_relaxed);
+ pNext = pCur->m_pNext.load(memory_model::memory_order_acquire);
- if ( pPrev->load(memory_model::memory_order_acquire) != pCur
- || pNext != pCur->m_pNext.load(memory_model::memory_order_acquire)
- || pNext.bits() != 0 ) // pNext contains deletion mark for pCur
+ if ( pPrev->load(memory_model::memory_order_relaxed) != pCur
+ || pNext != pCur->m_pNext.load(memory_model::memory_order_relaxed))
{
- // if pCur is marked as deleted (pNext.bits() != 0)
- // we wait for physical removal.
- // Helping technique is not suitable for RCU since it requires
- // that the RCU should be in unlocking state.
bkoff();
goto try_again;
}
+ if ( pNext.bits() ) {
+ // pCur is marked as deleted. Try to unlink it from the list
+ if ( pPrev->compare_exchange_weak( pCur, marked_node_ptr( pNext.ptr() ), memory_model::memory_order_acquire, atomics::memory_order_relaxed ) ) {
+ if ( pNext.bits() == erase_mask )
+ link_to_remove_chain( pos, pCur.ptr() );
+ }
+
+ goto try_again;
+ }
+
assert( pCur.ptr() != nullptr );
int nCmp = cmp( *node_traits::to_value_ptr( pCur.ptr() ), val );
if ( nCmp >= 0 ) {
}
}
//@endcond
+
+ private:
+ //@cond
+ bool insert_at_locked( position& pos, value_type& val )
+ {
+ // RCU lock should be locked!!!
+ assert( gc::is_locked() );
+ link_checker::is_empty( node_traits::to_node_ptr( val ) );
+
+ while ( true ) {
+ if ( search( pos.refHead, val, pos, key_comparator() ) )
+ return false;
+
+ if ( link_node( node_traits::to_node_ptr( val ), pos ) ) {
+ ++m_ItemCounter;
+ return true;
+ }
+
+ // clear next field
+ node_traits::to_node_ptr( val )->m_pNext.store( marked_node_ptr(), memory_model::memory_order_relaxed );
+ }
+ }
+
+ template <typename Func>
+ std::pair<iterator, bool> ensure_at_locked( position& pos, value_type& val, Func func )
+ {
+ // RCU lock should be locked!!!
+ assert( gc::is_locked() );
+
+ while ( true ) {
+ if ( search( pos.refHead, val, pos, key_comparator() ) ) {
+ assert( key_comparator()( val, *node_traits::to_value_ptr( *pos.pCur ) ) == 0 );
+
+ func( false, *node_traits::to_value_ptr( *pos.pCur ), val );
+ return std::make_pair( iterator( pos.pCur ), false );
+ }
+ else {
+ link_checker::is_empty( node_traits::to_node_ptr( val ) );
+
+ if ( link_node( node_traits::to_node_ptr( val ), pos ) ) {
+ ++m_ItemCounter;
+ func( true, val , val );
+ return std::make_pair( iterator( node_traits::to_node_ptr( val )), true );
+ }
+
+ // clear the next field
+ node_traits::to_node_ptr( val )->m_pNext.store( marked_node_ptr(), memory_model::memory_order_relaxed );
+ }
+ }
+ }
+
+ template <typename Q, typename Compare>
+ const_iterator find_at_locked( position& pos, Q const& val, Compare cmp )
+ {
+ assert( gc::is_locked() );
+
+ if ( search( pos.refHead, val, pos, cmp ) ) {
+ assert( pos.pCur != nullptr );
+ return const_iterator( pos.pCur );
+ }
+ return cend();
+ }
+ //@endcond
};
}} // namespace cds::intrusive
-#endif // #ifndef __CDS_INTRUSIVE_MICHAEL_LIST_NOGC_H
+#endif // #ifndef CDSLIB_INTRUSIVE_MICHAEL_LIST_NOGC_H