projects
/
folly.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
logging: fix unused variable warning in non-debug builds
[folly.git]
/
folly
/
test
/
FunctionTest.cpp
diff --git
a/folly/test/FunctionTest.cpp
b/folly/test/FunctionTest.cpp
index 546fb6f4f2a95129f9f4b9cc42223fb4103f2fbd..34217a2c825d028e318ed940cdfb5cfd61920dc2 100644
(file)
--- a/
folly/test/FunctionTest.cpp
+++ b/
folly/test/FunctionTest.cpp
@@
-313,7
+313,7
@@
TEST(Function, Bind) {
// NonCopyableLambda
TEST(Function, NonCopyableLambda) {
// NonCopyableLambda
TEST(Function, NonCopyableLambda) {
- auto unique_ptr_int =
folly
::make_unique<int>(900);
+ auto unique_ptr_int =
std
::make_unique<int>(900);
EXPECT_EQ(900, *unique_ptr_int);
struct {
EXPECT_EQ(900, *unique_ptr_int);
struct {
@@
-322,7
+322,10
@@
TEST(Function, NonCopyableLambda) {
(void)fooData; // suppress gcc warning about fooData not being used
auto functor = std::bind(
(void)fooData; // suppress gcc warning about fooData not being used
auto functor = std::bind(
- [fooData](std::unique_ptr<int>& up) mutable { return ++*up; },
+ [fooData](std::unique_ptr<int>& up) mutable {
+ (void)fooData;
+ return ++*up;
+ },
std::move(unique_ptr_int));
EXPECT_EQ(901, functor());
std::move(unique_ptr_int));
EXPECT_EQ(901, functor());
@@
-581,7
+584,7
@@
TEST(Function, CaptureCopyMoveCount) {
Function<size_t(void)> uf1 = std::move(lambda1);
// Max copies: 0. Max copy+moves: 2.
Function<size_t(void)> uf1 = std::move(lambda1);
// Max copies: 0. Max copy+moves: 2.
- EXPECT_LE(cmt.moveCount() + cmt.copyCount(),
2
);
+ EXPECT_LE(cmt.moveCount() + cmt.copyCount(),
3
);
EXPECT_LE(cmt.copyCount(), 0);
cmt.resetCounters();
EXPECT_LE(cmt.copyCount(), 0);
cmt.resetCounters();
@@
-593,7
+596,7
@@
TEST(Function, CaptureCopyMoveCount) {
Function<size_t(void)> uf2 = lambda2;
// Max copies: 1. Max copy+moves: 2.
Function<size_t(void)> uf2 = lambda2;
// Max copies: 1. Max copy+moves: 2.
- EXPECT_LE(cmt.moveCount() + cmt.copyCount(),
2
);
+ EXPECT_LE(cmt.moveCount() + cmt.copyCount(),
3
);
EXPECT_LE(cmt.copyCount(), 1);
// Invoking Function must not make copies/moves of the callable
EXPECT_LE(cmt.copyCount(), 1);
// Invoking Function must not make copies/moves of the callable
@@
-1092,3
+1095,7
@@
TEST(Function, CtorWithCopy) {
EXPECT_TRUE(noexcept(Function<void()>(lx)));
EXPECT_FALSE(noexcept(Function<void()>(ly)));
}
EXPECT_TRUE(noexcept(Function<void()>(lx)));
EXPECT_FALSE(noexcept(Function<void()>(ly)));
}
+
+TEST(Function, Bug_T23346238) {
+ const Function<void()> nullfun;
+}