drm/i915/sdvo: Include YRPB as an additional TV output type
[firefly-linux-kernel-4.4.55.git] / drivers / gpu / drm / i915 / intel_sdvo.c
1 /*
2  * Copyright 2006 Dave Airlie <airlied@linux.ie>
3  * Copyright © 2006-2007 Intel Corporation
4  *   Jesse Barnes <jesse.barnes@intel.com>
5  *
6  * Permission is hereby granted, free of charge, to any person obtaining a
7  * copy of this software and associated documentation files (the "Software"),
8  * to deal in the Software without restriction, including without limitation
9  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
10  * and/or sell copies of the Software, and to permit persons to whom the
11  * Software is furnished to do so, subject to the following conditions:
12  *
13  * The above copyright notice and this permission notice (including the next
14  * paragraph) shall be included in all copies or substantial portions of the
15  * Software.
16  *
17  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
18  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
19  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
20  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
21  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
22  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
23  * DEALINGS IN THE SOFTWARE.
24  *
25  * Authors:
26  *      Eric Anholt <eric@anholt.net>
27  */
28 #include <linux/i2c.h>
29 #include <linux/slab.h>
30 #include <linux/delay.h>
31 #include <linux/export.h>
32 #include "drmP.h"
33 #include "drm.h"
34 #include "drm_crtc.h"
35 #include "drm_edid.h"
36 #include "intel_drv.h"
37 #include "i915_drm.h"
38 #include "i915_drv.h"
39 #include "intel_sdvo_regs.h"
40
41 #define SDVO_TMDS_MASK (SDVO_OUTPUT_TMDS0 | SDVO_OUTPUT_TMDS1)
42 #define SDVO_RGB_MASK  (SDVO_OUTPUT_RGB0 | SDVO_OUTPUT_RGB1)
43 #define SDVO_LVDS_MASK (SDVO_OUTPUT_LVDS0 | SDVO_OUTPUT_LVDS1)
44 #define SDVO_TV_MASK   (SDVO_OUTPUT_CVBS0 | SDVO_OUTPUT_SVID0 | SDVO_OUTPUT_YPRPB0)
45
46 #define SDVO_OUTPUT_MASK (SDVO_TMDS_MASK | SDVO_RGB_MASK | SDVO_LVDS_MASK |\
47                         SDVO_TV_MASK)
48
49 #define IS_TV(c)        (c->output_flag & SDVO_TV_MASK)
50 #define IS_TMDS(c)      (c->output_flag & SDVO_TMDS_MASK)
51 #define IS_LVDS(c)      (c->output_flag & SDVO_LVDS_MASK)
52 #define IS_TV_OR_LVDS(c) (c->output_flag & (SDVO_TV_MASK | SDVO_LVDS_MASK))
53 #define IS_DIGITAL(c) (c->output_flag & (SDVO_TMDS_MASK | SDVO_LVDS_MASK))
54
55
56 static const char *tv_format_names[] = {
57         "NTSC_M"   , "NTSC_J"  , "NTSC_443",
58         "PAL_B"    , "PAL_D"   , "PAL_G"   ,
59         "PAL_H"    , "PAL_I"   , "PAL_M"   ,
60         "PAL_N"    , "PAL_NC"  , "PAL_60"  ,
61         "SECAM_B"  , "SECAM_D" , "SECAM_G" ,
62         "SECAM_K"  , "SECAM_K1", "SECAM_L" ,
63         "SECAM_60"
64 };
65
66 #define TV_FORMAT_NUM  (sizeof(tv_format_names) / sizeof(*tv_format_names))
67
68 struct intel_sdvo {
69         struct intel_encoder base;
70
71         struct i2c_adapter *i2c;
72         u8 slave_addr;
73
74         struct i2c_adapter ddc;
75
76         /* Register for the SDVO device: SDVOB or SDVOC */
77         uint32_t sdvo_reg;
78
79         /* Active outputs controlled by this SDVO output */
80         uint16_t controlled_output;
81
82         /*
83          * Capabilities of the SDVO device returned by
84          * i830_sdvo_get_capabilities()
85          */
86         struct intel_sdvo_caps caps;
87
88         /* Pixel clock limitations reported by the SDVO device, in kHz */
89         int pixel_clock_min, pixel_clock_max;
90
91         /*
92         * For multiple function SDVO device,
93         * this is for current attached outputs.
94         */
95         uint16_t attached_output;
96
97         /*
98          * Hotplug activation bits for this device
99          */
100         uint8_t hotplug_active[2];
101
102         /**
103          * This is used to select the color range of RBG outputs in HDMI mode.
104          * It is only valid when using TMDS encoding and 8 bit per color mode.
105          */
106         uint32_t color_range;
107
108         /**
109          * This is set if we're going to treat the device as TV-out.
110          *
111          * While we have these nice friendly flags for output types that ought
112          * to decide this for us, the S-Video output on our HDMI+S-Video card
113          * shows up as RGB1 (VGA).
114          */
115         bool is_tv;
116
117         /* On different gens SDVOB is at different places. */
118         bool is_sdvob;
119
120         /* This is for current tv format name */
121         int tv_format_index;
122
123         /**
124          * This is set if we treat the device as HDMI, instead of DVI.
125          */
126         bool is_hdmi;
127         bool has_hdmi_monitor;
128         bool has_hdmi_audio;
129
130         /**
131          * This is set if we detect output of sdvo device as LVDS and
132          * have a valid fixed mode to use with the panel.
133          */
134         bool is_lvds;
135
136         /**
137          * This is sdvo fixed pannel mode pointer
138          */
139         struct drm_display_mode *sdvo_lvds_fixed_mode;
140
141         /* DDC bus used by this SDVO encoder */
142         uint8_t ddc_bus;
143
144         /* Input timings for adjusted_mode */
145         struct intel_sdvo_dtd input_dtd;
146 };
147
148 struct intel_sdvo_connector {
149         struct intel_connector base;
150
151         /* Mark the type of connector */
152         uint16_t output_flag;
153
154         enum hdmi_force_audio force_audio;
155
156         /* This contains all current supported TV format */
157         u8 tv_format_supported[TV_FORMAT_NUM];
158         int   format_supported_num;
159         struct drm_property *tv_format;
160
161         /* add the property for the SDVO-TV */
162         struct drm_property *left;
163         struct drm_property *right;
164         struct drm_property *top;
165         struct drm_property *bottom;
166         struct drm_property *hpos;
167         struct drm_property *vpos;
168         struct drm_property *contrast;
169         struct drm_property *saturation;
170         struct drm_property *hue;
171         struct drm_property *sharpness;
172         struct drm_property *flicker_filter;
173         struct drm_property *flicker_filter_adaptive;
174         struct drm_property *flicker_filter_2d;
175         struct drm_property *tv_chroma_filter;
176         struct drm_property *tv_luma_filter;
177         struct drm_property *dot_crawl;
178
179         /* add the property for the SDVO-TV/LVDS */
180         struct drm_property *brightness;
181
182         /* Add variable to record current setting for the above property */
183         u32     left_margin, right_margin, top_margin, bottom_margin;
184
185         /* this is to get the range of margin.*/
186         u32     max_hscan,  max_vscan;
187         u32     max_hpos, cur_hpos;
188         u32     max_vpos, cur_vpos;
189         u32     cur_brightness, max_brightness;
190         u32     cur_contrast,   max_contrast;
191         u32     cur_saturation, max_saturation;
192         u32     cur_hue,        max_hue;
193         u32     cur_sharpness,  max_sharpness;
194         u32     cur_flicker_filter,             max_flicker_filter;
195         u32     cur_flicker_filter_adaptive,    max_flicker_filter_adaptive;
196         u32     cur_flicker_filter_2d,          max_flicker_filter_2d;
197         u32     cur_tv_chroma_filter,   max_tv_chroma_filter;
198         u32     cur_tv_luma_filter,     max_tv_luma_filter;
199         u32     cur_dot_crawl,  max_dot_crawl;
200 };
201
202 static struct intel_sdvo *to_intel_sdvo(struct drm_encoder *encoder)
203 {
204         return container_of(encoder, struct intel_sdvo, base.base);
205 }
206
207 static struct intel_sdvo *intel_attached_sdvo(struct drm_connector *connector)
208 {
209         return container_of(intel_attached_encoder(connector),
210                             struct intel_sdvo, base);
211 }
212
213 static struct intel_sdvo_connector *to_intel_sdvo_connector(struct drm_connector *connector)
214 {
215         return container_of(to_intel_connector(connector), struct intel_sdvo_connector, base);
216 }
217
218 static bool
219 intel_sdvo_output_setup(struct intel_sdvo *intel_sdvo, uint16_t flags);
220 static bool
221 intel_sdvo_tv_create_property(struct intel_sdvo *intel_sdvo,
222                               struct intel_sdvo_connector *intel_sdvo_connector,
223                               int type);
224 static bool
225 intel_sdvo_create_enhance_property(struct intel_sdvo *intel_sdvo,
226                                    struct intel_sdvo_connector *intel_sdvo_connector);
227
228 /**
229  * Writes the SDVOB or SDVOC with the given value, but always writes both
230  * SDVOB and SDVOC to work around apparent hardware issues (according to
231  * comments in the BIOS).
232  */
233 static void intel_sdvo_write_sdvox(struct intel_sdvo *intel_sdvo, u32 val)
234 {
235         struct drm_device *dev = intel_sdvo->base.base.dev;
236         struct drm_i915_private *dev_priv = dev->dev_private;
237         u32 bval = val, cval = val;
238         int i;
239
240         if (intel_sdvo->sdvo_reg == PCH_SDVOB) {
241                 I915_WRITE(intel_sdvo->sdvo_reg, val);
242                 I915_READ(intel_sdvo->sdvo_reg);
243                 return;
244         }
245
246         if (intel_sdvo->sdvo_reg == SDVOB) {
247                 cval = I915_READ(SDVOC);
248         } else {
249                 bval = I915_READ(SDVOB);
250         }
251         /*
252          * Write the registers twice for luck. Sometimes,
253          * writing them only once doesn't appear to 'stick'.
254          * The BIOS does this too. Yay, magic
255          */
256         for (i = 0; i < 2; i++)
257         {
258                 I915_WRITE(SDVOB, bval);
259                 I915_READ(SDVOB);
260                 I915_WRITE(SDVOC, cval);
261                 I915_READ(SDVOC);
262         }
263 }
264
265 static bool intel_sdvo_read_byte(struct intel_sdvo *intel_sdvo, u8 addr, u8 *ch)
266 {
267         struct i2c_msg msgs[] = {
268                 {
269                         .addr = intel_sdvo->slave_addr,
270                         .flags = 0,
271                         .len = 1,
272                         .buf = &addr,
273                 },
274                 {
275                         .addr = intel_sdvo->slave_addr,
276                         .flags = I2C_M_RD,
277                         .len = 1,
278                         .buf = ch,
279                 }
280         };
281         int ret;
282
283         if ((ret = i2c_transfer(intel_sdvo->i2c, msgs, 2)) == 2)
284                 return true;
285
286         DRM_DEBUG_KMS("i2c transfer returned %d\n", ret);
287         return false;
288 }
289
290 #define SDVO_CMD_NAME_ENTRY(cmd) {cmd, #cmd}
291 /** Mapping of command numbers to names, for debug output */
292 static const struct _sdvo_cmd_name {
293         u8 cmd;
294         const char *name;
295 } sdvo_cmd_names[] = {
296         SDVO_CMD_NAME_ENTRY(SDVO_CMD_RESET),
297         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_DEVICE_CAPS),
298         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_FIRMWARE_REV),
299         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_TRAINED_INPUTS),
300         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_ACTIVE_OUTPUTS),
301         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_ACTIVE_OUTPUTS),
302         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_IN_OUT_MAP),
303         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_IN_OUT_MAP),
304         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_ATTACHED_DISPLAYS),
305         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_HOT_PLUG_SUPPORT),
306         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_ACTIVE_HOT_PLUG),
307         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_ACTIVE_HOT_PLUG),
308         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_INTERRUPT_EVENT_SOURCE),
309         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_TARGET_INPUT),
310         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_TARGET_OUTPUT),
311         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_INPUT_TIMINGS_PART1),
312         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_INPUT_TIMINGS_PART2),
313         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_INPUT_TIMINGS_PART1),
314         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_INPUT_TIMINGS_PART2),
315         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_INPUT_TIMINGS_PART1),
316         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_OUTPUT_TIMINGS_PART1),
317         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_OUTPUT_TIMINGS_PART2),
318         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_OUTPUT_TIMINGS_PART1),
319         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_OUTPUT_TIMINGS_PART2),
320         SDVO_CMD_NAME_ENTRY(SDVO_CMD_CREATE_PREFERRED_INPUT_TIMING),
321         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_PREFERRED_INPUT_TIMING_PART1),
322         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_PREFERRED_INPUT_TIMING_PART2),
323         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_INPUT_PIXEL_CLOCK_RANGE),
324         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_OUTPUT_PIXEL_CLOCK_RANGE),
325         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SUPPORTED_CLOCK_RATE_MULTS),
326         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_CLOCK_RATE_MULT),
327         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_CLOCK_RATE_MULT),
328         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SUPPORTED_TV_FORMATS),
329         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_TV_FORMAT),
330         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_TV_FORMAT),
331         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SUPPORTED_POWER_STATES),
332         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_POWER_STATE),
333         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_ENCODER_POWER_STATE),
334         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_DISPLAY_POWER_STATE),
335         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_CONTROL_BUS_SWITCH),
336         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SDTV_RESOLUTION_SUPPORT),
337         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SCALED_HDTV_RESOLUTION_SUPPORT),
338         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SUPPORTED_ENHANCEMENTS),
339
340         /* Add the op code for SDVO enhancements */
341         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_HPOS),
342         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_HPOS),
343         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_HPOS),
344         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_VPOS),
345         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_VPOS),
346         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_VPOS),
347         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_SATURATION),
348         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SATURATION),
349         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_SATURATION),
350         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_HUE),
351         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_HUE),
352         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_HUE),
353         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_CONTRAST),
354         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_CONTRAST),
355         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_CONTRAST),
356         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_BRIGHTNESS),
357         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_BRIGHTNESS),
358         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_BRIGHTNESS),
359         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_OVERSCAN_H),
360         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_OVERSCAN_H),
361         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_OVERSCAN_H),
362         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_OVERSCAN_V),
363         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_OVERSCAN_V),
364         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_OVERSCAN_V),
365         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_FLICKER_FILTER),
366         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_FLICKER_FILTER),
367         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_FLICKER_FILTER),
368         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_FLICKER_FILTER_ADAPTIVE),
369         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_FLICKER_FILTER_ADAPTIVE),
370         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_FLICKER_FILTER_ADAPTIVE),
371         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_FLICKER_FILTER_2D),
372         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_FLICKER_FILTER_2D),
373         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_FLICKER_FILTER_2D),
374         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_SHARPNESS),
375         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SHARPNESS),
376         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_SHARPNESS),
377         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_DOT_CRAWL),
378         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_DOT_CRAWL),
379         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_TV_CHROMA_FILTER),
380         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_TV_CHROMA_FILTER),
381         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_TV_CHROMA_FILTER),
382         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_MAX_TV_LUMA_FILTER),
383         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_TV_LUMA_FILTER),
384         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_TV_LUMA_FILTER),
385
386         /* HDMI op code */
387         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_SUPP_ENCODE),
388         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_ENCODE),
389         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_ENCODE),
390         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_PIXEL_REPLI),
391         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_PIXEL_REPLI),
392         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_COLORIMETRY_CAP),
393         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_COLORIMETRY),
394         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_COLORIMETRY),
395         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_AUDIO_ENCRYPT_PREFER),
396         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_AUDIO_STAT),
397         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_AUDIO_STAT),
398         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_HBUF_INDEX),
399         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_HBUF_INDEX),
400         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_HBUF_INFO),
401         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_HBUF_AV_SPLIT),
402         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_HBUF_AV_SPLIT),
403         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_HBUF_TXRATE),
404         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_HBUF_TXRATE),
405         SDVO_CMD_NAME_ENTRY(SDVO_CMD_SET_HBUF_DATA),
406         SDVO_CMD_NAME_ENTRY(SDVO_CMD_GET_HBUF_DATA),
407 };
408
409 #define SDVO_NAME(svdo) ((svdo)->is_sdvob ? "SDVOB" : "SDVOC")
410
411 static void intel_sdvo_debug_write(struct intel_sdvo *intel_sdvo, u8 cmd,
412                                    const void *args, int args_len)
413 {
414         int i;
415
416         DRM_DEBUG_KMS("%s: W: %02X ",
417                                 SDVO_NAME(intel_sdvo), cmd);
418         for (i = 0; i < args_len; i++)
419                 DRM_LOG_KMS("%02X ", ((u8 *)args)[i]);
420         for (; i < 8; i++)
421                 DRM_LOG_KMS("   ");
422         for (i = 0; i < ARRAY_SIZE(sdvo_cmd_names); i++) {
423                 if (cmd == sdvo_cmd_names[i].cmd) {
424                         DRM_LOG_KMS("(%s)", sdvo_cmd_names[i].name);
425                         break;
426                 }
427         }
428         if (i == ARRAY_SIZE(sdvo_cmd_names))
429                 DRM_LOG_KMS("(%02X)", cmd);
430         DRM_LOG_KMS("\n");
431 }
432
433 static const char *cmd_status_names[] = {
434         "Power on",
435         "Success",
436         "Not supported",
437         "Invalid arg",
438         "Pending",
439         "Target not specified",
440         "Scaling not supported"
441 };
442
443 static bool intel_sdvo_write_cmd(struct intel_sdvo *intel_sdvo, u8 cmd,
444                                  const void *args, int args_len)
445 {
446         u8 buf[args_len*2 + 2], status;
447         struct i2c_msg msgs[args_len + 3];
448         int i, ret;
449
450         intel_sdvo_debug_write(intel_sdvo, cmd, args, args_len);
451
452         for (i = 0; i < args_len; i++) {
453                 msgs[i].addr = intel_sdvo->slave_addr;
454                 msgs[i].flags = 0;
455                 msgs[i].len = 2;
456                 msgs[i].buf = buf + 2 *i;
457                 buf[2*i + 0] = SDVO_I2C_ARG_0 - i;
458                 buf[2*i + 1] = ((u8*)args)[i];
459         }
460         msgs[i].addr = intel_sdvo->slave_addr;
461         msgs[i].flags = 0;
462         msgs[i].len = 2;
463         msgs[i].buf = buf + 2*i;
464         buf[2*i + 0] = SDVO_I2C_OPCODE;
465         buf[2*i + 1] = cmd;
466
467         /* the following two are to read the response */
468         status = SDVO_I2C_CMD_STATUS;
469         msgs[i+1].addr = intel_sdvo->slave_addr;
470         msgs[i+1].flags = 0;
471         msgs[i+1].len = 1;
472         msgs[i+1].buf = &status;
473
474         msgs[i+2].addr = intel_sdvo->slave_addr;
475         msgs[i+2].flags = I2C_M_RD;
476         msgs[i+2].len = 1;
477         msgs[i+2].buf = &status;
478
479         ret = i2c_transfer(intel_sdvo->i2c, msgs, i+3);
480         if (ret < 0) {
481                 DRM_DEBUG_KMS("I2c transfer returned %d\n", ret);
482                 return false;
483         }
484         if (ret != i+3) {
485                 /* failure in I2C transfer */
486                 DRM_DEBUG_KMS("I2c transfer returned %d/%d\n", ret, i+3);
487                 return false;
488         }
489
490         return true;
491 }
492
493 static bool intel_sdvo_read_response(struct intel_sdvo *intel_sdvo,
494                                      void *response, int response_len)
495 {
496         u8 retry = 5;
497         u8 status;
498         int i;
499
500         DRM_DEBUG_KMS("%s: R: ", SDVO_NAME(intel_sdvo));
501
502         /*
503          * The documentation states that all commands will be
504          * processed within 15µs, and that we need only poll
505          * the status byte a maximum of 3 times in order for the
506          * command to be complete.
507          *
508          * Check 5 times in case the hardware failed to read the docs.
509          */
510         if (!intel_sdvo_read_byte(intel_sdvo,
511                                   SDVO_I2C_CMD_STATUS,
512                                   &status))
513                 goto log_fail;
514
515         while (status == SDVO_CMD_STATUS_PENDING && retry--) {
516                 udelay(15);
517                 if (!intel_sdvo_read_byte(intel_sdvo,
518                                           SDVO_I2C_CMD_STATUS,
519                                           &status))
520                         goto log_fail;
521         }
522
523         if (status <= SDVO_CMD_STATUS_SCALING_NOT_SUPP)
524                 DRM_LOG_KMS("(%s)", cmd_status_names[status]);
525         else
526                 DRM_LOG_KMS("(??? %d)", status);
527
528         if (status != SDVO_CMD_STATUS_SUCCESS)
529                 goto log_fail;
530
531         /* Read the command response */
532         for (i = 0; i < response_len; i++) {
533                 if (!intel_sdvo_read_byte(intel_sdvo,
534                                           SDVO_I2C_RETURN_0 + i,
535                                           &((u8 *)response)[i]))
536                         goto log_fail;
537                 DRM_LOG_KMS(" %02X", ((u8 *)response)[i]);
538         }
539         DRM_LOG_KMS("\n");
540         return true;
541
542 log_fail:
543         DRM_LOG_KMS("... failed\n");
544         return false;
545 }
546
547 static int intel_sdvo_get_pixel_multiplier(struct drm_display_mode *mode)
548 {
549         if (mode->clock >= 100000)
550                 return 1;
551         else if (mode->clock >= 50000)
552                 return 2;
553         else
554                 return 4;
555 }
556
557 static bool intel_sdvo_set_control_bus_switch(struct intel_sdvo *intel_sdvo,
558                                               u8 ddc_bus)
559 {
560         /* This must be the immediately preceding write before the i2c xfer */
561         return intel_sdvo_write_cmd(intel_sdvo,
562                                     SDVO_CMD_SET_CONTROL_BUS_SWITCH,
563                                     &ddc_bus, 1);
564 }
565
566 static bool intel_sdvo_set_value(struct intel_sdvo *intel_sdvo, u8 cmd, const void *data, int len)
567 {
568         if (!intel_sdvo_write_cmd(intel_sdvo, cmd, data, len))
569                 return false;
570
571         return intel_sdvo_read_response(intel_sdvo, NULL, 0);
572 }
573
574 static bool
575 intel_sdvo_get_value(struct intel_sdvo *intel_sdvo, u8 cmd, void *value, int len)
576 {
577         if (!intel_sdvo_write_cmd(intel_sdvo, cmd, NULL, 0))
578                 return false;
579
580         return intel_sdvo_read_response(intel_sdvo, value, len);
581 }
582
583 static bool intel_sdvo_set_target_input(struct intel_sdvo *intel_sdvo)
584 {
585         struct intel_sdvo_set_target_input_args targets = {0};
586         return intel_sdvo_set_value(intel_sdvo,
587                                     SDVO_CMD_SET_TARGET_INPUT,
588                                     &targets, sizeof(targets));
589 }
590
591 /**
592  * Return whether each input is trained.
593  *
594  * This function is making an assumption about the layout of the response,
595  * which should be checked against the docs.
596  */
597 static bool intel_sdvo_get_trained_inputs(struct intel_sdvo *intel_sdvo, bool *input_1, bool *input_2)
598 {
599         struct intel_sdvo_get_trained_inputs_response response;
600
601         BUILD_BUG_ON(sizeof(response) != 1);
602         if (!intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_TRAINED_INPUTS,
603                                   &response, sizeof(response)))
604                 return false;
605
606         *input_1 = response.input0_trained;
607         *input_2 = response.input1_trained;
608         return true;
609 }
610
611 static bool intel_sdvo_set_active_outputs(struct intel_sdvo *intel_sdvo,
612                                           u16 outputs)
613 {
614         return intel_sdvo_set_value(intel_sdvo,
615                                     SDVO_CMD_SET_ACTIVE_OUTPUTS,
616                                     &outputs, sizeof(outputs));
617 }
618
619 static bool intel_sdvo_set_encoder_power_state(struct intel_sdvo *intel_sdvo,
620                                                int mode)
621 {
622         u8 state = SDVO_ENCODER_STATE_ON;
623
624         switch (mode) {
625         case DRM_MODE_DPMS_ON:
626                 state = SDVO_ENCODER_STATE_ON;
627                 break;
628         case DRM_MODE_DPMS_STANDBY:
629                 state = SDVO_ENCODER_STATE_STANDBY;
630                 break;
631         case DRM_MODE_DPMS_SUSPEND:
632                 state = SDVO_ENCODER_STATE_SUSPEND;
633                 break;
634         case DRM_MODE_DPMS_OFF:
635                 state = SDVO_ENCODER_STATE_OFF;
636                 break;
637         }
638
639         return intel_sdvo_set_value(intel_sdvo,
640                                     SDVO_CMD_SET_ENCODER_POWER_STATE, &state, sizeof(state));
641 }
642
643 static bool intel_sdvo_get_input_pixel_clock_range(struct intel_sdvo *intel_sdvo,
644                                                    int *clock_min,
645                                                    int *clock_max)
646 {
647         struct intel_sdvo_pixel_clock_range clocks;
648
649         BUILD_BUG_ON(sizeof(clocks) != 4);
650         if (!intel_sdvo_get_value(intel_sdvo,
651                                   SDVO_CMD_GET_INPUT_PIXEL_CLOCK_RANGE,
652                                   &clocks, sizeof(clocks)))
653                 return false;
654
655         /* Convert the values from units of 10 kHz to kHz. */
656         *clock_min = clocks.min * 10;
657         *clock_max = clocks.max * 10;
658         return true;
659 }
660
661 static bool intel_sdvo_set_target_output(struct intel_sdvo *intel_sdvo,
662                                          u16 outputs)
663 {
664         return intel_sdvo_set_value(intel_sdvo,
665                                     SDVO_CMD_SET_TARGET_OUTPUT,
666                                     &outputs, sizeof(outputs));
667 }
668
669 static bool intel_sdvo_set_timing(struct intel_sdvo *intel_sdvo, u8 cmd,
670                                   struct intel_sdvo_dtd *dtd)
671 {
672         return intel_sdvo_set_value(intel_sdvo, cmd, &dtd->part1, sizeof(dtd->part1)) &&
673                 intel_sdvo_set_value(intel_sdvo, cmd + 1, &dtd->part2, sizeof(dtd->part2));
674 }
675
676 static bool intel_sdvo_set_input_timing(struct intel_sdvo *intel_sdvo,
677                                          struct intel_sdvo_dtd *dtd)
678 {
679         return intel_sdvo_set_timing(intel_sdvo,
680                                      SDVO_CMD_SET_INPUT_TIMINGS_PART1, dtd);
681 }
682
683 static bool intel_sdvo_set_output_timing(struct intel_sdvo *intel_sdvo,
684                                          struct intel_sdvo_dtd *dtd)
685 {
686         return intel_sdvo_set_timing(intel_sdvo,
687                                      SDVO_CMD_SET_OUTPUT_TIMINGS_PART1, dtd);
688 }
689
690 static bool
691 intel_sdvo_create_preferred_input_timing(struct intel_sdvo *intel_sdvo,
692                                          uint16_t clock,
693                                          uint16_t width,
694                                          uint16_t height)
695 {
696         struct intel_sdvo_preferred_input_timing_args args;
697
698         memset(&args, 0, sizeof(args));
699         args.clock = clock;
700         args.width = width;
701         args.height = height;
702         args.interlace = 0;
703
704         if (intel_sdvo->is_lvds &&
705            (intel_sdvo->sdvo_lvds_fixed_mode->hdisplay != width ||
706             intel_sdvo->sdvo_lvds_fixed_mode->vdisplay != height))
707                 args.scaled = 1;
708
709         return intel_sdvo_set_value(intel_sdvo,
710                                     SDVO_CMD_CREATE_PREFERRED_INPUT_TIMING,
711                                     &args, sizeof(args));
712 }
713
714 static bool intel_sdvo_get_preferred_input_timing(struct intel_sdvo *intel_sdvo,
715                                                   struct intel_sdvo_dtd *dtd)
716 {
717         BUILD_BUG_ON(sizeof(dtd->part1) != 8);
718         BUILD_BUG_ON(sizeof(dtd->part2) != 8);
719         return intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_PREFERRED_INPUT_TIMING_PART1,
720                                     &dtd->part1, sizeof(dtd->part1)) &&
721                 intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_PREFERRED_INPUT_TIMING_PART2,
722                                      &dtd->part2, sizeof(dtd->part2));
723 }
724
725 static bool intel_sdvo_set_clock_rate_mult(struct intel_sdvo *intel_sdvo, u8 val)
726 {
727         return intel_sdvo_set_value(intel_sdvo, SDVO_CMD_SET_CLOCK_RATE_MULT, &val, 1);
728 }
729
730 static void intel_sdvo_get_dtd_from_mode(struct intel_sdvo_dtd *dtd,
731                                          const struct drm_display_mode *mode)
732 {
733         uint16_t width, height;
734         uint16_t h_blank_len, h_sync_len, v_blank_len, v_sync_len;
735         uint16_t h_sync_offset, v_sync_offset;
736
737         width = mode->crtc_hdisplay;
738         height = mode->crtc_vdisplay;
739
740         /* do some mode translations */
741         h_blank_len = mode->crtc_hblank_end - mode->crtc_hblank_start;
742         h_sync_len = mode->crtc_hsync_end - mode->crtc_hsync_start;
743
744         v_blank_len = mode->crtc_vblank_end - mode->crtc_vblank_start;
745         v_sync_len = mode->crtc_vsync_end - mode->crtc_vsync_start;
746
747         h_sync_offset = mode->crtc_hsync_start - mode->crtc_hblank_start;
748         v_sync_offset = mode->crtc_vsync_start - mode->crtc_vblank_start;
749
750         dtd->part1.clock = mode->clock / 10;
751         dtd->part1.h_active = width & 0xff;
752         dtd->part1.h_blank = h_blank_len & 0xff;
753         dtd->part1.h_high = (((width >> 8) & 0xf) << 4) |
754                 ((h_blank_len >> 8) & 0xf);
755         dtd->part1.v_active = height & 0xff;
756         dtd->part1.v_blank = v_blank_len & 0xff;
757         dtd->part1.v_high = (((height >> 8) & 0xf) << 4) |
758                 ((v_blank_len >> 8) & 0xf);
759
760         dtd->part2.h_sync_off = h_sync_offset & 0xff;
761         dtd->part2.h_sync_width = h_sync_len & 0xff;
762         dtd->part2.v_sync_off_width = (v_sync_offset & 0xf) << 4 |
763                 (v_sync_len & 0xf);
764         dtd->part2.sync_off_width_high = ((h_sync_offset & 0x300) >> 2) |
765                 ((h_sync_len & 0x300) >> 4) | ((v_sync_offset & 0x30) >> 2) |
766                 ((v_sync_len & 0x30) >> 4);
767
768         dtd->part2.dtd_flags = 0x18;
769         if (mode->flags & DRM_MODE_FLAG_PHSYNC)
770                 dtd->part2.dtd_flags |= 0x2;
771         if (mode->flags & DRM_MODE_FLAG_PVSYNC)
772                 dtd->part2.dtd_flags |= 0x4;
773
774         dtd->part2.sdvo_flags = 0;
775         dtd->part2.v_sync_off_high = v_sync_offset & 0xc0;
776         dtd->part2.reserved = 0;
777 }
778
779 static void intel_sdvo_get_mode_from_dtd(struct drm_display_mode * mode,
780                                          const struct intel_sdvo_dtd *dtd)
781 {
782         mode->hdisplay = dtd->part1.h_active;
783         mode->hdisplay += ((dtd->part1.h_high >> 4) & 0x0f) << 8;
784         mode->hsync_start = mode->hdisplay + dtd->part2.h_sync_off;
785         mode->hsync_start += (dtd->part2.sync_off_width_high & 0xc0) << 2;
786         mode->hsync_end = mode->hsync_start + dtd->part2.h_sync_width;
787         mode->hsync_end += (dtd->part2.sync_off_width_high & 0x30) << 4;
788         mode->htotal = mode->hdisplay + dtd->part1.h_blank;
789         mode->htotal += (dtd->part1.h_high & 0xf) << 8;
790
791         mode->vdisplay = dtd->part1.v_active;
792         mode->vdisplay += ((dtd->part1.v_high >> 4) & 0x0f) << 8;
793         mode->vsync_start = mode->vdisplay;
794         mode->vsync_start += (dtd->part2.v_sync_off_width >> 4) & 0xf;
795         mode->vsync_start += (dtd->part2.sync_off_width_high & 0x0c) << 2;
796         mode->vsync_start += dtd->part2.v_sync_off_high & 0xc0;
797         mode->vsync_end = mode->vsync_start +
798                 (dtd->part2.v_sync_off_width & 0xf);
799         mode->vsync_end += (dtd->part2.sync_off_width_high & 0x3) << 4;
800         mode->vtotal = mode->vdisplay + dtd->part1.v_blank;
801         mode->vtotal += (dtd->part1.v_high & 0xf) << 8;
802
803         mode->clock = dtd->part1.clock * 10;
804
805         mode->flags &= ~(DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC);
806         if (dtd->part2.dtd_flags & 0x2)
807                 mode->flags |= DRM_MODE_FLAG_PHSYNC;
808         if (dtd->part2.dtd_flags & 0x4)
809                 mode->flags |= DRM_MODE_FLAG_PVSYNC;
810 }
811
812 static bool intel_sdvo_check_supp_encode(struct intel_sdvo *intel_sdvo)
813 {
814         struct intel_sdvo_encode encode;
815
816         BUILD_BUG_ON(sizeof(encode) != 2);
817         return intel_sdvo_get_value(intel_sdvo,
818                                   SDVO_CMD_GET_SUPP_ENCODE,
819                                   &encode, sizeof(encode));
820 }
821
822 static bool intel_sdvo_set_encode(struct intel_sdvo *intel_sdvo,
823                                   uint8_t mode)
824 {
825         return intel_sdvo_set_value(intel_sdvo, SDVO_CMD_SET_ENCODE, &mode, 1);
826 }
827
828 static bool intel_sdvo_set_colorimetry(struct intel_sdvo *intel_sdvo,
829                                        uint8_t mode)
830 {
831         return intel_sdvo_set_value(intel_sdvo, SDVO_CMD_SET_COLORIMETRY, &mode, 1);
832 }
833
834 #if 0
835 static void intel_sdvo_dump_hdmi_buf(struct intel_sdvo *intel_sdvo)
836 {
837         int i, j;
838         uint8_t set_buf_index[2];
839         uint8_t av_split;
840         uint8_t buf_size;
841         uint8_t buf[48];
842         uint8_t *pos;
843
844         intel_sdvo_get_value(encoder, SDVO_CMD_GET_HBUF_AV_SPLIT, &av_split, 1);
845
846         for (i = 0; i <= av_split; i++) {
847                 set_buf_index[0] = i; set_buf_index[1] = 0;
848                 intel_sdvo_write_cmd(encoder, SDVO_CMD_SET_HBUF_INDEX,
849                                      set_buf_index, 2);
850                 intel_sdvo_write_cmd(encoder, SDVO_CMD_GET_HBUF_INFO, NULL, 0);
851                 intel_sdvo_read_response(encoder, &buf_size, 1);
852
853                 pos = buf;
854                 for (j = 0; j <= buf_size; j += 8) {
855                         intel_sdvo_write_cmd(encoder, SDVO_CMD_GET_HBUF_DATA,
856                                              NULL, 0);
857                         intel_sdvo_read_response(encoder, pos, 8);
858                         pos += 8;
859                 }
860         }
861 }
862 #endif
863
864 static bool intel_sdvo_set_avi_infoframe(struct intel_sdvo *intel_sdvo)
865 {
866         struct dip_infoframe avi_if = {
867                 .type = DIP_TYPE_AVI,
868                 .ver = DIP_VERSION_AVI,
869                 .len = DIP_LEN_AVI,
870         };
871         uint8_t tx_rate = SDVO_HBUF_TX_VSYNC;
872         uint8_t set_buf_index[2] = { 1, 0 };
873         uint64_t *data = (uint64_t *)&avi_if;
874         unsigned i;
875
876         intel_dip_infoframe_csum(&avi_if);
877
878         if (!intel_sdvo_set_value(intel_sdvo,
879                                   SDVO_CMD_SET_HBUF_INDEX,
880                                   set_buf_index, 2))
881                 return false;
882
883         for (i = 0; i < sizeof(avi_if); i += 8) {
884                 if (!intel_sdvo_set_value(intel_sdvo,
885                                           SDVO_CMD_SET_HBUF_DATA,
886                                           data, 8))
887                         return false;
888                 data++;
889         }
890
891         return intel_sdvo_set_value(intel_sdvo,
892                                     SDVO_CMD_SET_HBUF_TXRATE,
893                                     &tx_rate, 1);
894 }
895
896 static bool intel_sdvo_set_tv_format(struct intel_sdvo *intel_sdvo)
897 {
898         struct intel_sdvo_tv_format format;
899         uint32_t format_map;
900
901         format_map = 1 << intel_sdvo->tv_format_index;
902         memset(&format, 0, sizeof(format));
903         memcpy(&format, &format_map, min(sizeof(format), sizeof(format_map)));
904
905         BUILD_BUG_ON(sizeof(format) != 6);
906         return intel_sdvo_set_value(intel_sdvo,
907                                     SDVO_CMD_SET_TV_FORMAT,
908                                     &format, sizeof(format));
909 }
910
911 static bool
912 intel_sdvo_set_output_timings_from_mode(struct intel_sdvo *intel_sdvo,
913                                         struct drm_display_mode *mode)
914 {
915         struct intel_sdvo_dtd output_dtd;
916
917         if (!intel_sdvo_set_target_output(intel_sdvo,
918                                           intel_sdvo->attached_output))
919                 return false;
920
921         intel_sdvo_get_dtd_from_mode(&output_dtd, mode);
922         if (!intel_sdvo_set_output_timing(intel_sdvo, &output_dtd))
923                 return false;
924
925         return true;
926 }
927
928 static bool
929 intel_sdvo_set_input_timings_for_mode(struct intel_sdvo *intel_sdvo,
930                                         struct drm_display_mode *mode,
931                                         struct drm_display_mode *adjusted_mode)
932 {
933         /* Reset the input timing to the screen. Assume always input 0. */
934         if (!intel_sdvo_set_target_input(intel_sdvo))
935                 return false;
936
937         if (!intel_sdvo_create_preferred_input_timing(intel_sdvo,
938                                                       mode->clock / 10,
939                                                       mode->hdisplay,
940                                                       mode->vdisplay))
941                 return false;
942
943         if (!intel_sdvo_get_preferred_input_timing(intel_sdvo,
944                                                    &intel_sdvo->input_dtd))
945                 return false;
946
947         intel_sdvo_get_mode_from_dtd(adjusted_mode, &intel_sdvo->input_dtd);
948
949         return true;
950 }
951
952 static bool intel_sdvo_mode_fixup(struct drm_encoder *encoder,
953                                   struct drm_display_mode *mode,
954                                   struct drm_display_mode *adjusted_mode)
955 {
956         struct intel_sdvo *intel_sdvo = to_intel_sdvo(encoder);
957         int multiplier;
958
959         /* We need to construct preferred input timings based on our
960          * output timings.  To do that, we have to set the output
961          * timings, even though this isn't really the right place in
962          * the sequence to do it. Oh well.
963          */
964         if (intel_sdvo->is_tv) {
965                 if (!intel_sdvo_set_output_timings_from_mode(intel_sdvo, mode))
966                         return false;
967
968                 (void) intel_sdvo_set_input_timings_for_mode(intel_sdvo,
969                                                              mode,
970                                                              adjusted_mode);
971         } else if (intel_sdvo->is_lvds) {
972                 if (!intel_sdvo_set_output_timings_from_mode(intel_sdvo,
973                                                              intel_sdvo->sdvo_lvds_fixed_mode))
974                         return false;
975
976                 (void) intel_sdvo_set_input_timings_for_mode(intel_sdvo,
977                                                              mode,
978                                                              adjusted_mode);
979         }
980
981         /* Make the CRTC code factor in the SDVO pixel multiplier.  The
982          * SDVO device will factor out the multiplier during mode_set.
983          */
984         multiplier = intel_sdvo_get_pixel_multiplier(adjusted_mode);
985         intel_mode_set_pixel_multiplier(adjusted_mode, multiplier);
986
987         return true;
988 }
989
990 static void intel_sdvo_mode_set(struct drm_encoder *encoder,
991                                 struct drm_display_mode *mode,
992                                 struct drm_display_mode *adjusted_mode)
993 {
994         struct drm_device *dev = encoder->dev;
995         struct drm_i915_private *dev_priv = dev->dev_private;
996         struct drm_crtc *crtc = encoder->crtc;
997         struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
998         struct intel_sdvo *intel_sdvo = to_intel_sdvo(encoder);
999         u32 sdvox;
1000         struct intel_sdvo_in_out_map in_out;
1001         struct intel_sdvo_dtd input_dtd;
1002         int pixel_multiplier = intel_mode_get_pixel_multiplier(adjusted_mode);
1003         int rate;
1004
1005         if (!mode)
1006                 return;
1007
1008         /* First, set the input mapping for the first input to our controlled
1009          * output. This is only correct if we're a single-input device, in
1010          * which case the first input is the output from the appropriate SDVO
1011          * channel on the motherboard.  In a two-input device, the first input
1012          * will be SDVOB and the second SDVOC.
1013          */
1014         in_out.in0 = intel_sdvo->attached_output;
1015         in_out.in1 = 0;
1016
1017         intel_sdvo_set_value(intel_sdvo,
1018                              SDVO_CMD_SET_IN_OUT_MAP,
1019                              &in_out, sizeof(in_out));
1020
1021         /* Set the output timings to the screen */
1022         if (!intel_sdvo_set_target_output(intel_sdvo,
1023                                           intel_sdvo->attached_output))
1024                 return;
1025
1026         /* We have tried to get input timing in mode_fixup, and filled into
1027          * adjusted_mode.
1028          */
1029         if (intel_sdvo->is_tv || intel_sdvo->is_lvds) {
1030                 input_dtd = intel_sdvo->input_dtd;
1031         } else {
1032                 /* Set the output timing to the screen */
1033                 if (!intel_sdvo_set_target_output(intel_sdvo,
1034                                                   intel_sdvo->attached_output))
1035                         return;
1036
1037                 intel_sdvo_get_dtd_from_mode(&input_dtd, adjusted_mode);
1038                 (void) intel_sdvo_set_output_timing(intel_sdvo, &input_dtd);
1039         }
1040
1041         /* Set the input timing to the screen. Assume always input 0. */
1042         if (!intel_sdvo_set_target_input(intel_sdvo))
1043                 return;
1044
1045         if (intel_sdvo->has_hdmi_monitor) {
1046                 intel_sdvo_set_encode(intel_sdvo, SDVO_ENCODE_HDMI);
1047                 intel_sdvo_set_colorimetry(intel_sdvo,
1048                                            SDVO_COLORIMETRY_RGB256);
1049                 intel_sdvo_set_avi_infoframe(intel_sdvo);
1050         } else
1051                 intel_sdvo_set_encode(intel_sdvo, SDVO_ENCODE_DVI);
1052
1053         if (intel_sdvo->is_tv &&
1054             !intel_sdvo_set_tv_format(intel_sdvo))
1055                 return;
1056
1057         (void) intel_sdvo_set_input_timing(intel_sdvo, &input_dtd);
1058
1059         switch (pixel_multiplier) {
1060         default:
1061         case 1: rate = SDVO_CLOCK_RATE_MULT_1X; break;
1062         case 2: rate = SDVO_CLOCK_RATE_MULT_2X; break;
1063         case 4: rate = SDVO_CLOCK_RATE_MULT_4X; break;
1064         }
1065         if (!intel_sdvo_set_clock_rate_mult(intel_sdvo, rate))
1066                 return;
1067
1068         /* Set the SDVO control regs. */
1069         if (INTEL_INFO(dev)->gen >= 4) {
1070                 /* The real mode polarity is set by the SDVO commands, using
1071                  * struct intel_sdvo_dtd. */
1072                 sdvox = SDVO_VSYNC_ACTIVE_HIGH | SDVO_HSYNC_ACTIVE_HIGH;
1073                 if (intel_sdvo->is_hdmi)
1074                         sdvox |= intel_sdvo->color_range;
1075                 if (INTEL_INFO(dev)->gen < 5)
1076                         sdvox |= SDVO_BORDER_ENABLE;
1077         } else {
1078                 sdvox = I915_READ(intel_sdvo->sdvo_reg);
1079                 switch (intel_sdvo->sdvo_reg) {
1080                 case SDVOB:
1081                         sdvox &= SDVOB_PRESERVE_MASK;
1082                         break;
1083                 case SDVOC:
1084                         sdvox &= SDVOC_PRESERVE_MASK;
1085                         break;
1086                 }
1087                 sdvox |= (9 << 19) | SDVO_BORDER_ENABLE;
1088         }
1089
1090         if (INTEL_PCH_TYPE(dev) >= PCH_CPT)
1091                 sdvox |= TRANSCODER_CPT(intel_crtc->pipe);
1092         else
1093                 sdvox |= TRANSCODER(intel_crtc->pipe);
1094
1095         if (intel_sdvo->has_hdmi_audio)
1096                 sdvox |= SDVO_AUDIO_ENABLE;
1097
1098         if (INTEL_INFO(dev)->gen >= 4) {
1099                 /* done in crtc_mode_set as the dpll_md reg must be written early */
1100         } else if (IS_I945G(dev) || IS_I945GM(dev) || IS_G33(dev)) {
1101                 /* done in crtc_mode_set as it lives inside the dpll register */
1102         } else {
1103                 sdvox |= (pixel_multiplier - 1) << SDVO_PORT_MULTIPLY_SHIFT;
1104         }
1105
1106         if (input_dtd.part2.sdvo_flags & SDVO_NEED_TO_STALL &&
1107             INTEL_INFO(dev)->gen < 5)
1108                 sdvox |= SDVO_STALL_SELECT;
1109         intel_sdvo_write_sdvox(intel_sdvo, sdvox);
1110 }
1111
1112 static void intel_sdvo_dpms(struct drm_encoder *encoder, int mode)
1113 {
1114         struct drm_device *dev = encoder->dev;
1115         struct drm_i915_private *dev_priv = dev->dev_private;
1116         struct intel_sdvo *intel_sdvo = to_intel_sdvo(encoder);
1117         struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc);
1118         u32 temp;
1119
1120         if (mode != DRM_MODE_DPMS_ON) {
1121                 intel_sdvo_set_active_outputs(intel_sdvo, 0);
1122                 if (0)
1123                         intel_sdvo_set_encoder_power_state(intel_sdvo, mode);
1124
1125                 if (mode == DRM_MODE_DPMS_OFF) {
1126                         temp = I915_READ(intel_sdvo->sdvo_reg);
1127                         if ((temp & SDVO_ENABLE) != 0) {
1128                                 intel_sdvo_write_sdvox(intel_sdvo, temp & ~SDVO_ENABLE);
1129                         }
1130                 }
1131         } else {
1132                 bool input1, input2;
1133                 int i;
1134                 u8 status;
1135
1136                 temp = I915_READ(intel_sdvo->sdvo_reg);
1137                 if ((temp & SDVO_ENABLE) == 0)
1138                         intel_sdvo_write_sdvox(intel_sdvo, temp | SDVO_ENABLE);
1139                 for (i = 0; i < 2; i++)
1140                         intel_wait_for_vblank(dev, intel_crtc->pipe);
1141
1142                 status = intel_sdvo_get_trained_inputs(intel_sdvo, &input1, &input2);
1143                 /* Warn if the device reported failure to sync.
1144                  * A lot of SDVO devices fail to notify of sync, but it's
1145                  * a given it the status is a success, we succeeded.
1146                  */
1147                 if (status == SDVO_CMD_STATUS_SUCCESS && !input1) {
1148                         DRM_DEBUG_KMS("First %s output reported failure to "
1149                                         "sync\n", SDVO_NAME(intel_sdvo));
1150                 }
1151
1152                 if (0)
1153                         intel_sdvo_set_encoder_power_state(intel_sdvo, mode);
1154                 intel_sdvo_set_active_outputs(intel_sdvo, intel_sdvo->attached_output);
1155         }
1156         return;
1157 }
1158
1159 static int intel_sdvo_mode_valid(struct drm_connector *connector,
1160                                  struct drm_display_mode *mode)
1161 {
1162         struct intel_sdvo *intel_sdvo = intel_attached_sdvo(connector);
1163
1164         if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
1165                 return MODE_NO_DBLESCAN;
1166
1167         if (intel_sdvo->pixel_clock_min > mode->clock)
1168                 return MODE_CLOCK_LOW;
1169
1170         if (intel_sdvo->pixel_clock_max < mode->clock)
1171                 return MODE_CLOCK_HIGH;
1172
1173         if (intel_sdvo->is_lvds) {
1174                 if (mode->hdisplay > intel_sdvo->sdvo_lvds_fixed_mode->hdisplay)
1175                         return MODE_PANEL;
1176
1177                 if (mode->vdisplay > intel_sdvo->sdvo_lvds_fixed_mode->vdisplay)
1178                         return MODE_PANEL;
1179         }
1180
1181         return MODE_OK;
1182 }
1183
1184 static bool intel_sdvo_get_capabilities(struct intel_sdvo *intel_sdvo, struct intel_sdvo_caps *caps)
1185 {
1186         BUILD_BUG_ON(sizeof(*caps) != 8);
1187         if (!intel_sdvo_get_value(intel_sdvo,
1188                                   SDVO_CMD_GET_DEVICE_CAPS,
1189                                   caps, sizeof(*caps)))
1190                 return false;
1191
1192         DRM_DEBUG_KMS("SDVO capabilities:\n"
1193                       "  vendor_id: %d\n"
1194                       "  device_id: %d\n"
1195                       "  device_rev_id: %d\n"
1196                       "  sdvo_version_major: %d\n"
1197                       "  sdvo_version_minor: %d\n"
1198                       "  sdvo_inputs_mask: %d\n"
1199                       "  smooth_scaling: %d\n"
1200                       "  sharp_scaling: %d\n"
1201                       "  up_scaling: %d\n"
1202                       "  down_scaling: %d\n"
1203                       "  stall_support: %d\n"
1204                       "  output_flags: %d\n",
1205                       caps->vendor_id,
1206                       caps->device_id,
1207                       caps->device_rev_id,
1208                       caps->sdvo_version_major,
1209                       caps->sdvo_version_minor,
1210                       caps->sdvo_inputs_mask,
1211                       caps->smooth_scaling,
1212                       caps->sharp_scaling,
1213                       caps->up_scaling,
1214                       caps->down_scaling,
1215                       caps->stall_support,
1216                       caps->output_flags);
1217
1218         return true;
1219 }
1220
1221 static int intel_sdvo_supports_hotplug(struct intel_sdvo *intel_sdvo)
1222 {
1223         u8 response[2];
1224
1225         return intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_HOT_PLUG_SUPPORT,
1226                                     &response, 2) && response[0];
1227 }
1228
1229 static void intel_sdvo_enable_hotplug(struct intel_encoder *encoder)
1230 {
1231         struct intel_sdvo *intel_sdvo = to_intel_sdvo(&encoder->base);
1232
1233         intel_sdvo_write_cmd(intel_sdvo, SDVO_CMD_SET_ACTIVE_HOT_PLUG, &intel_sdvo->hotplug_active, 2);
1234 }
1235
1236 static bool
1237 intel_sdvo_multifunc_encoder(struct intel_sdvo *intel_sdvo)
1238 {
1239         /* Is there more than one type of output? */
1240         return hweight16(intel_sdvo->caps.output_flags) > 1;
1241 }
1242
1243 static struct edid *
1244 intel_sdvo_get_edid(struct drm_connector *connector)
1245 {
1246         struct intel_sdvo *sdvo = intel_attached_sdvo(connector);
1247         return drm_get_edid(connector, &sdvo->ddc);
1248 }
1249
1250 /* Mac mini hack -- use the same DDC as the analog connector */
1251 static struct edid *
1252 intel_sdvo_get_analog_edid(struct drm_connector *connector)
1253 {
1254         struct drm_i915_private *dev_priv = connector->dev->dev_private;
1255
1256         return drm_get_edid(connector,
1257                             intel_gmbus_get_adapter(dev_priv,
1258                                                     dev_priv->crt_ddc_pin));
1259 }
1260
1261 enum drm_connector_status
1262 intel_sdvo_tmds_sink_detect(struct drm_connector *connector)
1263 {
1264         struct intel_sdvo *intel_sdvo = intel_attached_sdvo(connector);
1265         enum drm_connector_status status;
1266         struct edid *edid;
1267
1268         edid = intel_sdvo_get_edid(connector);
1269
1270         if (edid == NULL && intel_sdvo_multifunc_encoder(intel_sdvo)) {
1271                 u8 ddc, saved_ddc = intel_sdvo->ddc_bus;
1272
1273                 /*
1274                  * Don't use the 1 as the argument of DDC bus switch to get
1275                  * the EDID. It is used for SDVO SPD ROM.
1276                  */
1277                 for (ddc = intel_sdvo->ddc_bus >> 1; ddc > 1; ddc >>= 1) {
1278                         intel_sdvo->ddc_bus = ddc;
1279                         edid = intel_sdvo_get_edid(connector);
1280                         if (edid)
1281                                 break;
1282                 }
1283                 /*
1284                  * If we found the EDID on the other bus,
1285                  * assume that is the correct DDC bus.
1286                  */
1287                 if (edid == NULL)
1288                         intel_sdvo->ddc_bus = saved_ddc;
1289         }
1290
1291         /*
1292          * When there is no edid and no monitor is connected with VGA
1293          * port, try to use the CRT ddc to read the EDID for DVI-connector.
1294          */
1295         if (edid == NULL)
1296                 edid = intel_sdvo_get_analog_edid(connector);
1297
1298         status = connector_status_unknown;
1299         if (edid != NULL) {
1300                 /* DDC bus is shared, match EDID to connector type */
1301                 if (edid->input & DRM_EDID_INPUT_DIGITAL) {
1302                         status = connector_status_connected;
1303                         if (intel_sdvo->is_hdmi) {
1304                                 intel_sdvo->has_hdmi_monitor = drm_detect_hdmi_monitor(edid);
1305                                 intel_sdvo->has_hdmi_audio = drm_detect_monitor_audio(edid);
1306                         }
1307                 } else
1308                         status = connector_status_disconnected;
1309                 connector->display_info.raw_edid = NULL;
1310                 kfree(edid);
1311         }
1312
1313         if (status == connector_status_connected) {
1314                 struct intel_sdvo_connector *intel_sdvo_connector = to_intel_sdvo_connector(connector);
1315                 if (intel_sdvo_connector->force_audio != HDMI_AUDIO_AUTO)
1316                         intel_sdvo->has_hdmi_audio = (intel_sdvo_connector->force_audio == HDMI_AUDIO_ON);
1317         }
1318
1319         return status;
1320 }
1321
1322 static bool
1323 intel_sdvo_connector_matches_edid(struct intel_sdvo_connector *sdvo,
1324                                   struct edid *edid)
1325 {
1326         bool monitor_is_digital = !!(edid->input & DRM_EDID_INPUT_DIGITAL);
1327         bool connector_is_digital = !!IS_DIGITAL(sdvo);
1328
1329         DRM_DEBUG_KMS("connector_is_digital? %d, monitor_is_digital? %d\n",
1330                       connector_is_digital, monitor_is_digital);
1331         return connector_is_digital == monitor_is_digital;
1332 }
1333
1334 static enum drm_connector_status
1335 intel_sdvo_detect(struct drm_connector *connector, bool force)
1336 {
1337         uint16_t response;
1338         struct intel_sdvo *intel_sdvo = intel_attached_sdvo(connector);
1339         struct intel_sdvo_connector *intel_sdvo_connector = to_intel_sdvo_connector(connector);
1340         enum drm_connector_status ret;
1341
1342         if (!intel_sdvo_write_cmd(intel_sdvo,
1343                                   SDVO_CMD_GET_ATTACHED_DISPLAYS, NULL, 0))
1344                 return connector_status_unknown;
1345
1346         /* add 30ms delay when the output type might be TV */
1347         if (intel_sdvo->caps.output_flags & SDVO_TV_MASK)
1348                 mdelay(30);
1349
1350         if (!intel_sdvo_read_response(intel_sdvo, &response, 2))
1351                 return connector_status_unknown;
1352
1353         DRM_DEBUG_KMS("SDVO response %d %d [%x]\n",
1354                       response & 0xff, response >> 8,
1355                       intel_sdvo_connector->output_flag);
1356
1357         if (response == 0)
1358                 return connector_status_disconnected;
1359
1360         intel_sdvo->attached_output = response;
1361
1362         intel_sdvo->has_hdmi_monitor = false;
1363         intel_sdvo->has_hdmi_audio = false;
1364
1365         if ((intel_sdvo_connector->output_flag & response) == 0)
1366                 ret = connector_status_disconnected;
1367         else if (IS_TMDS(intel_sdvo_connector))
1368                 ret = intel_sdvo_tmds_sink_detect(connector);
1369         else {
1370                 struct edid *edid;
1371
1372                 /* if we have an edid check it matches the connection */
1373                 edid = intel_sdvo_get_edid(connector);
1374                 if (edid == NULL)
1375                         edid = intel_sdvo_get_analog_edid(connector);
1376                 if (edid != NULL) {
1377                         if (intel_sdvo_connector_matches_edid(intel_sdvo_connector,
1378                                                               edid))
1379                                 ret = connector_status_connected;
1380                         else
1381                                 ret = connector_status_disconnected;
1382
1383                         connector->display_info.raw_edid = NULL;
1384                         kfree(edid);
1385                 } else
1386                         ret = connector_status_connected;
1387         }
1388
1389         /* May update encoder flag for like clock for SDVO TV, etc.*/
1390         if (ret == connector_status_connected) {
1391                 intel_sdvo->is_tv = false;
1392                 intel_sdvo->is_lvds = false;
1393                 intel_sdvo->base.needs_tv_clock = false;
1394
1395                 if (response & SDVO_TV_MASK) {
1396                         intel_sdvo->is_tv = true;
1397                         intel_sdvo->base.needs_tv_clock = true;
1398                 }
1399                 if (response & SDVO_LVDS_MASK)
1400                         intel_sdvo->is_lvds = intel_sdvo->sdvo_lvds_fixed_mode != NULL;
1401         }
1402
1403         return ret;
1404 }
1405
1406 static void intel_sdvo_get_ddc_modes(struct drm_connector *connector)
1407 {
1408         struct edid *edid;
1409
1410         /* set the bus switch and get the modes */
1411         edid = intel_sdvo_get_edid(connector);
1412
1413         /*
1414          * Mac mini hack.  On this device, the DVI-I connector shares one DDC
1415          * link between analog and digital outputs. So, if the regular SDVO
1416          * DDC fails, check to see if the analog output is disconnected, in
1417          * which case we'll look there for the digital DDC data.
1418          */
1419         if (edid == NULL)
1420                 edid = intel_sdvo_get_analog_edid(connector);
1421
1422         if (edid != NULL) {
1423                 if (intel_sdvo_connector_matches_edid(to_intel_sdvo_connector(connector),
1424                                                       edid)) {
1425                         drm_mode_connector_update_edid_property(connector, edid);
1426                         drm_add_edid_modes(connector, edid);
1427                 }
1428
1429                 connector->display_info.raw_edid = NULL;
1430                 kfree(edid);
1431         }
1432 }
1433
1434 /*
1435  * Set of SDVO TV modes.
1436  * Note!  This is in reply order (see loop in get_tv_modes).
1437  * XXX: all 60Hz refresh?
1438  */
1439 static const struct drm_display_mode sdvo_tv_modes[] = {
1440         { DRM_MODE("320x200", DRM_MODE_TYPE_DRIVER, 5815, 320, 321, 384,
1441                    416, 0, 200, 201, 232, 233, 0,
1442                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1443         { DRM_MODE("320x240", DRM_MODE_TYPE_DRIVER, 6814, 320, 321, 384,
1444                    416, 0, 240, 241, 272, 273, 0,
1445                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1446         { DRM_MODE("400x300", DRM_MODE_TYPE_DRIVER, 9910, 400, 401, 464,
1447                    496, 0, 300, 301, 332, 333, 0,
1448                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1449         { DRM_MODE("640x350", DRM_MODE_TYPE_DRIVER, 16913, 640, 641, 704,
1450                    736, 0, 350, 351, 382, 383, 0,
1451                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1452         { DRM_MODE("640x400", DRM_MODE_TYPE_DRIVER, 19121, 640, 641, 704,
1453                    736, 0, 400, 401, 432, 433, 0,
1454                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1455         { DRM_MODE("640x480", DRM_MODE_TYPE_DRIVER, 22654, 640, 641, 704,
1456                    736, 0, 480, 481, 512, 513, 0,
1457                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1458         { DRM_MODE("704x480", DRM_MODE_TYPE_DRIVER, 24624, 704, 705, 768,
1459                    800, 0, 480, 481, 512, 513, 0,
1460                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1461         { DRM_MODE("704x576", DRM_MODE_TYPE_DRIVER, 29232, 704, 705, 768,
1462                    800, 0, 576, 577, 608, 609, 0,
1463                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1464         { DRM_MODE("720x350", DRM_MODE_TYPE_DRIVER, 18751, 720, 721, 784,
1465                    816, 0, 350, 351, 382, 383, 0,
1466                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1467         { DRM_MODE("720x400", DRM_MODE_TYPE_DRIVER, 21199, 720, 721, 784,
1468                    816, 0, 400, 401, 432, 433, 0,
1469                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1470         { DRM_MODE("720x480", DRM_MODE_TYPE_DRIVER, 25116, 720, 721, 784,
1471                    816, 0, 480, 481, 512, 513, 0,
1472                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1473         { DRM_MODE("720x540", DRM_MODE_TYPE_DRIVER, 28054, 720, 721, 784,
1474                    816, 0, 540, 541, 572, 573, 0,
1475                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1476         { DRM_MODE("720x576", DRM_MODE_TYPE_DRIVER, 29816, 720, 721, 784,
1477                    816, 0, 576, 577, 608, 609, 0,
1478                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1479         { DRM_MODE("768x576", DRM_MODE_TYPE_DRIVER, 31570, 768, 769, 832,
1480                    864, 0, 576, 577, 608, 609, 0,
1481                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1482         { DRM_MODE("800x600", DRM_MODE_TYPE_DRIVER, 34030, 800, 801, 864,
1483                    896, 0, 600, 601, 632, 633, 0,
1484                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1485         { DRM_MODE("832x624", DRM_MODE_TYPE_DRIVER, 36581, 832, 833, 896,
1486                    928, 0, 624, 625, 656, 657, 0,
1487                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1488         { DRM_MODE("920x766", DRM_MODE_TYPE_DRIVER, 48707, 920, 921, 984,
1489                    1016, 0, 766, 767, 798, 799, 0,
1490                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1491         { DRM_MODE("1024x768", DRM_MODE_TYPE_DRIVER, 53827, 1024, 1025, 1088,
1492                    1120, 0, 768, 769, 800, 801, 0,
1493                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1494         { DRM_MODE("1280x1024", DRM_MODE_TYPE_DRIVER, 87265, 1280, 1281, 1344,
1495                    1376, 0, 1024, 1025, 1056, 1057, 0,
1496                    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
1497 };
1498
1499 static void intel_sdvo_get_tv_modes(struct drm_connector *connector)
1500 {
1501         struct intel_sdvo *intel_sdvo = intel_attached_sdvo(connector);
1502         struct intel_sdvo_sdtv_resolution_request tv_res;
1503         uint32_t reply = 0, format_map = 0;
1504         int i;
1505
1506         /* Read the list of supported input resolutions for the selected TV
1507          * format.
1508          */
1509         format_map = 1 << intel_sdvo->tv_format_index;
1510         memcpy(&tv_res, &format_map,
1511                min(sizeof(format_map), sizeof(struct intel_sdvo_sdtv_resolution_request)));
1512
1513         if (!intel_sdvo_set_target_output(intel_sdvo, intel_sdvo->attached_output))
1514                 return;
1515
1516         BUILD_BUG_ON(sizeof(tv_res) != 3);
1517         if (!intel_sdvo_write_cmd(intel_sdvo,
1518                                   SDVO_CMD_GET_SDTV_RESOLUTION_SUPPORT,
1519                                   &tv_res, sizeof(tv_res)))
1520                 return;
1521         if (!intel_sdvo_read_response(intel_sdvo, &reply, 3))
1522                 return;
1523
1524         for (i = 0; i < ARRAY_SIZE(sdvo_tv_modes); i++)
1525                 if (reply & (1 << i)) {
1526                         struct drm_display_mode *nmode;
1527                         nmode = drm_mode_duplicate(connector->dev,
1528                                                    &sdvo_tv_modes[i]);
1529                         if (nmode)
1530                                 drm_mode_probed_add(connector, nmode);
1531                 }
1532 }
1533
1534 static void intel_sdvo_get_lvds_modes(struct drm_connector *connector)
1535 {
1536         struct intel_sdvo *intel_sdvo = intel_attached_sdvo(connector);
1537         struct drm_i915_private *dev_priv = connector->dev->dev_private;
1538         struct drm_display_mode *newmode;
1539
1540         /*
1541          * Attempt to get the mode list from DDC.
1542          * Assume that the preferred modes are
1543          * arranged in priority order.
1544          */
1545         intel_ddc_get_modes(connector, intel_sdvo->i2c);
1546         if (list_empty(&connector->probed_modes) == false)
1547                 goto end;
1548
1549         /* Fetch modes from VBT */
1550         if (dev_priv->sdvo_lvds_vbt_mode != NULL) {
1551                 newmode = drm_mode_duplicate(connector->dev,
1552                                              dev_priv->sdvo_lvds_vbt_mode);
1553                 if (newmode != NULL) {
1554                         /* Guarantee the mode is preferred */
1555                         newmode->type = (DRM_MODE_TYPE_PREFERRED |
1556                                          DRM_MODE_TYPE_DRIVER);
1557                         drm_mode_probed_add(connector, newmode);
1558                 }
1559         }
1560
1561 end:
1562         list_for_each_entry(newmode, &connector->probed_modes, head) {
1563                 if (newmode->type & DRM_MODE_TYPE_PREFERRED) {
1564                         intel_sdvo->sdvo_lvds_fixed_mode =
1565                                 drm_mode_duplicate(connector->dev, newmode);
1566
1567                         drm_mode_set_crtcinfo(intel_sdvo->sdvo_lvds_fixed_mode,
1568                                               0);
1569
1570                         intel_sdvo->is_lvds = true;
1571                         break;
1572                 }
1573         }
1574
1575 }
1576
1577 static int intel_sdvo_get_modes(struct drm_connector *connector)
1578 {
1579         struct intel_sdvo_connector *intel_sdvo_connector = to_intel_sdvo_connector(connector);
1580
1581         if (IS_TV(intel_sdvo_connector))
1582                 intel_sdvo_get_tv_modes(connector);
1583         else if (IS_LVDS(intel_sdvo_connector))
1584                 intel_sdvo_get_lvds_modes(connector);
1585         else
1586                 intel_sdvo_get_ddc_modes(connector);
1587
1588         return !list_empty(&connector->probed_modes);
1589 }
1590
1591 static void
1592 intel_sdvo_destroy_enhance_property(struct drm_connector *connector)
1593 {
1594         struct intel_sdvo_connector *intel_sdvo_connector = to_intel_sdvo_connector(connector);
1595         struct drm_device *dev = connector->dev;
1596
1597         if (intel_sdvo_connector->left)
1598                 drm_property_destroy(dev, intel_sdvo_connector->left);
1599         if (intel_sdvo_connector->right)
1600                 drm_property_destroy(dev, intel_sdvo_connector->right);
1601         if (intel_sdvo_connector->top)
1602                 drm_property_destroy(dev, intel_sdvo_connector->top);
1603         if (intel_sdvo_connector->bottom)
1604                 drm_property_destroy(dev, intel_sdvo_connector->bottom);
1605         if (intel_sdvo_connector->hpos)
1606                 drm_property_destroy(dev, intel_sdvo_connector->hpos);
1607         if (intel_sdvo_connector->vpos)
1608                 drm_property_destroy(dev, intel_sdvo_connector->vpos);
1609         if (intel_sdvo_connector->saturation)
1610                 drm_property_destroy(dev, intel_sdvo_connector->saturation);
1611         if (intel_sdvo_connector->contrast)
1612                 drm_property_destroy(dev, intel_sdvo_connector->contrast);
1613         if (intel_sdvo_connector->hue)
1614                 drm_property_destroy(dev, intel_sdvo_connector->hue);
1615         if (intel_sdvo_connector->sharpness)
1616                 drm_property_destroy(dev, intel_sdvo_connector->sharpness);
1617         if (intel_sdvo_connector->flicker_filter)
1618                 drm_property_destroy(dev, intel_sdvo_connector->flicker_filter);
1619         if (intel_sdvo_connector->flicker_filter_2d)
1620                 drm_property_destroy(dev, intel_sdvo_connector->flicker_filter_2d);
1621         if (intel_sdvo_connector->flicker_filter_adaptive)
1622                 drm_property_destroy(dev, intel_sdvo_connector->flicker_filter_adaptive);
1623         if (intel_sdvo_connector->tv_luma_filter)
1624                 drm_property_destroy(dev, intel_sdvo_connector->tv_luma_filter);
1625         if (intel_sdvo_connector->tv_chroma_filter)
1626                 drm_property_destroy(dev, intel_sdvo_connector->tv_chroma_filter);
1627         if (intel_sdvo_connector->dot_crawl)
1628                 drm_property_destroy(dev, intel_sdvo_connector->dot_crawl);
1629         if (intel_sdvo_connector->brightness)
1630                 drm_property_destroy(dev, intel_sdvo_connector->brightness);
1631 }
1632
1633 static void intel_sdvo_destroy(struct drm_connector *connector)
1634 {
1635         struct intel_sdvo_connector *intel_sdvo_connector = to_intel_sdvo_connector(connector);
1636
1637         if (intel_sdvo_connector->tv_format)
1638                 drm_property_destroy(connector->dev,
1639                                      intel_sdvo_connector->tv_format);
1640
1641         intel_sdvo_destroy_enhance_property(connector);
1642         drm_sysfs_connector_remove(connector);
1643         drm_connector_cleanup(connector);
1644         kfree(connector);
1645 }
1646
1647 static bool intel_sdvo_detect_hdmi_audio(struct drm_connector *connector)
1648 {
1649         struct intel_sdvo *intel_sdvo = intel_attached_sdvo(connector);
1650         struct edid *edid;
1651         bool has_audio = false;
1652
1653         if (!intel_sdvo->is_hdmi)
1654                 return false;
1655
1656         edid = intel_sdvo_get_edid(connector);
1657         if (edid != NULL && edid->input & DRM_EDID_INPUT_DIGITAL)
1658                 has_audio = drm_detect_monitor_audio(edid);
1659
1660         return has_audio;
1661 }
1662
1663 static int
1664 intel_sdvo_set_property(struct drm_connector *connector,
1665                         struct drm_property *property,
1666                         uint64_t val)
1667 {
1668         struct intel_sdvo *intel_sdvo = intel_attached_sdvo(connector);
1669         struct intel_sdvo_connector *intel_sdvo_connector = to_intel_sdvo_connector(connector);
1670         struct drm_i915_private *dev_priv = connector->dev->dev_private;
1671         uint16_t temp_value;
1672         uint8_t cmd;
1673         int ret;
1674
1675         ret = drm_connector_property_set_value(connector, property, val);
1676         if (ret)
1677                 return ret;
1678
1679         if (property == dev_priv->force_audio_property) {
1680                 int i = val;
1681                 bool has_audio;
1682
1683                 if (i == intel_sdvo_connector->force_audio)
1684                         return 0;
1685
1686                 intel_sdvo_connector->force_audio = i;
1687
1688                 if (i == HDMI_AUDIO_AUTO)
1689                         has_audio = intel_sdvo_detect_hdmi_audio(connector);
1690                 else
1691                         has_audio = (i == HDMI_AUDIO_ON);
1692
1693                 if (has_audio == intel_sdvo->has_hdmi_audio)
1694                         return 0;
1695
1696                 intel_sdvo->has_hdmi_audio = has_audio;
1697                 goto done;
1698         }
1699
1700         if (property == dev_priv->broadcast_rgb_property) {
1701                 if (val == !!intel_sdvo->color_range)
1702                         return 0;
1703
1704                 intel_sdvo->color_range = val ? SDVO_COLOR_RANGE_16_235 : 0;
1705                 goto done;
1706         }
1707
1708 #define CHECK_PROPERTY(name, NAME) \
1709         if (intel_sdvo_connector->name == property) { \
1710                 if (intel_sdvo_connector->cur_##name == temp_value) return 0; \
1711                 if (intel_sdvo_connector->max_##name < temp_value) return -EINVAL; \
1712                 cmd = SDVO_CMD_SET_##NAME; \
1713                 intel_sdvo_connector->cur_##name = temp_value; \
1714                 goto set_value; \
1715         }
1716
1717         if (property == intel_sdvo_connector->tv_format) {
1718                 if (val >= TV_FORMAT_NUM)
1719                         return -EINVAL;
1720
1721                 if (intel_sdvo->tv_format_index ==
1722                     intel_sdvo_connector->tv_format_supported[val])
1723                         return 0;
1724
1725                 intel_sdvo->tv_format_index = intel_sdvo_connector->tv_format_supported[val];
1726                 goto done;
1727         } else if (IS_TV_OR_LVDS(intel_sdvo_connector)) {
1728                 temp_value = val;
1729                 if (intel_sdvo_connector->left == property) {
1730                         drm_connector_property_set_value(connector,
1731                                                          intel_sdvo_connector->right, val);
1732                         if (intel_sdvo_connector->left_margin == temp_value)
1733                                 return 0;
1734
1735                         intel_sdvo_connector->left_margin = temp_value;
1736                         intel_sdvo_connector->right_margin = temp_value;
1737                         temp_value = intel_sdvo_connector->max_hscan -
1738                                 intel_sdvo_connector->left_margin;
1739                         cmd = SDVO_CMD_SET_OVERSCAN_H;
1740                         goto set_value;
1741                 } else if (intel_sdvo_connector->right == property) {
1742                         drm_connector_property_set_value(connector,
1743                                                          intel_sdvo_connector->left, val);
1744                         if (intel_sdvo_connector->right_margin == temp_value)
1745                                 return 0;
1746
1747                         intel_sdvo_connector->left_margin = temp_value;
1748                         intel_sdvo_connector->right_margin = temp_value;
1749                         temp_value = intel_sdvo_connector->max_hscan -
1750                                 intel_sdvo_connector->left_margin;
1751                         cmd = SDVO_CMD_SET_OVERSCAN_H;
1752                         goto set_value;
1753                 } else if (intel_sdvo_connector->top == property) {
1754                         drm_connector_property_set_value(connector,
1755                                                          intel_sdvo_connector->bottom, val);
1756                         if (intel_sdvo_connector->top_margin == temp_value)
1757                                 return 0;
1758
1759                         intel_sdvo_connector->top_margin = temp_value;
1760                         intel_sdvo_connector->bottom_margin = temp_value;
1761                         temp_value = intel_sdvo_connector->max_vscan -
1762                                 intel_sdvo_connector->top_margin;
1763                         cmd = SDVO_CMD_SET_OVERSCAN_V;
1764                         goto set_value;
1765                 } else if (intel_sdvo_connector->bottom == property) {
1766                         drm_connector_property_set_value(connector,
1767                                                          intel_sdvo_connector->top, val);
1768                         if (intel_sdvo_connector->bottom_margin == temp_value)
1769                                 return 0;
1770
1771                         intel_sdvo_connector->top_margin = temp_value;
1772                         intel_sdvo_connector->bottom_margin = temp_value;
1773                         temp_value = intel_sdvo_connector->max_vscan -
1774                                 intel_sdvo_connector->top_margin;
1775                         cmd = SDVO_CMD_SET_OVERSCAN_V;
1776                         goto set_value;
1777                 }
1778                 CHECK_PROPERTY(hpos, HPOS)
1779                 CHECK_PROPERTY(vpos, VPOS)
1780                 CHECK_PROPERTY(saturation, SATURATION)
1781                 CHECK_PROPERTY(contrast, CONTRAST)
1782                 CHECK_PROPERTY(hue, HUE)
1783                 CHECK_PROPERTY(brightness, BRIGHTNESS)
1784                 CHECK_PROPERTY(sharpness, SHARPNESS)
1785                 CHECK_PROPERTY(flicker_filter, FLICKER_FILTER)
1786                 CHECK_PROPERTY(flicker_filter_2d, FLICKER_FILTER_2D)
1787                 CHECK_PROPERTY(flicker_filter_adaptive, FLICKER_FILTER_ADAPTIVE)
1788                 CHECK_PROPERTY(tv_chroma_filter, TV_CHROMA_FILTER)
1789                 CHECK_PROPERTY(tv_luma_filter, TV_LUMA_FILTER)
1790                 CHECK_PROPERTY(dot_crawl, DOT_CRAWL)
1791         }
1792
1793         return -EINVAL; /* unknown property */
1794
1795 set_value:
1796         if (!intel_sdvo_set_value(intel_sdvo, cmd, &temp_value, 2))
1797                 return -EIO;
1798
1799
1800 done:
1801         if (intel_sdvo->base.base.crtc) {
1802                 struct drm_crtc *crtc = intel_sdvo->base.base.crtc;
1803                 drm_crtc_helper_set_mode(crtc, &crtc->mode, crtc->x,
1804                                          crtc->y, crtc->fb);
1805         }
1806
1807         return 0;
1808 #undef CHECK_PROPERTY
1809 }
1810
1811 static const struct drm_encoder_helper_funcs intel_sdvo_helper_funcs = {
1812         .dpms = intel_sdvo_dpms,
1813         .mode_fixup = intel_sdvo_mode_fixup,
1814         .prepare = intel_encoder_prepare,
1815         .mode_set = intel_sdvo_mode_set,
1816         .commit = intel_encoder_commit,
1817 };
1818
1819 static const struct drm_connector_funcs intel_sdvo_connector_funcs = {
1820         .dpms = drm_helper_connector_dpms,
1821         .detect = intel_sdvo_detect,
1822         .fill_modes = drm_helper_probe_single_connector_modes,
1823         .set_property = intel_sdvo_set_property,
1824         .destroy = intel_sdvo_destroy,
1825 };
1826
1827 static const struct drm_connector_helper_funcs intel_sdvo_connector_helper_funcs = {
1828         .get_modes = intel_sdvo_get_modes,
1829         .mode_valid = intel_sdvo_mode_valid,
1830         .best_encoder = intel_best_encoder,
1831 };
1832
1833 static void intel_sdvo_enc_destroy(struct drm_encoder *encoder)
1834 {
1835         struct intel_sdvo *intel_sdvo = to_intel_sdvo(encoder);
1836
1837         if (intel_sdvo->sdvo_lvds_fixed_mode != NULL)
1838                 drm_mode_destroy(encoder->dev,
1839                                  intel_sdvo->sdvo_lvds_fixed_mode);
1840
1841         i2c_del_adapter(&intel_sdvo->ddc);
1842         intel_encoder_destroy(encoder);
1843 }
1844
1845 static const struct drm_encoder_funcs intel_sdvo_enc_funcs = {
1846         .destroy = intel_sdvo_enc_destroy,
1847 };
1848
1849 static void
1850 intel_sdvo_guess_ddc_bus(struct intel_sdvo *sdvo)
1851 {
1852         uint16_t mask = 0;
1853         unsigned int num_bits;
1854
1855         /* Make a mask of outputs less than or equal to our own priority in the
1856          * list.
1857          */
1858         switch (sdvo->controlled_output) {
1859         case SDVO_OUTPUT_LVDS1:
1860                 mask |= SDVO_OUTPUT_LVDS1;
1861         case SDVO_OUTPUT_LVDS0:
1862                 mask |= SDVO_OUTPUT_LVDS0;
1863         case SDVO_OUTPUT_TMDS1:
1864                 mask |= SDVO_OUTPUT_TMDS1;
1865         case SDVO_OUTPUT_TMDS0:
1866                 mask |= SDVO_OUTPUT_TMDS0;
1867         case SDVO_OUTPUT_RGB1:
1868                 mask |= SDVO_OUTPUT_RGB1;
1869         case SDVO_OUTPUT_RGB0:
1870                 mask |= SDVO_OUTPUT_RGB0;
1871                 break;
1872         }
1873
1874         /* Count bits to find what number we are in the priority list. */
1875         mask &= sdvo->caps.output_flags;
1876         num_bits = hweight16(mask);
1877         /* If more than 3 outputs, default to DDC bus 3 for now. */
1878         if (num_bits > 3)
1879                 num_bits = 3;
1880
1881         /* Corresponds to SDVO_CONTROL_BUS_DDCx */
1882         sdvo->ddc_bus = 1 << num_bits;
1883 }
1884
1885 /**
1886  * Choose the appropriate DDC bus for control bus switch command for this
1887  * SDVO output based on the controlled output.
1888  *
1889  * DDC bus number assignment is in a priority order of RGB outputs, then TMDS
1890  * outputs, then LVDS outputs.
1891  */
1892 static void
1893 intel_sdvo_select_ddc_bus(struct drm_i915_private *dev_priv,
1894                           struct intel_sdvo *sdvo, u32 reg)
1895 {
1896         struct sdvo_device_mapping *mapping;
1897
1898         if (sdvo->is_sdvob)
1899                 mapping = &(dev_priv->sdvo_mappings[0]);
1900         else
1901                 mapping = &(dev_priv->sdvo_mappings[1]);
1902
1903         if (mapping->initialized)
1904                 sdvo->ddc_bus = 1 << ((mapping->ddc_pin & 0xf0) >> 4);
1905         else
1906                 intel_sdvo_guess_ddc_bus(sdvo);
1907 }
1908
1909 static void
1910 intel_sdvo_select_i2c_bus(struct drm_i915_private *dev_priv,
1911                           struct intel_sdvo *sdvo, u32 reg)
1912 {
1913         struct sdvo_device_mapping *mapping;
1914         u8 pin;
1915
1916         if (sdvo->is_sdvob)
1917                 mapping = &dev_priv->sdvo_mappings[0];
1918         else
1919                 mapping = &dev_priv->sdvo_mappings[1];
1920
1921         pin = GMBUS_PORT_DPB;
1922         if (mapping->initialized)
1923                 pin = mapping->i2c_pin;
1924
1925         if (intel_gmbus_is_port_valid(pin)) {
1926                 sdvo->i2c = intel_gmbus_get_adapter(dev_priv, pin);
1927                 intel_gmbus_set_speed(sdvo->i2c, GMBUS_RATE_1MHZ);
1928                 intel_gmbus_force_bit(sdvo->i2c, true);
1929         } else {
1930                 sdvo->i2c = intel_gmbus_get_adapter(dev_priv, GMBUS_PORT_DPB);
1931         }
1932 }
1933
1934 static bool
1935 intel_sdvo_is_hdmi_connector(struct intel_sdvo *intel_sdvo, int device)
1936 {
1937         return intel_sdvo_check_supp_encode(intel_sdvo);
1938 }
1939
1940 static u8
1941 intel_sdvo_get_slave_addr(struct drm_device *dev, struct intel_sdvo *sdvo)
1942 {
1943         struct drm_i915_private *dev_priv = dev->dev_private;
1944         struct sdvo_device_mapping *my_mapping, *other_mapping;
1945
1946         if (sdvo->is_sdvob) {
1947                 my_mapping = &dev_priv->sdvo_mappings[0];
1948                 other_mapping = &dev_priv->sdvo_mappings[1];
1949         } else {
1950                 my_mapping = &dev_priv->sdvo_mappings[1];
1951                 other_mapping = &dev_priv->sdvo_mappings[0];
1952         }
1953
1954         /* If the BIOS described our SDVO device, take advantage of it. */
1955         if (my_mapping->slave_addr)
1956                 return my_mapping->slave_addr;
1957
1958         /* If the BIOS only described a different SDVO device, use the
1959          * address that it isn't using.
1960          */
1961         if (other_mapping->slave_addr) {
1962                 if (other_mapping->slave_addr == 0x70)
1963                         return 0x72;
1964                 else
1965                         return 0x70;
1966         }
1967
1968         /* No SDVO device info is found for another DVO port,
1969          * so use mapping assumption we had before BIOS parsing.
1970          */
1971         if (sdvo->is_sdvob)
1972                 return 0x70;
1973         else
1974                 return 0x72;
1975 }
1976
1977 static void
1978 intel_sdvo_connector_init(struct intel_sdvo_connector *connector,
1979                           struct intel_sdvo *encoder)
1980 {
1981         drm_connector_init(encoder->base.base.dev,
1982                            &connector->base.base,
1983                            &intel_sdvo_connector_funcs,
1984                            connector->base.base.connector_type);
1985
1986         drm_connector_helper_add(&connector->base.base,
1987                                  &intel_sdvo_connector_helper_funcs);
1988
1989         connector->base.base.interlace_allowed = 1;
1990         connector->base.base.doublescan_allowed = 0;
1991         connector->base.base.display_info.subpixel_order = SubPixelHorizontalRGB;
1992
1993         intel_connector_attach_encoder(&connector->base, &encoder->base);
1994         drm_sysfs_connector_add(&connector->base.base);
1995 }
1996
1997 static void
1998 intel_sdvo_add_hdmi_properties(struct intel_sdvo_connector *connector)
1999 {
2000         struct drm_device *dev = connector->base.base.dev;
2001
2002         intel_attach_force_audio_property(&connector->base.base);
2003         if (INTEL_INFO(dev)->gen >= 4 && IS_MOBILE(dev))
2004                 intel_attach_broadcast_rgb_property(&connector->base.base);
2005 }
2006
2007 static bool
2008 intel_sdvo_dvi_init(struct intel_sdvo *intel_sdvo, int device)
2009 {
2010         struct drm_encoder *encoder = &intel_sdvo->base.base;
2011         struct drm_connector *connector;
2012         struct intel_encoder *intel_encoder = to_intel_encoder(encoder);
2013         struct intel_connector *intel_connector;
2014         struct intel_sdvo_connector *intel_sdvo_connector;
2015
2016         intel_sdvo_connector = kzalloc(sizeof(struct intel_sdvo_connector), GFP_KERNEL);
2017         if (!intel_sdvo_connector)
2018                 return false;
2019
2020         if (device == 0) {
2021                 intel_sdvo->controlled_output |= SDVO_OUTPUT_TMDS0;
2022                 intel_sdvo_connector->output_flag = SDVO_OUTPUT_TMDS0;
2023         } else if (device == 1) {
2024                 intel_sdvo->controlled_output |= SDVO_OUTPUT_TMDS1;
2025                 intel_sdvo_connector->output_flag = SDVO_OUTPUT_TMDS1;
2026         }
2027
2028         intel_connector = &intel_sdvo_connector->base;
2029         connector = &intel_connector->base;
2030         if (intel_sdvo_supports_hotplug(intel_sdvo) & (1 << device)) {
2031                 connector->polled = DRM_CONNECTOR_POLL_HPD;
2032                 intel_sdvo->hotplug_active[0] |= 1 << device;
2033                 /* Some SDVO devices have one-shot hotplug interrupts.
2034                  * Ensure that they get re-enabled when an interrupt happens.
2035                  */
2036                 intel_encoder->hot_plug = intel_sdvo_enable_hotplug;
2037                 intel_sdvo_enable_hotplug(intel_encoder);
2038         }
2039         else
2040                 connector->polled = DRM_CONNECTOR_POLL_CONNECT | DRM_CONNECTOR_POLL_DISCONNECT;
2041         encoder->encoder_type = DRM_MODE_ENCODER_TMDS;
2042         connector->connector_type = DRM_MODE_CONNECTOR_DVID;
2043
2044         if (intel_sdvo_is_hdmi_connector(intel_sdvo, device)) {
2045                 connector->connector_type = DRM_MODE_CONNECTOR_HDMIA;
2046                 intel_sdvo->is_hdmi = true;
2047         }
2048         intel_sdvo->base.clone_mask = ((1 << INTEL_SDVO_NON_TV_CLONE_BIT) |
2049                                        (1 << INTEL_ANALOG_CLONE_BIT));
2050
2051         intel_sdvo_connector_init(intel_sdvo_connector, intel_sdvo);
2052         if (intel_sdvo->is_hdmi)
2053                 intel_sdvo_add_hdmi_properties(intel_sdvo_connector);
2054
2055         return true;
2056 }
2057
2058 static bool
2059 intel_sdvo_tv_init(struct intel_sdvo *intel_sdvo, int type)
2060 {
2061         struct drm_encoder *encoder = &intel_sdvo->base.base;
2062         struct drm_connector *connector;
2063         struct intel_connector *intel_connector;
2064         struct intel_sdvo_connector *intel_sdvo_connector;
2065
2066         intel_sdvo_connector = kzalloc(sizeof(struct intel_sdvo_connector), GFP_KERNEL);
2067         if (!intel_sdvo_connector)
2068                 return false;
2069
2070         intel_connector = &intel_sdvo_connector->base;
2071         connector = &intel_connector->base;
2072         encoder->encoder_type = DRM_MODE_ENCODER_TVDAC;
2073         connector->connector_type = DRM_MODE_CONNECTOR_SVIDEO;
2074
2075         intel_sdvo->controlled_output |= type;
2076         intel_sdvo_connector->output_flag = type;
2077
2078         intel_sdvo->is_tv = true;
2079         intel_sdvo->base.needs_tv_clock = true;
2080         intel_sdvo->base.clone_mask = 1 << INTEL_SDVO_TV_CLONE_BIT;
2081
2082         intel_sdvo_connector_init(intel_sdvo_connector, intel_sdvo);
2083
2084         if (!intel_sdvo_tv_create_property(intel_sdvo, intel_sdvo_connector, type))
2085                 goto err;
2086
2087         if (!intel_sdvo_create_enhance_property(intel_sdvo, intel_sdvo_connector))
2088                 goto err;
2089
2090         return true;
2091
2092 err:
2093         intel_sdvo_destroy(connector);
2094         return false;
2095 }
2096
2097 static bool
2098 intel_sdvo_analog_init(struct intel_sdvo *intel_sdvo, int device)
2099 {
2100         struct drm_encoder *encoder = &intel_sdvo->base.base;
2101         struct drm_connector *connector;
2102         struct intel_connector *intel_connector;
2103         struct intel_sdvo_connector *intel_sdvo_connector;
2104
2105         intel_sdvo_connector = kzalloc(sizeof(struct intel_sdvo_connector), GFP_KERNEL);
2106         if (!intel_sdvo_connector)
2107                 return false;
2108
2109         intel_connector = &intel_sdvo_connector->base;
2110         connector = &intel_connector->base;
2111         connector->polled = DRM_CONNECTOR_POLL_CONNECT;
2112         encoder->encoder_type = DRM_MODE_ENCODER_DAC;
2113         connector->connector_type = DRM_MODE_CONNECTOR_VGA;
2114
2115         if (device == 0) {
2116                 intel_sdvo->controlled_output |= SDVO_OUTPUT_RGB0;
2117                 intel_sdvo_connector->output_flag = SDVO_OUTPUT_RGB0;
2118         } else if (device == 1) {
2119                 intel_sdvo->controlled_output |= SDVO_OUTPUT_RGB1;
2120                 intel_sdvo_connector->output_flag = SDVO_OUTPUT_RGB1;
2121         }
2122
2123         intel_sdvo->base.clone_mask = ((1 << INTEL_SDVO_NON_TV_CLONE_BIT) |
2124                                        (1 << INTEL_ANALOG_CLONE_BIT));
2125
2126         intel_sdvo_connector_init(intel_sdvo_connector,
2127                                   intel_sdvo);
2128         return true;
2129 }
2130
2131 static bool
2132 intel_sdvo_lvds_init(struct intel_sdvo *intel_sdvo, int device)
2133 {
2134         struct drm_encoder *encoder = &intel_sdvo->base.base;
2135         struct drm_connector *connector;
2136         struct intel_connector *intel_connector;
2137         struct intel_sdvo_connector *intel_sdvo_connector;
2138
2139         intel_sdvo_connector = kzalloc(sizeof(struct intel_sdvo_connector), GFP_KERNEL);
2140         if (!intel_sdvo_connector)
2141                 return false;
2142
2143         intel_connector = &intel_sdvo_connector->base;
2144         connector = &intel_connector->base;
2145         encoder->encoder_type = DRM_MODE_ENCODER_LVDS;
2146         connector->connector_type = DRM_MODE_CONNECTOR_LVDS;
2147
2148         if (device == 0) {
2149                 intel_sdvo->controlled_output |= SDVO_OUTPUT_LVDS0;
2150                 intel_sdvo_connector->output_flag = SDVO_OUTPUT_LVDS0;
2151         } else if (device == 1) {
2152                 intel_sdvo->controlled_output |= SDVO_OUTPUT_LVDS1;
2153                 intel_sdvo_connector->output_flag = SDVO_OUTPUT_LVDS1;
2154         }
2155
2156         intel_sdvo->base.clone_mask = ((1 << INTEL_ANALOG_CLONE_BIT) |
2157                                        (1 << INTEL_SDVO_LVDS_CLONE_BIT));
2158
2159         intel_sdvo_connector_init(intel_sdvo_connector, intel_sdvo);
2160         if (!intel_sdvo_create_enhance_property(intel_sdvo, intel_sdvo_connector))
2161                 goto err;
2162
2163         return true;
2164
2165 err:
2166         intel_sdvo_destroy(connector);
2167         return false;
2168 }
2169
2170 static bool
2171 intel_sdvo_output_setup(struct intel_sdvo *intel_sdvo, uint16_t flags)
2172 {
2173         intel_sdvo->is_tv = false;
2174         intel_sdvo->base.needs_tv_clock = false;
2175         intel_sdvo->is_lvds = false;
2176
2177         /* SDVO requires XXX1 function may not exist unless it has XXX0 function.*/
2178
2179         if (flags & SDVO_OUTPUT_TMDS0)
2180                 if (!intel_sdvo_dvi_init(intel_sdvo, 0))
2181                         return false;
2182
2183         if ((flags & SDVO_TMDS_MASK) == SDVO_TMDS_MASK)
2184                 if (!intel_sdvo_dvi_init(intel_sdvo, 1))
2185                         return false;
2186
2187         /* TV has no XXX1 function block */
2188         if (flags & SDVO_OUTPUT_SVID0)
2189                 if (!intel_sdvo_tv_init(intel_sdvo, SDVO_OUTPUT_SVID0))
2190                         return false;
2191
2192         if (flags & SDVO_OUTPUT_CVBS0)
2193                 if (!intel_sdvo_tv_init(intel_sdvo, SDVO_OUTPUT_CVBS0))
2194                         return false;
2195
2196         if (flags & SDVO_OUTPUT_YPRPB0)
2197                 if (!intel_sdvo_tv_init(intel_sdvo, SDVO_OUTPUT_YPRPB0))
2198                         return false;
2199
2200         if (flags & SDVO_OUTPUT_RGB0)
2201                 if (!intel_sdvo_analog_init(intel_sdvo, 0))
2202                         return false;
2203
2204         if ((flags & SDVO_RGB_MASK) == SDVO_RGB_MASK)
2205                 if (!intel_sdvo_analog_init(intel_sdvo, 1))
2206                         return false;
2207
2208         if (flags & SDVO_OUTPUT_LVDS0)
2209                 if (!intel_sdvo_lvds_init(intel_sdvo, 0))
2210                         return false;
2211
2212         if ((flags & SDVO_LVDS_MASK) == SDVO_LVDS_MASK)
2213                 if (!intel_sdvo_lvds_init(intel_sdvo, 1))
2214                         return false;
2215
2216         if ((flags & SDVO_OUTPUT_MASK) == 0) {
2217                 unsigned char bytes[2];
2218
2219                 intel_sdvo->controlled_output = 0;
2220                 memcpy(bytes, &intel_sdvo->caps.output_flags, 2);
2221                 DRM_DEBUG_KMS("%s: Unknown SDVO output type (0x%02x%02x)\n",
2222                               SDVO_NAME(intel_sdvo),
2223                               bytes[0], bytes[1]);
2224                 return false;
2225         }
2226         intel_sdvo->base.crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
2227
2228         return true;
2229 }
2230
2231 static bool intel_sdvo_tv_create_property(struct intel_sdvo *intel_sdvo,
2232                                           struct intel_sdvo_connector *intel_sdvo_connector,
2233                                           int type)
2234 {
2235         struct drm_device *dev = intel_sdvo->base.base.dev;
2236         struct intel_sdvo_tv_format format;
2237         uint32_t format_map, i;
2238
2239         if (!intel_sdvo_set_target_output(intel_sdvo, type))
2240                 return false;
2241
2242         BUILD_BUG_ON(sizeof(format) != 6);
2243         if (!intel_sdvo_get_value(intel_sdvo,
2244                                   SDVO_CMD_GET_SUPPORTED_TV_FORMATS,
2245                                   &format, sizeof(format)))
2246                 return false;
2247
2248         memcpy(&format_map, &format, min(sizeof(format_map), sizeof(format)));
2249
2250         if (format_map == 0)
2251                 return false;
2252
2253         intel_sdvo_connector->format_supported_num = 0;
2254         for (i = 0 ; i < TV_FORMAT_NUM; i++)
2255                 if (format_map & (1 << i))
2256                         intel_sdvo_connector->tv_format_supported[intel_sdvo_connector->format_supported_num++] = i;
2257
2258
2259         intel_sdvo_connector->tv_format =
2260                         drm_property_create(dev, DRM_MODE_PROP_ENUM,
2261                                             "mode", intel_sdvo_connector->format_supported_num);
2262         if (!intel_sdvo_connector->tv_format)
2263                 return false;
2264
2265         for (i = 0; i < intel_sdvo_connector->format_supported_num; i++)
2266                 drm_property_add_enum(
2267                                 intel_sdvo_connector->tv_format, i,
2268                                 i, tv_format_names[intel_sdvo_connector->tv_format_supported[i]]);
2269
2270         intel_sdvo->tv_format_index = intel_sdvo_connector->tv_format_supported[0];
2271         drm_connector_attach_property(&intel_sdvo_connector->base.base,
2272                                       intel_sdvo_connector->tv_format, 0);
2273         return true;
2274
2275 }
2276
2277 #define ENHANCEMENT(name, NAME) do { \
2278         if (enhancements.name) { \
2279                 if (!intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_MAX_##NAME, &data_value, 4) || \
2280                     !intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_##NAME, &response, 2)) \
2281                         return false; \
2282                 intel_sdvo_connector->max_##name = data_value[0]; \
2283                 intel_sdvo_connector->cur_##name = response; \
2284                 intel_sdvo_connector->name = \
2285                         drm_property_create_range(dev, 0, #name, 0, data_value[0]); \
2286                 if (!intel_sdvo_connector->name) return false; \
2287                 drm_connector_attach_property(connector, \
2288                                               intel_sdvo_connector->name, \
2289                                               intel_sdvo_connector->cur_##name); \
2290                 DRM_DEBUG_KMS(#name ": max %d, default %d, current %d\n", \
2291                               data_value[0], data_value[1], response); \
2292         } \
2293 } while (0)
2294
2295 static bool
2296 intel_sdvo_create_enhance_property_tv(struct intel_sdvo *intel_sdvo,
2297                                       struct intel_sdvo_connector *intel_sdvo_connector,
2298                                       struct intel_sdvo_enhancements_reply enhancements)
2299 {
2300         struct drm_device *dev = intel_sdvo->base.base.dev;
2301         struct drm_connector *connector = &intel_sdvo_connector->base.base;
2302         uint16_t response, data_value[2];
2303
2304         /* when horizontal overscan is supported, Add the left/right  property */
2305         if (enhancements.overscan_h) {
2306                 if (!intel_sdvo_get_value(intel_sdvo,
2307                                           SDVO_CMD_GET_MAX_OVERSCAN_H,
2308                                           &data_value, 4))
2309                         return false;
2310
2311                 if (!intel_sdvo_get_value(intel_sdvo,
2312                                           SDVO_CMD_GET_OVERSCAN_H,
2313                                           &response, 2))
2314                         return false;
2315
2316                 intel_sdvo_connector->max_hscan = data_value[0];
2317                 intel_sdvo_connector->left_margin = data_value[0] - response;
2318                 intel_sdvo_connector->right_margin = intel_sdvo_connector->left_margin;
2319                 intel_sdvo_connector->left =
2320                         drm_property_create_range(dev, 0, "left_margin", 0, data_value[0]);
2321                 if (!intel_sdvo_connector->left)
2322                         return false;
2323
2324                 drm_connector_attach_property(connector,
2325                                               intel_sdvo_connector->left,
2326                                               intel_sdvo_connector->left_margin);
2327
2328                 intel_sdvo_connector->right =
2329                         drm_property_create_range(dev, 0, "right_margin", 0, data_value[0]);
2330                 if (!intel_sdvo_connector->right)
2331                         return false;
2332
2333                 drm_connector_attach_property(connector,
2334                                               intel_sdvo_connector->right,
2335                                               intel_sdvo_connector->right_margin);
2336                 DRM_DEBUG_KMS("h_overscan: max %d, "
2337                               "default %d, current %d\n",
2338                               data_value[0], data_value[1], response);
2339         }
2340
2341         if (enhancements.overscan_v) {
2342                 if (!intel_sdvo_get_value(intel_sdvo,
2343                                           SDVO_CMD_GET_MAX_OVERSCAN_V,
2344                                           &data_value, 4))
2345                         return false;
2346
2347                 if (!intel_sdvo_get_value(intel_sdvo,
2348                                           SDVO_CMD_GET_OVERSCAN_V,
2349                                           &response, 2))
2350                         return false;
2351
2352                 intel_sdvo_connector->max_vscan = data_value[0];
2353                 intel_sdvo_connector->top_margin = data_value[0] - response;
2354                 intel_sdvo_connector->bottom_margin = intel_sdvo_connector->top_margin;
2355                 intel_sdvo_connector->top =
2356                         drm_property_create_range(dev, 0,
2357                                             "top_margin", 0, data_value[0]);
2358                 if (!intel_sdvo_connector->top)
2359                         return false;
2360
2361                 drm_connector_attach_property(connector,
2362                                               intel_sdvo_connector->top,
2363                                               intel_sdvo_connector->top_margin);
2364
2365                 intel_sdvo_connector->bottom =
2366                         drm_property_create_range(dev, 0,
2367                                             "bottom_margin", 0, data_value[0]);
2368                 if (!intel_sdvo_connector->bottom)
2369                         return false;
2370
2371                 drm_connector_attach_property(connector,
2372                                               intel_sdvo_connector->bottom,
2373                                               intel_sdvo_connector->bottom_margin);
2374                 DRM_DEBUG_KMS("v_overscan: max %d, "
2375                               "default %d, current %d\n",
2376                               data_value[0], data_value[1], response);
2377         }
2378
2379         ENHANCEMENT(hpos, HPOS);
2380         ENHANCEMENT(vpos, VPOS);
2381         ENHANCEMENT(saturation, SATURATION);
2382         ENHANCEMENT(contrast, CONTRAST);
2383         ENHANCEMENT(hue, HUE);
2384         ENHANCEMENT(sharpness, SHARPNESS);
2385         ENHANCEMENT(brightness, BRIGHTNESS);
2386         ENHANCEMENT(flicker_filter, FLICKER_FILTER);
2387         ENHANCEMENT(flicker_filter_adaptive, FLICKER_FILTER_ADAPTIVE);
2388         ENHANCEMENT(flicker_filter_2d, FLICKER_FILTER_2D);
2389         ENHANCEMENT(tv_chroma_filter, TV_CHROMA_FILTER);
2390         ENHANCEMENT(tv_luma_filter, TV_LUMA_FILTER);
2391
2392         if (enhancements.dot_crawl) {
2393                 if (!intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_DOT_CRAWL, &response, 2))
2394                         return false;
2395
2396                 intel_sdvo_connector->max_dot_crawl = 1;
2397                 intel_sdvo_connector->cur_dot_crawl = response & 0x1;
2398                 intel_sdvo_connector->dot_crawl =
2399                         drm_property_create_range(dev, 0, "dot_crawl", 0, 1);
2400                 if (!intel_sdvo_connector->dot_crawl)
2401                         return false;
2402
2403                 drm_connector_attach_property(connector,
2404                                               intel_sdvo_connector->dot_crawl,
2405                                               intel_sdvo_connector->cur_dot_crawl);
2406                 DRM_DEBUG_KMS("dot crawl: current %d\n", response);
2407         }
2408
2409         return true;
2410 }
2411
2412 static bool
2413 intel_sdvo_create_enhance_property_lvds(struct intel_sdvo *intel_sdvo,
2414                                         struct intel_sdvo_connector *intel_sdvo_connector,
2415                                         struct intel_sdvo_enhancements_reply enhancements)
2416 {
2417         struct drm_device *dev = intel_sdvo->base.base.dev;
2418         struct drm_connector *connector = &intel_sdvo_connector->base.base;
2419         uint16_t response, data_value[2];
2420
2421         ENHANCEMENT(brightness, BRIGHTNESS);
2422
2423         return true;
2424 }
2425 #undef ENHANCEMENT
2426
2427 static bool intel_sdvo_create_enhance_property(struct intel_sdvo *intel_sdvo,
2428                                                struct intel_sdvo_connector *intel_sdvo_connector)
2429 {
2430         union {
2431                 struct intel_sdvo_enhancements_reply reply;
2432                 uint16_t response;
2433         } enhancements;
2434
2435         BUILD_BUG_ON(sizeof(enhancements) != 2);
2436
2437         enhancements.response = 0;
2438         intel_sdvo_get_value(intel_sdvo,
2439                              SDVO_CMD_GET_SUPPORTED_ENHANCEMENTS,
2440                              &enhancements, sizeof(enhancements));
2441         if (enhancements.response == 0) {
2442                 DRM_DEBUG_KMS("No enhancement is supported\n");
2443                 return true;
2444         }
2445
2446         if (IS_TV(intel_sdvo_connector))
2447                 return intel_sdvo_create_enhance_property_tv(intel_sdvo, intel_sdvo_connector, enhancements.reply);
2448         else if (IS_LVDS(intel_sdvo_connector))
2449                 return intel_sdvo_create_enhance_property_lvds(intel_sdvo, intel_sdvo_connector, enhancements.reply);
2450         else
2451                 return true;
2452 }
2453
2454 static int intel_sdvo_ddc_proxy_xfer(struct i2c_adapter *adapter,
2455                                      struct i2c_msg *msgs,
2456                                      int num)
2457 {
2458         struct intel_sdvo *sdvo = adapter->algo_data;
2459
2460         if (!intel_sdvo_set_control_bus_switch(sdvo, sdvo->ddc_bus))
2461                 return -EIO;
2462
2463         return sdvo->i2c->algo->master_xfer(sdvo->i2c, msgs, num);
2464 }
2465
2466 static u32 intel_sdvo_ddc_proxy_func(struct i2c_adapter *adapter)
2467 {
2468         struct intel_sdvo *sdvo = adapter->algo_data;
2469         return sdvo->i2c->algo->functionality(sdvo->i2c);
2470 }
2471
2472 static const struct i2c_algorithm intel_sdvo_ddc_proxy = {
2473         .master_xfer    = intel_sdvo_ddc_proxy_xfer,
2474         .functionality  = intel_sdvo_ddc_proxy_func
2475 };
2476
2477 static bool
2478 intel_sdvo_init_ddc_proxy(struct intel_sdvo *sdvo,
2479                           struct drm_device *dev)
2480 {
2481         sdvo->ddc.owner = THIS_MODULE;
2482         sdvo->ddc.class = I2C_CLASS_DDC;
2483         snprintf(sdvo->ddc.name, I2C_NAME_SIZE, "SDVO DDC proxy");
2484         sdvo->ddc.dev.parent = &dev->pdev->dev;
2485         sdvo->ddc.algo_data = sdvo;
2486         sdvo->ddc.algo = &intel_sdvo_ddc_proxy;
2487
2488         return i2c_add_adapter(&sdvo->ddc) == 0;
2489 }
2490
2491 bool intel_sdvo_init(struct drm_device *dev, uint32_t sdvo_reg, bool is_sdvob)
2492 {
2493         struct drm_i915_private *dev_priv = dev->dev_private;
2494         struct intel_encoder *intel_encoder;
2495         struct intel_sdvo *intel_sdvo;
2496         int i;
2497
2498         intel_sdvo = kzalloc(sizeof(struct intel_sdvo), GFP_KERNEL);
2499         if (!intel_sdvo)
2500                 return false;
2501
2502         intel_sdvo->sdvo_reg = sdvo_reg;
2503         intel_sdvo->is_sdvob = is_sdvob;
2504         intel_sdvo->slave_addr = intel_sdvo_get_slave_addr(dev, intel_sdvo) >> 1;
2505         intel_sdvo_select_i2c_bus(dev_priv, intel_sdvo, sdvo_reg);
2506         if (!intel_sdvo_init_ddc_proxy(intel_sdvo, dev)) {
2507                 kfree(intel_sdvo);
2508                 return false;
2509         }
2510
2511         /* encoder type will be decided later */
2512         intel_encoder = &intel_sdvo->base;
2513         intel_encoder->type = INTEL_OUTPUT_SDVO;
2514         drm_encoder_init(dev, &intel_encoder->base, &intel_sdvo_enc_funcs, 0);
2515
2516         /* Read the regs to test if we can talk to the device */
2517         for (i = 0; i < 0x40; i++) {
2518                 u8 byte;
2519
2520                 if (!intel_sdvo_read_byte(intel_sdvo, i, &byte)) {
2521                         DRM_DEBUG_KMS("No SDVO device found on %s\n",
2522                                       SDVO_NAME(intel_sdvo));
2523                         goto err;
2524                 }
2525         }
2526
2527         if (intel_sdvo->is_sdvob)
2528                 dev_priv->hotplug_supported_mask |= SDVOB_HOTPLUG_INT_STATUS;
2529         else
2530                 dev_priv->hotplug_supported_mask |= SDVOC_HOTPLUG_INT_STATUS;
2531
2532         drm_encoder_helper_add(&intel_encoder->base, &intel_sdvo_helper_funcs);
2533
2534         /* In default case sdvo lvds is false */
2535         if (!intel_sdvo_get_capabilities(intel_sdvo, &intel_sdvo->caps))
2536                 goto err;
2537
2538         /* Set up hotplug command - note paranoia about contents of reply.
2539          * We assume that the hardware is in a sane state, and only touch
2540          * the bits we think we understand.
2541          */
2542         intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_ACTIVE_HOT_PLUG,
2543                              &intel_sdvo->hotplug_active, 2);
2544         intel_sdvo->hotplug_active[0] &= ~0x3;
2545
2546         if (intel_sdvo_output_setup(intel_sdvo,
2547                                     intel_sdvo->caps.output_flags) != true) {
2548                 DRM_DEBUG_KMS("SDVO output failed to setup on %s\n",
2549                               SDVO_NAME(intel_sdvo));
2550                 goto err;
2551         }
2552
2553         intel_sdvo_select_ddc_bus(dev_priv, intel_sdvo, sdvo_reg);
2554
2555         /* Set the input timing to the screen. Assume always input 0. */
2556         if (!intel_sdvo_set_target_input(intel_sdvo))
2557                 goto err;
2558
2559         if (!intel_sdvo_get_input_pixel_clock_range(intel_sdvo,
2560                                                     &intel_sdvo->pixel_clock_min,
2561                                                     &intel_sdvo->pixel_clock_max))
2562                 goto err;
2563
2564         DRM_DEBUG_KMS("%s device VID/DID: %02X:%02X.%02X, "
2565                         "clock range %dMHz - %dMHz, "
2566                         "input 1: %c, input 2: %c, "
2567                         "output 1: %c, output 2: %c\n",
2568                         SDVO_NAME(intel_sdvo),
2569                         intel_sdvo->caps.vendor_id, intel_sdvo->caps.device_id,
2570                         intel_sdvo->caps.device_rev_id,
2571                         intel_sdvo->pixel_clock_min / 1000,
2572                         intel_sdvo->pixel_clock_max / 1000,
2573                         (intel_sdvo->caps.sdvo_inputs_mask & 0x1) ? 'Y' : 'N',
2574                         (intel_sdvo->caps.sdvo_inputs_mask & 0x2) ? 'Y' : 'N',
2575                         /* check currently supported outputs */
2576                         intel_sdvo->caps.output_flags &
2577                         (SDVO_OUTPUT_TMDS0 | SDVO_OUTPUT_RGB0) ? 'Y' : 'N',
2578                         intel_sdvo->caps.output_flags &
2579                         (SDVO_OUTPUT_TMDS1 | SDVO_OUTPUT_RGB1) ? 'Y' : 'N');
2580         return true;
2581
2582 err:
2583         drm_encoder_cleanup(&intel_encoder->base);
2584         i2c_del_adapter(&intel_sdvo->ddc);
2585         kfree(intel_sdvo);
2586
2587         return false;
2588 }